Skip to contentSkip to conversation

Fix silent output on Gigabyte X570 Aorus Master

PATCH In review Christian Lachner 2 participants 5 messages Mar 3, 2020 – Mar 6, 2020 Sound

lore
Share & tools
lore
#0 lore raw

v2 cover Fix silent output on Gigabyte X570 Aorus Master

The Gigabyte X570 Aorus Master motherboard with ALC1220 codec requires a similar workaround for Clevo laptops to enforce the DAC/mixer connection path. This patch sets up a quirk entry for that. It was tested by myself on my own hardware for some time and it works just fine. We should probably rename ALC1220_FIXUP_CLEVO_P950 at some point as the amount of non-Clevo hardware needing this workaround is growing.

Christian Lachner (1):
ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

base-commit: 98d54f81e36ba3bf92172791eba5ca5bd813989b

Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master

The Gigabyte X570 Aorus Master motherboard with ALC1220 codec requires a similar workaround for Clevo laptops to enforce the DAC/mixer connection path. Set up a quirk entry for that.

---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
index 477589e7ec1d..8722616c6cc6 100644
@@ -2447,6 +2447,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+	SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65", ALC1220_FIXUP_CLEVO_P950),
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master

Quoted 7 lines · Christian Lachner

The Gigabyte X570 Aorus Master motherboard with ALC1220 codec requires a similar workaround for Clevo laptops to enforce the DAC/mixer connection path. Set up a quirk entry for that.

What's the difference from v1? I already applied v1.

thanks,

Takashi

Quoted 19 lines
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
index 477589e7ec1d..8722616c6cc6 100644
@@ -2447,6 +2447,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+	SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65", ALC1220_FIXUP_CLEVO_P950),
Signature · 1 line
2.25.1
author
#3 lore raw

Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master

Hello, I am really sorry for the mess-up. It is the exact same patch. I just re-sent it because v1 did not show up in the alsa-devel mailinglist because i did not do the registration beforehand. Please ignore v2. Thanks a lot, Chris

Takashi Iwai <[email protected]> schrieb am Do., 5. März 2020, 15:52:

Quoted 47 lines
Quoted 7 lines · Christian Lachner

The Gigabyte X570 Aorus Master motherboard with ALC1220 codec requires a similar workaround for Clevo laptops to enforce the DAC/mixer connection path. Set up a quirk entry for that.

What's the difference from v1? I already applied v1.

thanks,

Takashi

Review

Quoted 5 lines
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/sound/pci/hda/patch_realtek.c

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk

Quoted 4 lines

index 477589e7ec1d..8722616c6cc6 100644

sound/pci/hda/patch_realtek.c +0 -0
@@ -2447,6 +2447,7 @@ static const struct snd_pci_quirk

alc882_fixup_tbl[] = {

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2447

Quoted 1 line
sound/pci/hda/patch_realtek.c +0 -0
      SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger",

ALC882_FIXUP_EAPD),

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2448

Quoted 1 line
sound/pci/hda/patch_realtek.c +0 -0
      SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H",

ALC889_FIXUP_FRONT_HP_NO_PRESENCE),

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2449

Quoted 1 line
sound/pci/hda/patch_realtek.c +0 -0
      SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming",

ALC1220_FIXUP_GB_DUAL_CODECS),

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2450

Quoted 1 line
sound/pci/hda/patch_realtek.c +1 -0
+     SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master",

ALC1220_FIXUP_CLEVO_P950),

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2451

Quoted 1 line
sound/pci/hda/patch_realtek.c +0 -0
      SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63",

ALC1220_FIXUP_CLEVO_P950),

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2452

Quoted 1 line
sound/pci/hda/patch_realtek.c +0 -0
      SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73",

ALC1220_FIXUP_CLEVO_P950),

sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk · line 2453

Quoted 1 line
sound/pci/hda/patch_realtek.c +0 -0
      SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65",

ALC1220_FIXUP_CLEVO_P950),

Quoted 3 lines

--
2.25.1

#4 lore raw

Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master

Quoted 5 lines · Chris

Hello, I am really sorry for the mess-up. It is the exact same patch. I just re-sent it because v1 did not show up in the alsa-devel mailinglist because i did not do the registration beforehand. Please ignore v2.
Thanks a lot, Chris

OK, thanks for confirmation.

Takashi