add codec-specific controls for UCB1400
PATCH 1/1 add codec-specific controls for UCB1400
This patch adds some codec-specific controls for Philips UCB1400 codec.
Signature · 2 lines
Sincerely yours, Mike Rapoport
sound/pci/ac97/ac97_codec.c | 2 +- sound/pci/ac97/ac97_patch.c | 30 ++++++++++++++++++++++++++++++ sound/pci/ac97/ac97_patch.h | 1 + 3 files changed, 32 insertions(+), 1 deletions(-)
sound/pci/ac97/ac97_codec.c +1 -1
@@ -150,7 +150,7 @@ static const struct ac97_codec_id snd_ac { 0x4e534300, 0xffffffff, "LM4540,43,45,46,48", NULL, NULL }, // only guess --jk { 0x4e534331, 0xffffffff, "LM4549", NULL, NULL }, { 0x4e534350, 0xffffffff, "LM4550", NULL, NULL }, -{ 0x50534304, 0xffffffff, "UCB1400", NULL, NULL }, +{ 0x50534304, 0xffffffff, "UCB1400", patch_ucb1400, NULL }, { 0x53494c20, 0xffffffe0, "Si3036,8", mpatch_si3036, mpatch_si3036, AC97_MODEM_PATCH }, { 0x54524102, 0xffffffff, "TR28022", NULL, NULL }, { 0x54524106, 0xffffffff, "TR28026", NULL, NULL },
sound/pci/ac97/ac97_patch.c +30 -0
@@ -2823,3 +2823,33 @@ int mpatch_si3036(struct snd_ac97 * ac97snd_ac97_write_cache (ac97,0x68 ,0 );return 0 ; } + +/* +* UCB1400 codec +*/ +static const struct snd_kcontrol_new snd_ac97_controls_ucb1400[] = { +AC97_SINGLE ("Headphone driver" ,0x6a ,6 ,1 ,0 ), +AC97_SINGLE ("DC filter" ,0x6a ,4 ,1 ,0 ), +AC97_SINGLE ("Smart power mode" ,0x6c ,4 ,3 ,0 ), +}; + +static int patch_ucb1400_specific (struct snd_ac97 * ac97) +{ +int idx, err; +for (idx =0 ; idx <ARRAY_SIZE (snd_ac97_controls_ucb1400); idx++) +if ((err =snd_ctl_add (ac97->bus->card,snd_ctl_new1 (&snd_ac97_controls_ucb1400[idx], ac97))) <0 ) +return err; +return 0 ; +} + +static struct snd_ac97_build_ops patch_ucb1400_ops = { + .build_specific = patch_ucb1400_specific, +}; + +int patch_ucb1400 (struct snd_ac97 * ac97) +{ + ac97->build_ops = &patch_ucb1400_ops; +snd_ac97_write (ac97,0x6a ,0x0050 ); +snd_ac97_write (ac97,0x6c ,0x0030 ); +return 0 ; +}
sound/pci/ac97/ac97_patch.h +1 -0
@@ -58,4 +58,5 @@ int patch_cm9780(struct snd_ac97 * ac97)int patch_vt1616 (struct snd_ac97 * ac97);int patch_vt1617a (struct snd_ac97 * ac97);int patch_it2646 (struct snd_ac97 * ac97); +int patch_ucb1400 (struct snd_ac97 * ac97);int mpatch_si3036 (struct snd_ac97 * ac97);
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
At Thu, 29 Jun 2006 14:37:20 +0200,
sound/pci/ac97/ac97_patch.c int mpatch_si3036(struct snd_ac97 * ac97 · line 2833
Quoted 9 lines · Mike Rapoport
sound/pci/ac97/ac97_patch.c +8
-0+ +/* +* UCB1400 codec +*/ +static const struct snd_kcontrol_new snd_ac97_controls_ucb1400[] = { +AC97_SINGLE ("Headphone driver" ,0x6a ,6 ,1 ,0 ), +AC97_SINGLE ("DC filter" ,0x6a ,4 ,1 ,0 ), +AC97_SINGLE ("Smart power mode" ,0x6c ,4 ,3 ,0 ),
What exactly do these controls? Would be nice to have some comments in the code, too.
Also, words in control names usually begin with capital letters.
Otherwise the patch looks good. Thanks.
Takashi
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
Quoted 6 lines · Takashi Iwai
What exactly do these controls? Would be nice to have some comments in the code, too.
added
Quoted 3 lines
Also, words in control names usually begin with capital letters.
fixed
Quoted 9 lines
Otherwise the patch looks good. Thanks.
Takashi
Signature · 2 lines
Sincerely yours, Mike Rapoport
sound/pci/ac97/ac97_codec.c | 2 +- sound/pci/ac97/ac97_patch.c | 38 ++++++++++++++++++++++++++++++++++++++ sound/pci/ac97/ac97_patch.h | 1 + 3 files changed, 40 insertions(+), 1 deletions(-)
sound/pci/ac97/ac97_codec.c +1 -1
@@ -150,7 +150,7 @@ static const struct ac97_codec_id snd_ac { 0x4e534300, 0xffffffff, "LM4540,43,45,46,48", NULL, NULL }, // only guess --jk { 0x4e534331, 0xffffffff, "LM4549", NULL, NULL }, { 0x4e534350, 0xffffffff, "LM4550", NULL, NULL }, -{ 0x50534304, 0xffffffff, "UCB1400", NULL, NULL }, +{ 0x50534304, 0xffffffff, "UCB1400", patch_ucb1400, NULL }, { 0x53494c20, 0xffffffe0, "Si3036,8", mpatch_si3036, mpatch_si3036, AC97_MODEM_PATCH }, { 0x54524102, 0xffffffff, "TR28022", NULL, NULL }, { 0x54524106, 0xffffffff, "TR28026", NULL, NULL },
sound/pci/ac97/ac97_patch.c +38 -0
@@ -2823,3 +2823,41 @@ int mpatch_si3036(struct snd_ac97 * ac97snd_ac97_write_cache (ac97,0x68 ,0 );return 0 ; } + +/* +* UCB1400 codec (http://www.semiconductors.philips.com/acrobat_download/datasheets/UCB1400-02.pdf) +*/ +static const struct snd_kcontrol_new snd_ac97_controls_ucb1400[] = { +/* enable/disable headphone driver which allows direct connection to +stereo headphone without the use of external DC blocking +capacitors */ +AC97_SINGLE ("Headphone Driver" ,0x6a ,6 ,1 ,0 ), +/* Filter used to compensate the DC offset is added in the ADC to remove idle +tones from the audio band. */ +AC97_SINGLE ("DC Filter" ,0x6a ,4 ,1 ,0 ), +/* Control smart-low-power mode feature. Allows automatic power down +of unused blocks in the ADC analog front end and the PLL. */ +AC97_SINGLE ("Smart Low Power Mode" ,0x6c ,4 ,3 ,0 ), +}; + +static int patch_ucb1400_specific (struct snd_ac97 * ac97) +{ +int idx, err; +for (idx =0 ; idx <ARRAY_SIZE (snd_ac97_controls_ucb1400); idx++) +if ((err =snd_ctl_add (ac97->bus->card,snd_ctl_new1 (&snd_ac97_controls_ucb1400[idx], ac97))) <0 ) +return err; +return 0 ; +} + +static struct snd_ac97_build_ops patch_ucb1400_ops = { + .build_specific = patch_ucb1400_specific, +}; + +int patch_ucb1400 (struct snd_ac97 * ac97) +{ + ac97->build_ops = &patch_ucb1400_ops; +/* enable headphone driver and smart low power mode by default */ +snd_ac97_write (ac97,0x6a ,0x0050 ); +snd_ac97_write (ac97,0x6c ,0x0030 ); +return 0 ; +}
sound/pci/ac97/ac97_patch.h +1 -0
@@ -58,4 +58,5 @@ int patch_cm9780(struct snd_ac97 * ac97)int patch_vt1616 (struct snd_ac97 * ac97);int patch_vt1617a (struct snd_ac97 * ac97);int patch_it2646 (struct snd_ac97 * ac97); +int patch_ucb1400 (struct snd_ac97 * ac97);int mpatch_si3036 (struct snd_ac97 * ac97);
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
Takashi Iwai
AppliedAt Thu, 29 Jun 2006 16:19:40 +0200,
Quoted 9 lines · Mike Rapoport
Quoted 6 lines · Takashi Iwai
What exactly do these controls? Would be nice to have some comments in the code, too.
Quoted 6 lines
added
Quoted 3 lines
Also, words in control names usually begin with capital letters.
fixed
Thanks, applied to HG repo now.
Takashi
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642