Skip to contentSkip to conversation

linux-next: build warnings after merge of the sound tree

DISCUSSION Stephen Rothwell 2 participants 2 messages Oct 19, 2021 Linux-next tree

lore
Share & tools
lore

Stephen Rothwell

author
#0 lore raw

Hi all,

After merging the sound tree, today's linux-next build (htmldocs) produced these warnings:

sound/core/memalloc.c:203: warning: Function parameter or member 'mode' not described in 'snd_dma_buffer_sync' sound/core/memalloc.c:203: warning: Excess function parameter 'mod' description in 'snd_dma_buffer_sync'

Introduced by commit

a25684a95646 ("ALSA: memalloc: Support for non-contiguous page allocation")

Also, the declaration of this function in include/ound/memalloc.h looks incorrect as it has different declarations depending on CONFIG_HAS_DMA, but then another one afterwards. I expect this will cause errors if CONFIG_HAS_DMA is not set.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 6 lines · Stephen Rothwell

Hi all,

After merging the sound tree, today's linux-next build (htmldocs) produced these warnings:

Quoted 6 lines

sound/core/memalloc.c:203: warning: Function parameter or member 'mode' not described in 'snd_dma_buffer_sync' sound/core/memalloc.c:203: warning: Excess function parameter 'mod' description in 'snd_dma_buffer_sync'

Introduced by commit

a25684a95646 ("ALSA: memalloc: Support for non-contiguous page allocation")

Thanks, I will fix this typo.

Quoted 4 lines

Also, the declaration of this function in include/ound/memalloc.h looks incorrect as it has different declarations depending on CONFIG_HAS_DMA, but then another one afterwards. I expect this will cause errors if CONFIG_HAS_DMA is not set.

Gah this was a leftover after some rebase. Will fix up altogether.

thanks,

Takashi