Skip to contentSkip to conversation

sequencer: clean up remove bogus check

PATCH In review Dan Carpenter 2 participants 2 messages Mar 16, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sequencer: clean up remove bogus check

A few lines earlier bend is limited to 2399. So semitones is always less than 24 here.

sound/oss/sequencer.c +0 -2
index c798746..e85789e 100644
@@ -1631,8 +1631,6 @@ unsigned long compute_finetune(unsigned long base_freq, int bend, int range,
 	}
 
 	semitones = bend / 100;
-	if (semitones > 99)
-		semitones = 99;
 	cents = bend % 100;
 
 	amount = (int) (semitone_tuning[semitones] * multiplier * cent_tuning[cents]) / 10000;
#1 lore raw

At Tue, 16 Mar 2010 09:46:23 +0300,

Quoted 5 lines · Dan Carpenter

A few lines earlier bend is limited to 2399. So semitones is always less than 24 here.

Applied now. Thanks.
(That range check is even wrong since the array size is 24...)

Takashi

Quoted 14 lines
sound/oss/sequencer.c +0 -2
index c798746..e85789e 100644
@@ -1631,8 +1631,6 @@ unsigned long compute_finetune(unsigned long base_freq, int bend, int range,
 	}
 
 	semitones = bend / 100;
-	if (semitones > 99)
-		semitones = 99;
 	cents = bend % 100;
 
 	amount = (int) (semitone_tuning[semitones] * multiplier * cent_tuning[cents]) / 10000;