Skip to contentSkip to conversation

Input: Remove unneeded '\n' from psmouse.proto parameter

PATCH Applied Takashi Iwai 2 participants 2 messages Nov 13, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: Remove unneeded '\n' from psmouse.proto parameter

The get parameter function should return a string without a life-feed. Otherwise you'll see additional empty line in sysfs parameters file.

---
 drivers/input/mouse/psmouse-base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/mouse/psmouse-base.c +1 -1
index 690aed9..5bd6484 100644
@@ -1673,7 +1673,7 @@ static int psmouse_get_maxproto(char *buffer, struct kernel_param *kp)
 {
 	int type = *((unsigned int *)kp->arg);
 
-	return sprintf(buffer, "%s\n", psmouse_protocol_by_type(type)->name);
+	return sprintf(buffer, "%s", psmouse_protocol_by_type(type)->name);
 }
 
 static int __init psmouse_init(void)
Signature · 1 line
1.6.4.2
maintainer Applied
#1 lore raw
Quoted 4 lines · Takashi Iwai

The get parameter function should return a string without a life-feed. Otherwise you'll see additional empty line in sysfs parameters file.

Applied, thank you Takashi.

Signature · 1 line
Dmitry