Skip to contentSkip to conversation

sound/isa/cmi8330.c: dead ENABLE_SB_MIXER code

DISCUSSION Adrian Bunk 3 participants 4 messages Dec 4, 2006 – Dec 21, 2006

lore
Share & tools
lore
#0 lore raw

In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never used.

What's the story behind this?
Should ENABLE_SB_MIXER be enabled?
Or the code be removed?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw

At Mon, 4 Dec 2006 17:04:34 +0100,

Quoted 7 lines · Adrian Bunk

In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never used.

What's the story behind this?
Should ENABLE_SB_MIXER be enabled?
Or the code be removed?

CMI8330 has a dual interface for SB and Adlib modes. The mixer can also behave differently according to the mode. The current code has mixer elements corresponding to both modes.

However, these mixer elements _seem_ to interactive with each other, and cannot be controlled individually. That's why ENABLE_SB_MIXER is disabled. I cannot check this issue any longer since the test board got broken long time ago...

I don't think we would get many gain by changing this old code. (and the relevant part isn't so big.)
Let's keep as it is.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#2 lore raw
In reply to Adrian Bunk

At Mon, 4 Dec 2006 17:04:34 +0100,

Quoted 7 lines · Adrian Bunk

In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never used.

What's the story behind this?
Should ENABLE_SB_MIXER be enabled?
Or the code be removed?

CMI8330 has a dual interface for SB and Adlib modes. The mixer can also behave differently according to the mode. The current code has mixer elements corresponding to both modes.

However, these mixer elements _seem_ to interactive with each other, and cannot be controlled individually. That's why ENABLE_SB_MIXER is disabled. I cannot check this issue any longer since the test board got broken long time ago...

I don't think we would get many gain by changing this old code. (and the relevant part isn't so big.)
Let's keep as it is.

Takashi

#3 lore raw
Quoted 6 lines · you

At Mon, 4 Dec 2006 17:04:34 +0100,

Quoted 3 lines · Adrian Bunk

In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never used.

Quoted 7 lines
Quoted 3 lines

What's the story behind this?
Should ENABLE_SB_MIXER be enabled?
Or the code be removed?

CMI8330 has a dual interface for SB and Adlib modes. The mixer can also behave differently according to the mode. The current code has mixer elements corresponding to both modes.

CMI8330 (and also CMI8329) appears like SB16 and WSS

Quoted 4 lines

However, these mixer elements _seem_ to interactive with each other, and cannot be controlled individually. That's why ENABLE_SB_MIXER is disabled. I cannot check this issue any longer since the test board got broken long time ago...

The mixer is a bit weird - and probably different between CMI8329 and CMI8330. At least on my CMI8329A, the master volume does not work. And there are also some problems with PCM volume - I can decrease it in alsamixer but not increase - but it works both ways in XMMS...
I have also some boards with integrated CMI8330 - so I might test it sometimes.

Quoted 11 lines

I don't think we would get many gain by changing this old code. (and the relevant part isn't so big.)
Let's keep as it is.

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 7 lines
Ondrej Zary

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV