Skip to contentSkip to conversation

Fix a string format ambiguity

PATCH In review Colin Guthrie 2 participants 2 messages Apr 17, 2010 – May 27, 2010

lore
Share & tools
lore

Colin Guthrie

author
#0 lore raw

PATCH 1/1 Fix a string format ambiguity

Hi,

Simply patch to fix a format-string ambiguity.

Meant to give this over before 1.0.23 but forgot.

Col

Signature · 10 lines
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mandriva Linux Contributor [http://www.mandriva.com/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]
Quoted 1 line

From a57b4e4d1433d14e6fda9b675ade7e901222381b Mon Sep 17 00:00:00 2001

From: Colin Guthrie <[email protected]>
Date: Sun, 28 Feb 2010 22:25:26 +0000
Subject: [PATCH 501/501] Fix a string format ambiguity

---
 src/alisp/alisp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/alisp/alisp.c +1 -1
index f3580f9..7575f55 100644
@@ -1712,7 +1712,7 @@ static struct alisp_object * F_princ(struct alisp_instance *instance, struct ali
 			delete_tree(instance, p1);
 		p1 = eval(instance, car(p));
 		if (alisp_compare_type(p1, ALISP_OBJ_STRING))
-			snd_output_printf(instance->out, p1->value.s);
+			snd_output_printf(instance->out, "%s", p1->value.s);
 		else
 			princ_object(instance->out, p1);
 		n = cdr(p);
Signature · 1 line
1.7.0

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Sat, 17 Apr 2010 10:49:55 +0100,

Quoted 5 lines · Colin Guthrie
Quoted 2 lines

From a57b4e4d1433d14e6fda9b675ade7e901222381b Mon Sep 17 00:00:00 2001

From: Colin Guthrie <[email protected]>
Date: Sun, 28 Feb 2010 22:25:26 +0000
Subject: [PATCH 501/501] Fix a string format ambiguity

Applied now. Thanks.

Takashi

Quoted 21 lines
---
 src/alisp/alisp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/alisp/alisp.c +1 -1
index f3580f9..7575f55 100644
@@ -1712,7 +1712,7 @@ static struct alisp_object * F_princ(struct alisp_instance *instance, struct ali
 			delete_tree(instance, p1);
 		p1 = eval(instance, car(p));
 		if (alisp_compare_type(p1, ALISP_OBJ_STRING))
-			snd_output_printf(instance->out, p1->value.s);
+			snd_output_printf(instance->out, "%s", p1->value.s);
 		else
 			princ_object(instance->out, p1);
 		n = cdr(p);
Signature · 1 line
1.7.0