Skip to contentSkip to conversation

ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static

PATCH In review Adrian Bunk 2 participants 2 messages Nov 22, 2004 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA sound/pcmcia/pdaudiocf/pdaudiocf_core.c: make some code static

The patch below makes some needlessly global code static.

diffstat output:

 sound/pcmcia/pdaudiocf/pdaudiocf.h      |    2 --
 sound/pcmcia/pdaudiocf/pdaudiocf_core.c |    4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)
sound/pcmcia/pdaudiocf/pdaudiocf.h renamed from sound/pcmcia/pdaudiocf/pdaudiocf.h.old +0 -2
@@ -130,8 +130,6 @@
 	return inw(chip->port + reg);
 }
 
-unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg);
-void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val);
 pdacf_t *snd_pdacf_create(snd_card_t *card);
 int snd_pdacf_ak4117_create(pdacf_t *pdacf);
 void snd_pdacf_powerdown(pdacf_t *chip);
sound/pcmcia/pdaudiocf/pdaudiocf_core.c renamed from sound/pcmcia/pdaudiocf/pdaudiocf_core.c.old +2 -2
@@ -28,7 +28,7 @@
 /*
  *
  */
-unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg)
+static unsigned char pdacf_ak4117_read(void *private_data, unsigned char reg)
 {
 	pdacf_t *chip = private_data;
 	unsigned long timeout;
@@ -60,7 +60,7 @@
 	return res;
 }
 
-void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val)
+static void pdacf_ak4117_write(void *private_data, unsigned char reg, unsigned char val)
 {
 	pdacf_t *chip = private_data;
 	unsigned long timeout;
#1 lore raw

At Mon, 22 Nov 2004 00:58:53 +0100,

Quoted 11 lines · Adrian Bunk

The patch below makes some needlessly global code static.

diffstat output:

 sound/pcmcia/pdaudiocf/pdaudiocf.h      |    2 --
 sound/pcmcia/pdaudiocf/pdaudiocf_core.c |    4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

Thanks, I applied to ALSA CVS.

Takashi

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/