Skip to contentSkip to conversation

ASoC updates for 3.2

DISCUSSION Mark Brown 2 participants 5 messages Dec 22, 2011 2 messages not in the archive

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

The following changes since commit 497d496598f411cb7f0690725a0e8b9029cebdb9:

ASoC: Fix hx4700 error handling to free gpios if snd_soc_register_card fails (2011-12-12 12:58:42 +0800)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.2

An update for an API change that didn't get propagated properly.

Shawn Guo (1):
ASoC: mxs: correct 'direction' of device_prep_dma_cyclic

 sound/soc/mxs/mxs-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
#1 lore raw

At Thu, 22 Dec 2011 11:04:11 +0000,

Quoted 9 lines · Mark Brown

The following changes since commit 497d496598f411cb7f0690725a0e8b9029cebdb9:

ASoC: Fix hx4700 error handling to free gpios if snd_soc_register_card fails (2011-12-12 12:58:42 +0800)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.2

An update for an API change that didn't get propagated properly.

Pulled now. Thanks.

Takashi

Quoted 6 lines

Shawn Guo (1):
ASoC: mxs: correct 'direction' of device_prep_dma_cyclic

 sound/soc/mxs/mxs-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

A message that is not in the archive (sent off-list or not yet received): CAAQ0ZWSoQJJZv9ReBvHC1FB2EeS_u2V=jDJOguoqNx2cR+1i_g@mail.gmail.com

author
#3 lore raw
Quoted 7 lines · Shawn Guo

On 22 December 2011 19:04, Mark Brown

Quoted 2 lines

Shawn Guo (1):
     ASoC: mxs: correct 'direction' of device_prep_dma_cyclic

If I remember correctly, the API change only sits on -next. You may not want to push this patch for 3.2, I guess?

Oh, ffs. git describe shows the change as being based off 3.1 so it would be expected to appear in the 3.2 merge window but looking at Linus' tree it doesn't seem to be there. I'll revert the change.

If the API change is only in -next this shouldn't have been applied to the ASoC tree at all. This needs go along with the change that adds the new API otherwise you break bisection. Things like this *really* need to be made clear when posting patches. I'll revert the change, you should get anyone else who's applied these changes to do so as well.

#4 lore raw

At Thu, 22 Dec 2011 12:02:47 +0000,

Quoted 14 lines · Mark Brown
Quoted 7 lines · Shawn Guo

On 22 December 2011 19:04, Mark Brown

Quoted 2 lines

Shawn Guo (1):
     ASoC: mxs: correct 'direction' of device_prep_dma_cyclic

If I remember correctly, the API change only sits on -next. You may not want to push this patch for 3.2, I guess?

Oh, ffs. git describe shows the change as being based off 3.1 so it would be expected to appear in the 3.2 merge window but looking at Linus' tree it doesn't seem to be there. I'll revert the change.

Quoted 5 lines

If the API change is only in -next this shouldn't have been applied to the ASoC tree at all. This needs go along with the change that adds the new API otherwise you break bisection. Things like this *really* need to be made clear when posting patches. I'll revert the change, you should get anyone else who's applied these changes to do so as well.

OK, I took back these commits from sound git tree...

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

A message that is not in the archive (sent off-list or not yet received): CAAQ0ZWTnMuDCHDQQWg9mvQHTwzm6hJu5TOFvbwc18R5xEhSdiw@mail.gmail.com

author
#6 lore raw
Quoted 9 lines · Shawn Guo

On 22 December 2011 20:02, Mark Brown

Quoted 4 lines

If the API change is only in -next this shouldn't have been applied to the ASoC tree at all.  This needs go along with the change that adds the new API otherwise you break bisection.  Things like this *really* need to be made clear when posting patches.

I did mention that the patch series addresses the issue seen on -next tree in the cover letter. And I replied your query as below.

You shouldn't rely on cover letters getting noticed, they're too easy to disassociate from the patch.

Quoted 6 lines
Quoted 3 lines

With patches like this you really need to supply more context - knowing which release the commit you're talking about appears in is useful for exammple,

This patch only applies to -next, as the offending patch only sits on -next.

Yeah, that was after I'd applied the patch.

TBH given that this is an incompatible API change the original patch relly ought to be updating all users, there shouldn't be separate patches for the drivers.