Skip to contentSkip to conversation

ALSA: Add missing __devexit_p() markers

PATCH In review Jean Delvare 2 participants 2 messages Jun 4, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: Add missing __devexit_p() markers

3 ISA sound drivers lack their __devexit_p() markers, which would cause build failures when the kernel is built without hotplug support.

Cc Kyle McMartin <[email protected]>
Cc Takashi Iwai <[email protected]>
---
 sound/isa/es1688/es1688.c  |    2 +-
 sound/isa/gus/gusextreme.c |    2 +-
 sound/parisc/harmony.c     |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
sound/isa/es1688/es1688.c +1 -1
@@ -193,7 +193,7 @@ static int __devexit snd_es1688_remove(s
 static struct isa_driver snd_es1688_driver = {
 	.match		= snd_es1688_match,
 	.probe		= snd_es1688_probe,
-	.remove		= snd_es1688_remove,
+	.remove		= __devexit_p(snd_es1688_remove),
 #if 0	/* FIXME */
 	.suspend	= snd_es1688_suspend,
 	.resume		= snd_es1688_resume,
sound/isa/gus/gusextreme.c +1 -1
@@ -348,7 +348,7 @@ static int __devexit snd_gusextreme_remo
 static struct isa_driver snd_gusextreme_driver = {
 	.match		= snd_gusextreme_match,
 	.probe		= snd_gusextreme_probe,
-	.remove		= snd_gusextreme_remove,
+	.remove		= __devexit_p(snd_gusextreme_remove),
 #if 0	/* FIXME */
 	.suspend	= snd_gusextreme_suspend,
 	.resume		= snd_gusextreme_resume,
sound/parisc/harmony.c +1 -1
@@ -1020,7 +1020,7 @@ static struct parisc_driver snd_harmony_
 	.name = "harmony",
 	.id_table = snd_harmony_devtable,
 	.probe = snd_harmony_probe,
-	.remove = snd_harmony_remove,
+	.remove = __devexit_p(snd_harmony_remove),
 };
 
 static int __init 
Signature · 1 line
Jean Delvare
#1 lore raw

At Thu, 4 Jun 2009 10:46:43 +0200,

Quoted 7 lines · Jean Delvare

3 ISA sound drivers lack their __devexit_p() markers, which would cause build failures when the kernel is built without hotplug support.

Cc Kyle McMartin <[email protected]>
Cc Takashi Iwai <[email protected]>

Applied now. Thanks!

Takashi

Quoted 44 lines
---
 sound/isa/es1688/es1688.c  |    2 +-
 sound/isa/gus/gusextreme.c |    2 +-
 sound/parisc/harmony.c     |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
sound/isa/es1688/es1688.c +1 -1
@@ -193,7 +193,7 @@ static int __devexit snd_es1688_remove(s
 static struct isa_driver snd_es1688_driver = {
 	.match		= snd_es1688_match,
 	.probe		= snd_es1688_probe,
-	.remove		= snd_es1688_remove,
+	.remove		= __devexit_p(snd_es1688_remove),
 #if 0	/* FIXME */
 	.suspend	= snd_es1688_suspend,
 	.resume		= snd_es1688_resume,
sound/isa/gus/gusextreme.c +1 -1
@@ -348,7 +348,7 @@ static int __devexit snd_gusextreme_remo
 static struct isa_driver snd_gusextreme_driver = {
 	.match		= snd_gusextreme_match,
 	.probe		= snd_gusextreme_probe,
-	.remove		= snd_gusextreme_remove,
+	.remove		= __devexit_p(snd_gusextreme_remove),
 #if 0	/* FIXME */
 	.suspend	= snd_gusextreme_suspend,
 	.resume		= snd_gusextreme_resume,
sound/parisc/harmony.c +1 -1
@@ -1020,7 +1020,7 @@ static struct parisc_driver snd_harmony_
 	.name = "harmony",
 	.id_table = snd_harmony_devtable,
 	.probe = snd_harmony_probe,
-	.remove = snd_harmony_remove,
+	.remove = __devexit_p(snd_harmony_remove),
 };
 
 static int __init 
Signature · 2 lines
-- 
Jean Delvare