Skip to contentSkip to conversation

ALSA: hda - Bind new ecs mobo id (1019:2950) to model=ecs202

PATCH Applied Herton Ronaldo Krzesinski 2 participants 8 messages Feb 8, 2009 – Feb 10, 2009 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda - Bind new ecs mobo id (1019:2950) to model=ecs202

This adds a new sound quirk entry (model=ecs202) for an ecs motherboard with IDT STAC9221 codec (1019:2950).

---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +2 -0
index 85dc642..d16d5c6 100644
@@ -2108,6 +2108,8 @@ static struct snd_pci_quirk stac922x_cfg_tbl[] = {
 		      "ECS/PC chips", STAC_ECS_202),
 	SND_PCI_QUIRK(0x1019, 0x2820,
 		      "ECS/PC chips", STAC_ECS_202),
+	SND_PCI_QUIRK(0x1019, 0x2950,
+		      "ECS/PC chips", STAC_ECS_202),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.1.2
#2 lore raw

At Mon, 09 Feb 2009 08:32:58 +0100,

Quoted 10 lines · I wrote:

At Sun, 8 Feb 2009 19:50:34 -0200,

Quoted 5 lines · Herton Ronaldo Krzesinski

This adds a new sound quirk entry (model=ecs202) for an ecs motherboard with IDT STAC9221 codec (1019:2950).

Applied. Thanks.

BTW, I changed the quirk listing and introduced new macros SND_PCI_QUIRK_MASK() and SND_PCI_QUIRK_VENDOR().
The latter is what it was with subdevice = 0, and the former is an entry with bitmask to match. This should simplify the list in future.

The topic/hda branch already includes this change:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git topic/hda

Takashi

#3 lore raw

Em Segunda-feira 09 Fevereiro 2009, às 14:42:55, Takashi Iwai escreveu:

Quoted 19 lines

At Mon, 09 Feb 2009 08:32:58 +0100,

Quoted 9 lines · I wrote:

At Sun, 8 Feb 2009 19:50:34 -0200,

Quoted 4 lines · Herton Ronaldo Krzesinski

This adds a new sound quirk entry (model=ecs202) for an ecs motherboard with IDT STAC9221 codec (1019:2950).

Applied. Thanks.

BTW, I changed the quirk listing and introduced new macros SND_PCI_QUIRK_MASK() and SND_PCI_QUIRK_VENDOR().
The latter is what it was with subdevice = 0, and the former is an entry with bitmask to match. This should simplify the list in future.

Quoted 3 lines

The topic/hda branch already includes this change:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
topic/hda

This is nice. I saw now another cleanup that can be done, what about this? (default to STAC_HP_DV5 looks a good thing to be done):

[PATCH] ALSA: hda - Cleanup quirk list for HP dv laptops with stac92hd71bxx

Cleanup with SND_PCI_QUIRK_MASK entries for model=hp-dv5.

---
 sound/pci/hda/patch_sigmatel.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
sound/pci/hda/patch_sigmatel.c +5 -7
index ddb10bb..0f8a27f 100644
@@ -1812,16 +1812,14 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = {
 		      "HP dv5", STAC_HP_M4),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7,
-		      "HP dv4", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3600,
-		      "HP dv5", STAC_HP_DV5),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3603,
-		      "HP dv5", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x361a,
-				"unknown HP", STAC_HP_M4),
+		      "unknown HP", STAC_HP_M4),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3000,
+			   "HP dv laptop series", STAC_HP_DV5),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
+			   "HP dv laptop series", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233,
 				"unknown Dell", STAC_DELL_M4_1),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0234,
Signature · 1 line
1.6.1.3
Quoted 3 lines

Takashi

--
[]'s
Herton

#4 lore raw

At Mon, 9 Feb 2009 17:04:44 -0200,

Quoted 21 lines · Herton Ronaldo Krzesinski

Em Segunda-feira 09 Fevereiro 2009, às 14:42:55, Takashi Iwai escreveu:

Quoted 19 lines

At Mon, 09 Feb 2009 08:32:58 +0100,

Quoted 9 lines · I wrote:

At Sun, 8 Feb 2009 19:50:34 -0200,

Quoted 4 lines · Herton Ronaldo Krzesinski

This adds a new sound quirk entry (model=ecs202) for an ecs motherboard with IDT STAC9221 codec (1019:2950).

Applied. Thanks.

BTW, I changed the quirk listing and introduced new macros SND_PCI_QUIRK_MASK() and SND_PCI_QUIRK_VENDOR().
The latter is what it was with subdevice = 0, and the former is an entry with bitmask to match. This should simplify the list in future.

Quoted 6 lines
Quoted 3 lines

The topic/hda branch already includes this change:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
topic/hda

This is nice. I saw now another cleanup that can be done, what about this? (default to STAC_HP_DV5 looks a good thing to be done):

Yes, I originally thought of these HP series. But, 103c:361a is HP mini 1000, and this seems to be working better with hp-m4 model. So, we should be a bit careful about this change.

The alsa-info of that device is found in

	https://bugzilla.novell.com/show_bug.cgi?id=467381

thanks,

Takashi

Quoted 46 lines

[PATCH] ALSA: hda - Cleanup quirk list for HP dv laptops with stac92hd71bxx

Cleanup with SND_PCI_QUIRK_MASK entries for model=hp-dv5.

---
 sound/pci/hda/patch_sigmatel.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
sound/pci/hda/patch_sigmatel.c +5 -7
index ddb10bb..0f8a27f 100644
@@ -1812,16 +1812,14 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = {
 		      "HP dv5", STAC_HP_M4),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7,
-		      "HP dv4", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3600,
-		      "HP dv5", STAC_HP_DV5),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3603,
-		      "HP dv5", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x361a,
-				"unknown HP", STAC_HP_M4),
+		      "unknown HP", STAC_HP_M4),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3000,
+			   "HP dv laptop series", STAC_HP_DV5),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
+			   "HP dv laptop series", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233,
 				"unknown Dell", STAC_DELL_M4_1),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0234,
Signature · 1 line
1.6.1.3
Quoted 3 lines

Takashi

--
[]'s
Herton

#5 lore raw

Em Segunda-feira 09 Fevereiro 2009, às 17:27:55, Takashi Iwai escreveu:

Quoted 11 lines

At Mon, 9 Feb 2009 17:04:44 -0200,

Quoted 9 lines · Herton Ronaldo Krzesinski

Em Segunda-feira 09 Fevereiro 2009, às 14:42:55, Takashi Iwai escreveu:

Quoted 7 lines

At Mon, 09 Feb 2009 08:32:58 +0100,

Quoted 4 lines · I wrote:

At Sun, 8 Feb 2009 19:50:34 -0200,

Quoted 1 line · Herton Ronaldo Krzesinski

This adds a new sound quirk entry (model=ecs202) for an ecs

motherboard

Quoted 19 lines
Quoted 12 lines
Quoted 12 lines
Quoted 5 lines
Quoted 3 lines

with IDT STAC9221 codec (1019:2950).

Applied. Thanks.

BTW, I changed the quirk listing and introduced new macros SND_PCI_QUIRK_MASK() and SND_PCI_QUIRK_VENDOR().
The latter is what it was with subdevice = 0, and the former is an entry with bitmask to match. This should simplify the list in future.

Quoted 6 lines
Quoted 3 lines

The topic/hda branch already includes this change:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
topic/hda

This is nice. I saw now another cleanup that can be done, what about this? (default to STAC_HP_DV5 looks a good thing to be done):

Quoted 8 lines

Yes, I originally thought of these HP series. But, 103c:361a is HP mini 1000, and this seems to be working better with hp-m4 model. So, we should be a bit careful about this change.

The alsa-info of that device is found in

	https://bugzilla.novell.com/show_bug.cgi?id=467381

From my understanding the STAC_HP_DV5 only exists to enable gpio0 by default,

while STAC_HP_M4 will besides enabling it (passing the "if (spec->board_config

Quoted 1 line

STAC_92HD71BXX_REF)" check), will also do extra setup. I don't know if

enabling gpio0 with dir=1 by default will introduce some bug with some machine, but the idea is that all HP laptops with these codecs looks to need gpio0 enabled; even if some of them needs hp-m4 because of extra setup needed (besides gpio initialization), hp-dv5 would be safe for them as both enable gpio the same way. But I agree we should take care in case initializing gpio0 by default can introduce bugs with another unlisted hp laptops.

Quoted 7 lines

thanks,

Takashi

Quoted 1 line

[PATCH] ALSA: hda - Cleanup quirk list for HP dv laptops with

stac92hd71bxx

Quoted 9 lines

Review

Quoted 9 lines

Cleanup with SND_PCI_QUIRK_MASK entries for model=hp-dv5.

---
 sound/pci/hda/patch_sigmatel.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
(quoted diff) +0 -0

b/sound/pci/hda/patch_sigmatel.c

Quoted 4 lines

sound/pci/hda/patch_sigmatel.c static struct snd_pci_quirk

Quoted 4 lines

index ddb10bb..0f8a27f 100644

sound/pci/hda/patch_sigmatel.c +0 -0
@@ -1812,16 +1812,14 @@ static struct snd_pci_quirk 

stac92hd71bxx_cfg_tbl[] = {

Quoted 26 lines
Quoted 26 lines
sound/pci/hda/patch_sigmatel.c +5 -7
 		      "HP dv5", STAC_HP_M4),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7,
-		      "HP dv4", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3600,
-		      "HP dv5", STAC_HP_DV5),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3603,
-		      "HP dv5", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x361a,
-				"unknown HP", STAC_HP_M4),
+		      "unknown HP", STAC_HP_M4),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3000,
+			   "HP dv laptop series", STAC_HP_DV5),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
+			   "HP dv laptop series", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233,
 				"unknown Dell", STAC_DELL_M4_1),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0234,
Signature · 1 line
1.6.1.3
Quoted 2 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

Takashi

--
[]'s
Herton

#6 lore raw

At Tue, 10 Feb 2009 15:31:22 -0200,

Quoted 37 lines · Herton Ronaldo Krzesinski

Em Segunda-feira 09 Fevereiro 2009, às 17:27:55, Takashi Iwai escreveu:

Quoted 11 lines

At Mon, 9 Feb 2009 17:04:44 -0200,

Quoted 9 lines · Herton Ronaldo Krzesinski

Em Segunda-feira 09 Fevereiro 2009, às 14:42:55, Takashi Iwai escreveu:

Quoted 7 lines

At Mon, 09 Feb 2009 08:32:58 +0100,

Quoted 4 lines · I wrote:

At Sun, 8 Feb 2009 19:50:34 -0200,

Quoted 1 line · Herton Ronaldo Krzesinski

This adds a new sound quirk entry (model=ecs202) for an ecs

motherboard

Quoted 23 lines
Quoted 12 lines
Quoted 12 lines
Quoted 5 lines
Quoted 3 lines

with IDT STAC9221 codec (1019:2950).

Applied. Thanks.

BTW, I changed the quirk listing and introduced new macros SND_PCI_QUIRK_MASK() and SND_PCI_QUIRK_VENDOR().
The latter is what it was with subdevice = 0, and the former is an entry with bitmask to match. This should simplify the list in future.

Quoted 6 lines
Quoted 3 lines

The topic/hda branch already includes this change:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
topic/hda

This is nice. I saw now another cleanup that can be done, what about this? (default to STAC_HP_DV5 looks a good thing to be done):

Yes, I originally thought of these HP series. But, 103c:361a is HP mini 1000, and this seems to be working better with hp-m4 model. So, we should be a bit careful about this change.

Quoted 6 lines
Quoted 2 lines

The alsa-info of that device is found in

	https://bugzilla.novell.com/show_bug.cgi?id=467381

From my understanding the STAC_HP_DV5 only exists to enable gpio0 by default, while STAC_HP_M4 will besides enabling it (passing the "if (spec->board_config

Quoted 1 line

STAC_92HD71BXX_REF)" check), will also do extra setup.

Right. In addition, hp-m4 sets the pin 0x0e statically as the internal mic. This seems mismatching with some HP dv5, as far as I know.

Quoted 7 lines

I don't know if
enabling gpio0 with dir=1 by default will introduce some bug with some machine, but the idea is that all HP laptops with these codecs looks to need gpio0 enabled; even if some of them needs hp-m4 because of extra setup needed (besides gpio initialization), hp-dv5 would be safe for them as both enable gpio the same way. But I agree we should take care in case initializing gpio0 by default can introduce bugs with another unlisted hp laptops.

I guess the GPIO0 is OK for all HP laptops. But, the fixed 0x0e pin isn't.

Takashi

Quoted 56 lines
Quoted 8 lines

thanks,

Takashi

Quoted 1 line

[PATCH] ALSA: hda - Cleanup quirk list for HP dv laptops with

stac92hd71bxx

Quoted 9 lines

Review

Quoted 9 lines

Cleanup with SND_PCI_QUIRK_MASK entries for model=hp-dv5.

---
 sound/pci/hda/patch_sigmatel.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
(quoted diff) +0 -0

b/sound/pci/hda/patch_sigmatel.c

Quoted 4 lines

sound/pci/hda/patch_sigmatel.c static struct snd_pci_quirk

Quoted 4 lines

index ddb10bb..0f8a27f 100644

sound/pci/hda/patch_sigmatel.c +0 -0
@@ -1812,16 +1812,14 @@ static struct snd_pci_quirk 

stac92hd71bxx_cfg_tbl[] = {

Quoted 26 lines
Quoted 26 lines
sound/pci/hda/patch_sigmatel.c +5 -7
 		      "HP dv5", STAC_HP_M4),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7,
-		      "HP dv4", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3600,
-		      "HP dv5", STAC_HP_DV5),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3603,
-		      "HP dv5", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x361a,
-				"unknown HP", STAC_HP_M4),
+		      "unknown HP", STAC_HP_M4),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3000,
+			   "HP dv laptop series", STAC_HP_DV5),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
+			   "HP dv laptop series", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233,
 				"unknown Dell", STAC_DELL_M4_1),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0234,
Signature · 1 line
1.6.1.3
Quoted 2 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

Takashi

--
[]'s
Herton

#7 lore raw

Em Terça-feira 10 Fevereiro 2009, às 17:05:05, Takashi Iwai escreveu:

Quoted 8 lines

At Tue, 10 Feb 2009 15:31:22 -0200,

Quoted 5 lines · Herton Ronaldo Krzesinski

Em Segunda-feira 09 Fevereiro 2009, às 17:27:55, Takashi Iwai escreveu:

Quoted 4 lines

At Mon, 9 Feb 2009 17:04:44 -0200,

Quoted 1 line · Herton Ronaldo Krzesinski

Em Segunda-feira 09 Fevereiro 2009, às 14:42:55, Takashi Iwai

escreveu:

Quoted 56 lines
Quoted 34 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

At Mon, 09 Feb 2009 08:32:58 +0100,

Quoted 4 lines · I wrote:

At Sun, 8 Feb 2009 19:50:34 -0200,

Quoted 1 line · Herton Ronaldo Krzesinski

This adds a new sound quirk entry (model=ecs202) for an ecs

motherboard

Quoted 24 lines
Quoted 13 lines
Quoted 13 lines
Quoted 6 lines
Quoted 4 lines

with IDT STAC9221 codec (1019:2950).

Signed-off-by: Herton Ronaldo Krzesinski
<[email protected]>

Applied. Thanks.

BTW, I changed the quirk listing and introduced new macros SND_PCI_QUIRK_MASK() and SND_PCI_QUIRK_VENDOR().
The latter is what it was with subdevice = 0, and the former is an entry with bitmask to match. This should simplify the list in future.

Quoted 6 lines
Quoted 3 lines

The topic/hda branch already includes this change:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
topic/hda

This is nice. I saw now another cleanup that can be done, what about this? (default to STAC_HP_DV5 looks a good thing to be done):

Yes, I originally thought of these HP series. But, 103c:361a is HP mini 1000, and this seems to be working better with hp-m4 model. So, we should be a bit careful about this change.

Quoted 8 lines
Quoted 2 lines

The alsa-info of that device is found in

	https://bugzilla.novell.com/show_bug.cgi?id=467381

From my understanding the STAC_HP_DV5 only exists to enable gpio0 by default, while STAC_HP_M4 will besides enabling it (passing the "if (spec->board_config

Quoted 1 line

STAC_92HD71BXX_REF)" check), will also do extra setup.

Right. In addition, hp-m4 sets the pin 0x0e statically as the internal mic. This seems mismatching with some HP dv5, as far as I know.

Quoted 8 lines

I don't know if
enabling gpio0 with dir=1 by default will introduce some bug with some machine, but the idea is that all HP laptops with these codecs looks to need gpio0 enabled; even if some of them needs hp-m4 because of extra setup needed (besides gpio initialization), hp-dv5 would be safe for them as both enable gpio the same way. But I agree we should take care in case initializing gpio0 by default can introduce bugs with another unlisted hp laptops.

Quoted 2 lines

I guess the GPIO0 is OK for all HP laptops. But, the fixed 0x0e pin isn't.

Yes, but wouldn't be good then default to STAC_HP_DV5, and only later adding specific entries for STAC_HP_M4 above quirk_mask entries when needed (machines that need fixed 0x0e pin), like on the patch?

Quoted 55 lines

Takashi

Quoted 51 lines
Quoted 5 lines

thanks,

Takashi

Quoted 1 line

[PATCH] ALSA: hda - Cleanup quirk list for HP dv laptops with

stac92hd71bxx

Quoted 8 lines

Review

Quoted 8 lines

Cleanup with SND_PCI_QUIRK_MASK entries for model=hp-dv5.

---
 sound/pci/hda/patch_sigmatel.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
(quoted diff) +0 -0

b/sound/pci/hda/patch_sigmatel.c

Quoted 4 lines

sound/pci/hda/patch_sigmatel.c static struct snd_pci_quirk

Quoted 4 lines

index ddb10bb..0f8a27f 100644

sound/pci/hda/patch_sigmatel.c +0 -0
@@ -1812,16 +1812,14 @@ static struct snd_pci_quirk

stac92hd71bxx_cfg_tbl[] = {

Quoted 25 lines
Quoted 25 lines
sound/pci/hda/patch_sigmatel.c +5 -8
 		      "HP dv5", STAC_HP_M4),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7,
-		      "HP dv4", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
 		      "HP dv7", STAC_HP_M4),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3600,
-		      "HP dv5", STAC_HP_DV5),
-	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3603,
-		      "HP dv5", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x361a,
-				"unknown HP", STAC_HP_M4),
+		      "unknown HP", STAC_HP_M4),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3000,
+			   "HP dv laptop series", STAC_HP_DV5),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
+			   "HP dv laptop series", STAC_HP_DV5),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233,
 				"unknown Dell", STAC_DELL_M4_1),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0234,
--

1.6.1.3

Quoted 1 line

Takashi

--
[]'s
Herton