Skip to contentSkip to conversation

CVS: alsa-kernel/pci/ymfpci ymfpci.c,1.29,1.30

DISCUSSION Clemens Ladisch 2 participants 2 messages Oct 27, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · Takashi Iwai

Log Message:
added auto-detection of joystick port.
...

(quoted diff) +2 -0
+	if (joystick_port[dev] == 1) {
+		/* auto-detect */

Review

Quoted 10 lines
(quoted diff) +9 -0
+		long p;
+		for (p = 0x201; p <= 0x205; p++) {
+			if (p == 0x203) continue;
+			if ((joystick_res = request_region(p, 1, "YMFPCI gameport")) != NULL)
+				break;
+		}
+		if (joystick_res)
+			joystick_port[dev] = p;
+	} else {
...

This auto-detection code doesn't set legacy_ctrl2, so the card wouldn't actually use the port AFAICS.

Regards,
Clemens

-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/

#2 lore raw

At Mon, 27 Oct 2003 12:15:16 +0100 (MET),

Quoted 12 lines · Clemens Ladisch
Quoted 10 lines · Takashi Iwai

Log Message:
added auto-detection of joystick port.
...

(quoted diff) +7 -0
+	if (joystick_port[dev] == 1) {
+		/* auto-detect */
+		long p;
+		for (p = 0x201; p <= 0x205; p++) {
+			if (p == 0x203) continue;
+			if ((joystick_res = request_region(p, 1, "YMFPCI gameport")) != NULL)
+				break;
Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +4 -0
+		}
+		if (joystick_res)
+			joystick_port[dev] = p;
+	} else {
...

This auto-detection code doesn't set legacy_ctrl2, so the card wouldn't actually use the port AFAICS.

you're right. fixed now.

thanks,

Takashi

-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/