Skip to contentSkip to conversation

ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable

PATCH In review Tarek Soliman 2 participants 3 messages Apr 4, 2011 – Apr 6, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable

There are many USB MIDI cables out there that have buggy firmware that reports it can do more than 4 bytes in a packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/usb/midi.c +1 -0
index b4b39c0..f928910 100644
@@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 		ep->max_transfer = 4;
 		break;
 		/*
Signature · 6 lines
1.7.4.1

As instructed, I updated the insertion point of the new entry such
that the entries are sorted.
-- 
Tarek
#1 lore raw
Quoted 28 lines · Tarek Soliman

There are many USB MIDI cables out there that have buggy firmware that reports it can do more than 4 bytes in a packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/usb/midi.c +1 -0
index b4b39c0..f928910 100644
@@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 		ep->max_transfer = 4;
 		break;
 		/*
Signature · 4 lines
1.7.4.1

As instructed, I updated the insertion point of the new entry such
that the entries are sorted.

Hi,

Is there anything else required for this to be merged? I am very new to this.

Signature · 1 line
Tarek
#2 lore raw

At Tue, 5 Apr 2011 21:35:12 -0500,

Quoted 28 lines · Tarek Soliman
Quoted 26 lines · Tarek Soliman

There are many USB MIDI cables out there that have buggy firmware that reports it can do more than 4 bytes in a packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/usb/midi.c +1 -0
index b4b39c0..f928910 100644
@@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 		ep->max_transfer = 4;
 		break;
 		/*
Signature · 1 line
1.7.4.1
Quoted 7 lines
Quoted 2 lines

As instructed, I updated the insertion point of the new entry such that the entries are sorted.

Hi,

Is there anything else required for this to be merged? I am very new to this.

Your new patch is fine. I applied it now.
Thanks!

Takashi