Skip to contentSkip to conversation

A Weird issue on Gigabyte board

DISCUSSION Applied Jiang zhe 2 participants 4 messages Jan 17, 2008 – Jan 28, 2008

lore
Share & tools
lore

Jiang zhe

author
#0 lore raw

Hi,

I meet with a weird issue.
Please refer to the bug 0003674 on bugtrack.alsa-project.org.

It use alc889 codec but the codec vendor id is 0885.

With the alsa-driver-hg20080110.tar.bz2, it works well with option "model=6stack-dig".

But after I simply added the this line into the alc882_cfg_tbl[]:
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35-DS3R", ALC882_6ST_DIG),

The dmesg still show "hda_codec: Unknown model for ALC882, trying auto-probe from BIOS...". and driver will crash.

With this patch, even loading it with option "model=6stack-dig" doesn't help, driver will still crash.

I found a line in the dmesg:
"hda_intel: azx_get_response timeout, switching to polling mode: last cmd=0xbe0f0009."
The Cad is 0xb.

The codec_mask can change from 0x4 to 0x1:
alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x4 alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x1

The os is kubuntu,kernel version is 2.6.22-14.

Here is some dmesg info:

[ 36.934143]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x4
[ 36.935975] hda-codec: In the pacth_alc882,board_config is -1
[ 36.935976] hda_codec: Unknown model for ALC882, trying auto-probe from
BIOS...
[ 36.936469]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/hda_codec.c:2794:
autoconfig: line_outs=4 (0x14/0x15/0x16/0x17/0x0)
[ 36.936471]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/hda_codec.c:2798:
speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
[ 36.936473]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/hda_codec.c:2802:
hp_outs=1 (0x1b/0x0/0x0/0x0/0x0)
[ 36.936476]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/hda_codec.c:2810:
inputs: mic=0x18, fmic=0x19, line=0x1a, fline=0x0, cd=0x0, aux=0x0
[ 37.935491]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:581: hda_intel: azx_get_response timeout, switching to polling mode: last cmd=0xe1cf0009
[ 38.936857]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:588: hda_intel: azx_get_response timeout, switching to single_cmd mode: last cmd=0xe1cf0009
[ 38.936937]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:644: hda-intel: get_response timeout: IRS=0x1
[ 38.936940]
ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/hda_codec.c:2065:
BUG? (info->nid)
[ 38.936946] [<f8c19bc0>] snd_hda_build_pcms+0x1e0/0x220 [snd_hda_intel]
[ 38.936962] [<f8c1598c>] azx_probe+0x71c/0xa50 [snd_hda_intel]
[ 38.936974] [<f8c14850>] azx_send_cmd+0x0/0x130 [snd_hda_intel]
[ 38.936981] [<f8c14980>] azx_get_response+0x0/0x200 [snd_hda_intel]
[ 38.936991] [<f8c146c0>] azx_power_notify+0x0/0x70 [snd_hda_intel]
[ 38.937002] [<c0209a66>] pci_device_probe+0x56/0x80
[ 38.937008] [<c026110e>] driver_probe_device+0x8e/0x190
[ 38.937013] [<c026137e>] __driver_attach+0x9e/0xa0
[ 38.937017] [<c02604fb>] bus_for_each_dev+0x3b/0x60
[ 38.937022] [<c0260f86>] driver_attach+0x16/0x20
[ 38.937024] [<c02612e0>] __driver_attach+0x0/0xa0
[ 38.937026] [<c02608ca>] bus_add_driver+0x8a/0x1b0
[ 38.937031] [<c0209c13>] __pci_register_driver+0x53/0xa0
[ 38.937035] [<c014a7d1>] sys_init_module+0x151/0x1a00
[ 38.937038] [<c01fb39f>] prio_tree_insert+0x1f/0x250
[ 38.937052] [<c01041d2>] sysenter_past_esp+0x6b/0xa9
[ 38.937058] =======================
[ 38.937097] ACPI: PCI interrupt for device 0000:00:1b.0 disabled
[ 38.937102] HDA Intel: probe of 0000:00:1b.0 failed with error -22
[ 38.937124] ACPI: PCI Interrupt 0000:01:00.1[B] -> GSI 17 (level, low)
-> IRQ 23
[ 38.937134] PCI: Setting latency timer of device 0000:01:00.1 to 64
[ 38.952813]

ALSA /home/matt/Data/alsa-driver-hg20080110/pci/hda/../../alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x1

#1 lore raw

At Thu, 17 Jan 2008 16:44:07 +0800,

Quoted 17 lines · Jiang zhe

Hi,

I meet with a weird issue.
Please refer to the bug 0003674 on bugtrack.alsa-project.org.

It use alc889 codec but the codec vendor id is 0885.

With the alsa-driver-hg20080110.tar.bz2, it works well with option "model=6stack-dig".

But after I simply added the this line into the alc882_cfg_tbl[]:
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35-DS3R", ALC882_6ST_DIG),

The dmesg still show "hda_codec: Unknown model for ALC882, trying auto-probe from BIOS...". and driver will crash.

Quoted 7 lines

With this patch, even loading it with option "model=6stack-dig" doesn't help, driver will still crash.

I found a line in the dmesg:
"hda_intel: azx_get_response timeout, switching to polling mode: last cmd=0xbe0f0009."
The Cad is 0xb.

Very weird.

Quoted 3 lines

The codec_mask can change from 0x4 to 0x1:
alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x4 alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x1

This implies the hardware is somehow unstable.

Anyway, try the patch below. It cleans up a bit and avoids possible invalid commands, plus puts stack traces at a fatal communication error.

Takashi

pci/hda/hda_codec.c +3 -4
diff -r f94766e99413 pci/hda/hda_codec.c
@@ -2739,8 +2739,7 @@ int snd_hda_parse_pin_def_config(struct 
 				 struct auto_pin_cfg *cfg,
 				 hda_nid_t *ignore_nids)
 {
-	hda_nid_t nid, nid_start;
-	int nodes;
+	hda_nid_t nid, end_nid;
 	short seq, assoc_line_out, assoc_speaker;
 	short sequences_line_out[ARRAY_SIZE(cfg->line_out_pins)];
 	short sequences_speaker[ARRAY_SIZE(cfg->speaker_pins)];
@@ -2753,8 +2752,8 @@ int snd_hda_parse_pin_def_config(struct 
 	memset(sequences_hp, 0, sizeof(sequences_hp));
 	assoc_line_out = assoc_speaker = 0;
 
-	nodes = snd_hda_get_sub_nodes(codec, codec->afg, &nid_start);
-	for (nid = nid_start; nid < nodes + nid_start; nid++) {
+	end_nid = codec->start_nid + codec->num_nodes;
+	for (nid = codec->start_nid; nid < end_nid; nid++) {
 		unsigned int wid_caps = get_wcaps(codec, nid);
 		unsigned int wid_type =
 			(wid_caps & AC_WCAP_TYPE) >> AC_WCAP_TYPE_SHIFT;
pci/hda/hda_intel.c +2 -0
diff -r f94766e99413 pci/hda/hda_intel.c
@@ -587,6 +587,7 @@ static unsigned int azx_rirb_get_respons
 	snd_printk(KERN_ERR "hda_intel: azx_get_response timeout, "
 		   "switching to single_cmd mode: last cmd=0x%08x\n",
 		   chip->last_cmd);
+	dump_stack(); /* It's an error - show stack trace */
 	chip->rirb.rp = azx_readb(chip, RIRBWP);
 	chip->rirb.cmds = 0;
 	/* switch to single_cmd mode */
@@ -1738,6 +1739,7 @@ static int __devinit azx_create(struct s
 
 	err = pci_request_regions(pci, "ICH HD audio");
 	if (err < 0) {
+		printk(KERN_ERR SFX "Fail to request regions\n");
 		kfree(chip);
 		pci_disable_device(pci);
 		return err;
pci/hda/hda_local.h +1 -1
diff -r f94766e99413 pci/hda/hda_local.h
@@ -375,7 +375,7 @@ static inline u32 get_wcaps(struct hda_c
 {
 	if (nid < codec->start_nid ||
 	    nid >= codec->start_nid + codec->num_nodes)
-		return snd_hda_param_read(codec, nid, AC_PAR_AUDIO_WIDGET_CAP);
+		return 0;
 	return codec->wcaps[nid - codec->start_nid];
 }
author
#2 lore raw

Hi, Takashi:

The reporter rechecked.
The real reason is that he replaced the pci/hda instead of the alsa-kernel/pci/hda/patch_realtek.c.
After he corrected this, the patch worked well. Thank you very much!

Here is the patch for his machine:

--- alsa-driver-hg20080127/alsa-kernel/pci/hda/patch_realtek.c

2008-01-26 09:00:07.000000000 +0800

+++ b/alsa-kernel/pci/hda/patch_realtek.c 2008-01-28 13:44:06.000000000
+0800
@@ -5884,6 +5884,7 @@ static struct snd_pci_quirk alc882_cfg_t
SND_PCI_QUIRK(0x1043, 0x817f, "Asus P5LD2", ALC882_6ST_DIG), SND_PCI_QUIRK(0x1043, 0x81d8, "Asus P5WD", ALC882_6ST_DIG), SND_PCI_QUIRK(0x105b, 0x6668, "Foxconn", ALC882_6ST_DIG),
+ SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35 DS3R", ALC882_6ST_DIG),
SND_PCI_QUIRK(0x1462, 0x28fb, "Targa T8", ALC882_TARGA), /* MSI-1049
T8 */
SND_PCI_QUIRK(0x1462, 0x6668, "MSI", ALC882_6ST_DIG), SND_PCI_QUIRK(0x161f, 0x2054, "Arima W820", ALC882_ARIMA),

Quoted 98 lines · Takashi Iwai

At Thu, 17 Jan 2008 16:44:07 +0800,

Quoted 17 lines · Jiang zhe

Hi,

I meet with a weird issue.
Please refer to the bug 0003674 on bugtrack.alsa-project.org.

It use alc889 codec but the codec vendor id is 0885.

With the alsa-driver-hg20080110.tar.bz2, it works well with option "model=6stack-dig".

But after I simply added the this line into the alc882_cfg_tbl[]:
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35-DS3R", ALC882_6ST_DIG),

The dmesg still show "hda_codec: Unknown model for ALC882, trying auto-probe from BIOS...". and driver will crash.

Quoted 7 lines

With this patch, even loading it with option "model=6stack-dig" doesn't help, driver will still crash.

I found a line in the dmesg:
"hda_intel: azx_get_response timeout, switching to polling mode: last cmd=0xbe0f0009."
The Cad is 0xb.

Very weird.

Quoted 3 lines

The codec_mask can change from 0x4 to 0x1:
alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x4 alsa-kernel/pci/hda/hda_intel.c:732: codec_mask = 0x1

This implies the hardware is somehow unstable.

Anyway, try the patch below. It cleans up a bit and avoids possible invalid commands, plus puts stack traces at a fatal communication error.

Takashi

diff -r f94766e99413 pci/hda/hda_codec.c

pci/hda/hda_codec.c +3 -4
@@ -2739,8 +2739,7 @@ int snd_hda_parse_pin_def_config(struct 
 				 struct auto_pin_cfg *cfg,
 				 hda_nid_t *ignore_nids)
 {
-	hda_nid_t nid, nid_start;
-	int nodes;
+	hda_nid_t nid, end_nid;
 	short seq, assoc_line_out, assoc_speaker;
 	short sequences_line_out[ARRAY_SIZE(cfg->line_out_pins)];
 	short sequences_speaker[ARRAY_SIZE(cfg->speaker_pins)];
@@ -2753,8 +2752,8 @@ int snd_hda_parse_pin_def_config(struct 
 	memset(sequences_hp, 0, sizeof(sequences_hp));
 	assoc_line_out = assoc_speaker = 0;
 
-	nodes = snd_hda_get_sub_nodes(codec, codec->afg, &nid_start);
-	for (nid = nid_start; nid < nodes + nid_start; nid++) {
+	end_nid = codec->start_nid + codec->num_nodes;
+	for (nid = codec->start_nid; nid < end_nid; nid++) {
 		unsigned int wid_caps = get_wcaps(codec, nid);
 		unsigned int wid_type =
 			(wid_caps & AC_WCAP_TYPE) >> AC_WCAP_TYPE_SHIFT;

diff -r f94766e99413 pci/hda/hda_intel.c

pci/hda/hda_intel.c +2 -0
@@ -587,6 +587,7 @@ static unsigned int azx_rirb_get_respons
 	snd_printk(KERN_ERR "hda_intel: azx_get_response timeout, "
 		   "switching to single_cmd mode: last cmd=0x%08x\n",
 		   chip->last_cmd);
+	dump_stack(); /* It's an error - show stack trace */
 	chip->rirb.rp = azx_readb(chip, RIRBWP);
 	chip->rirb.cmds = 0;
 	/* switch to single_cmd mode */
@@ -1738,6 +1739,7 @@ static int __devinit azx_create(struct s
 
 	err = pci_request_regions(pci, "ICH HD audio");
 	if (err < 0) {
+		printk(KERN_ERR SFX "Fail to request regions\n");
 		kfree(chip);
 		pci_disable_device(pci);
 		return err;

diff -r f94766e99413 pci/hda/hda_local.h

pci/hda/hda_local.h +1 -1
@@ -375,7 +375,7 @@ static inline u32 get_wcaps(struct hda_c
 {
 	if (nid < codec->start_nid ||
 	    nid >= codec->start_nid + codec->num_nodes)
-		return snd_hda_param_read(codec, nid, AC_PAR_AUDIO_WIDGET_CAP);
+		return 0;
 	return codec->wcaps[nid - codec->start_nid];
 }
 
Applied
#3 lore raw

At Mon, 28 Jan 2008 13:52:26 +0800,

Quoted 9 lines · Jiang zhe

Hi, Takashi:

The reporter rechecked.
The real reason is that he replaced the pci/hda instead of the alsa-kernel/pci/hda/patch_realtek.c.
After he corrected this, the patch worked well. Thank you very much!

Quoted 3 lines

Here is the patch for his machine:

Applied to HG tree. Thanks.

Takashi