Skip to contentSkip to conversation

usbmidi (0.9.0rc7) output endpoints detection for MIDIStreaming protocol

PATCH In review Pedro Lopez-Cabanillas 2 participants 2 messages Feb 2, 2003 – Feb 3, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usbmidi (0.9.0rc7) output endpoints detection for MIDIStreaming protocol

Hi,

Attached is a patch to solve a little mistake with output endpoints detection for standard USB MIDI devices. Midisport devices are affected only if using Lars Doelle firmware.

Typical syslog output was like this:

kernel: snd-usb-midi: MIDIStreaming version 01.00
kernel: snd-usb-midi: EP 01: 2 jack(s)
kernel: snd-usb-midi: EP 81: 2 jack(s)
kernel: snd-usb-midi: created 0 output and 4 input ports
kernel: usb-uhci.c: ENXIO c0008480, flags 0, urb c1b665a0, burb c1b664a0
kernel: snd-usb-midi: usb_submit_urb: -6

Regards,
Pedro

Signature · 2 lines
ALSA Library Bindings for Pascal
http://alsapas.alturl.com
usb/usbmidi.c renamed from usb/usbmidi.c.old +1 -1
@@ -821,7 +821,7 @@
 		    ms_ep->bDescriptorType != USB_DT_CS_ENDPOINT ||
 		    ms_ep->bDescriptorSubtype != MS_GENERAL)
 			continue;
-		if ((ep->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK) == USB_DIR_OUT) {
+		if ((ep->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT) {
 			if (endpoints[epidx].out_ep) {
 				if (++epidx >= MIDI_MAX_ENDPOINTS) {
 					printk(KERN_WARNING "snd-usb-midi: too many endpoints\n");
#1 lore raw

At Mon, 3 Feb 2003 00:56:26 +0100,

Quoted 6 lines · Pedro Lopez-Cabanillas

Hi,

Attached is a patch to solve a little mistake with output endpoints detection for standard USB MIDI devices. Midisport devices are affected only if using Lars Doelle firmware.

thanks, now applied to cvs.

Takashi

-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com