Skip to contentSkip to conversation

ALSA seq: expose the card number of ALSA seq clients

PATCH Superseded Adam Goode 2 participants 5 messages Jun 5, 2015 – Jun 12, 2015 Sound

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Adam Goode

author
#0 lore raw

PATCH 1/1 ALSA seq: expose the card number of ALSA seq clients

Expose the card number of seq clients. This allows interested userspace programs to discover the hardware device that backs a particular seq client. Before this change, the only way to get information about the hardware for a client was by using brittle heuristics.

include/uapi/sound/asequencer.h +3 -2
index 5a5fa49..c2a659be 100644
@@ -25,7 +25,7 @@
 #include <sound/asound.h>
 
 /** version of the sequencer */
-#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 1)
+#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 2)
 
 /**
  * definition of sequencer event types
@@ -357,7 +357,8 @@ struct snd_seq_client_info {
 	unsigned char event_filter[32];	/* event filter bitmap */
 	int num_ports;			/* RO: number of ports */
 	int event_lost;			/* number of lost events */
-	char reserved[64];		/* for future use */
+	int card_number;		/* RO: card number, or -1 if no card. Added in protocol version 1.0.2 */
+	char reserved[60];		/* for future use */
 };
 
 
sound/core/seq/seq_clientmgr.c +12 -4
index edbdab8..fcae784 100644
@@ -216,7 +216,7 @@ int __init client_init_data(void)
 }
 
 
-static struct snd_seq_client *seq_create_client1(int client_index, int poolsize)
+static struct snd_seq_client *seq_create_client1(int client_index, int poolsize, int card_number)
 {
 	unsigned long flags;
 	int c;
@@ -232,6 +232,7 @@ static struct snd_seq_client *seq_create_client1(int client_index, int poolsize)
 		return NULL;
 	}
 	client->type = NO_CLIENT;
+	client->card_number = card_number;
 	snd_use_lock_init(&client->use_lock);
 	rwlock_init(&client->ports_lock);
 	mutex_init(&client->ports_mutex);
@@ -327,7 +328,7 @@ static int snd_seq_open(struct inode *inode, struct file *file)
 
 	if (mutex_lock_interruptible(&register_mutex))
 		return -ERESTARTSYS;
-	client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS);
+	client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS, -1);
 	if (client == NULL) {
 		mutex_unlock(&register_mutex);
 		return -ENOMEM;	/* failure code */
@@ -1194,6 +1195,7 @@ static void get_client_info(struct snd_seq_client *cptr,
 	info->event_lost = cptr->event_lost;
 	memcpy(info->event_filter, cptr->event_filter, 32);
 	info->num_ports = cptr->num_ports;
+	info->card_number = cptr->card_number;
 	memset(info->reserved, 0, sizeof(info->reserved));
 }
 
@@ -2239,6 +2241,7 @@ int snd_seq_create_kernel_client(struct snd_card *card, int client_index,
 {
 	struct snd_seq_client *client;
 	va_list args;
+	int card_number = -1;
 
 	if (snd_BUG_ON(in_interrupt()))
 		return -EBUSY;
@@ -2252,6 +2255,7 @@ int snd_seq_create_kernel_client(struct snd_card *card, int client_index,
 		return -ERESTARTSYS;
 
 	if (card) {
+		card_number = card->number;
 		client_index += SNDRV_SEQ_GLOBAL_CLIENTS
 			+ card->number * SNDRV_SEQ_CLIENTS_PER_CARD;
 		if (client_index >= SNDRV_SEQ_DYNAMIC_CLIENTS_BEGIN)
@@ -2259,7 +2263,7 @@ int snd_seq_create_kernel_client(struct snd_card *card, int client_index,
 	}
 
 	/* empty write queue as default */
-	client = seq_create_client1(client_index, 0);
+	client = seq_create_client1(client_index, 0, card_number);
 	if (client == NULL) {
 		mutex_unlock(&register_mutex);
 		return -EBUSY;	/* failure code */
@@ -2533,9 +2537,13 @@ void snd_seq_info_clients_read(struct snd_info_entry *entry,
 			continue;
 		}
 
-		snd_iprintf(buffer, "Client %3d : \"%s\" [%s]\n",
+		snd_iprintf(buffer, "Client %3d : \"%s\" [%s]",
 			    c, client->name,
 			    client->type == USER_CLIENT ? "User" : "Kernel");
+		if (client->card_number != -1) {
+			snd_iprintf(buffer, ", card %d", client->card_number);
+		}
+		snd_iprintf(buffer, "\n");
 		snd_seq_info_dump_ports(buffer, client);
 		if (snd_seq_write_pool_allocated(client)) {
 			snd_iprintf(buffer, "  Output pool :\n");
sound/core/seq/seq_clientmgr.h +1 -0
index 20f0a72..627be9d 100644
@@ -50,6 +50,7 @@ struct snd_seq_client {
 		accept_output: 1;
 	char name[64];		/* client name */
 	int number;		/* client number */
+	int card_number;	/* card number, or -1 if no card */
 	unsigned int filter;	/* filter flags */
 	DECLARE_BITMAP(event_filter, 256);
 	snd_use_lock_t use_lock;
Signature · 1 line
2.2.0.rc0.207.ga3a616c
#1 lore raw

At Thu, 4 Jun 2015 21:04:50 -0400,

Quoted 7 lines · Adam Goode

Expose the card number of seq clients. This allows interested userspace programs to discover the hardware device that backs a particular seq client. Before this change, the only way to get information about the hardware for a client was by using brittle heuristics.

The patch looks almost good. (One coding style fix about one-line if would be better, though.)

However, if we want to have more changes, I'd prefer the protocol version bump after all changes are merged.
Are you going to submit any further changes?

thanks,

Takashi

Quoted 117 lines
include/uapi/sound/asequencer.h +3 -2
index 5a5fa49..c2a659be 100644
@@ -25,7 +25,7 @@
 #include <sound/asound.h>
 
 /** version of the sequencer */
-#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 1)
+#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 2)
 
 /**
  * definition of sequencer event types
@@ -357,7 +357,8 @@ struct snd_seq_client_info {
 	unsigned char event_filter[32];	/* event filter bitmap */
 	int num_ports;			/* RO: number of ports */
 	int event_lost;			/* number of lost events */
-	char reserved[64];		/* for future use */
+	int card_number;		/* RO: card number, or -1 if no card. Added in protocol version 1.0.2 */
+	char reserved[60];		/* for future use */
 };
 
 
sound/core/seq/seq_clientmgr.c +12 -4
index edbdab8..fcae784 100644
@@ -216,7 +216,7 @@ int __init client_init_data(void)
 }
 
 
-static struct snd_seq_client *seq_create_client1(int client_index, int poolsize)
+static struct snd_seq_client *seq_create_client1(int client_index, int poolsize, int card_number)
 {
 	unsigned long flags;
 	int c;
@@ -232,6 +232,7 @@ static struct snd_seq_client *seq_create_client1(int client_index, int poolsize)
 		return NULL;
 	}
 	client->type = NO_CLIENT;
+	client->card_number = card_number;
 	snd_use_lock_init(&client->use_lock);
 	rwlock_init(&client->ports_lock);
 	mutex_init(&client->ports_mutex);
@@ -327,7 +328,7 @@ static int snd_seq_open(struct inode *inode, struct file *file)
 
 	if (mutex_lock_interruptible(&register_mutex))
 		return -ERESTARTSYS;
-	client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS);
+	client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS, -1);
 	if (client == NULL) {
 		mutex_unlock(&register_mutex);
 		return -ENOMEM;	/* failure code */
@@ -1194,6 +1195,7 @@ static void get_client_info(struct snd_seq_client *cptr,
 	info->event_lost = cptr->event_lost;
 	memcpy(info->event_filter, cptr->event_filter, 32);
 	info->num_ports = cptr->num_ports;
+	info->card_number = cptr->card_number;
 	memset(info->reserved, 0, sizeof(info->reserved));
 }
 
@@ -2239,6 +2241,7 @@ int snd_seq_create_kernel_client(struct snd_card *card, int client_index,
 {
 	struct snd_seq_client *client;
 	va_list args;
+	int card_number = -1;
 
 	if (snd_BUG_ON(in_interrupt()))
 		return -EBUSY;
@@ -2252,6 +2255,7 @@ int snd_seq_create_kernel_client(struct snd_card *card, int client_index,
 		return -ERESTARTSYS;
 
 	if (card) {
+		card_number = card->number;
 		client_index += SNDRV_SEQ_GLOBAL_CLIENTS
 			+ card->number * SNDRV_SEQ_CLIENTS_PER_CARD;
 		if (client_index >= SNDRV_SEQ_DYNAMIC_CLIENTS_BEGIN)
@@ -2259,7 +2263,7 @@ int snd_seq_create_kernel_client(struct snd_card *card, int client_index,
 	}
 
 	/* empty write queue as default */
-	client = seq_create_client1(client_index, 0);
+	client = seq_create_client1(client_index, 0, card_number);
 	if (client == NULL) {
 		mutex_unlock(&register_mutex);
 		return -EBUSY;	/* failure code */
@@ -2533,9 +2537,13 @@ void snd_seq_info_clients_read(struct snd_info_entry *entry,
 			continue;
 		}
 
-		snd_iprintf(buffer, "Client %3d : \"%s\" [%s]\n",
+		snd_iprintf(buffer, "Client %3d : \"%s\" [%s]",
 			    c, client->name,
 			    client->type == USER_CLIENT ? "User" : "Kernel");
+		if (client->card_number != -1) {
+			snd_iprintf(buffer, ", card %d", client->card_number);
+		}
+		snd_iprintf(buffer, "\n");
 		snd_seq_info_dump_ports(buffer, client);
 		if (snd_seq_write_pool_allocated(client)) {
 			snd_iprintf(buffer, "  Output pool :\n");
sound/core/seq/seq_clientmgr.h +1 -0
index 20f0a72..627be9d 100644
@@ -50,6 +50,7 @@ struct snd_seq_client {
 		accept_output: 1;
 	char name[64];		/* client name */
 	int number;		/* client number */
+	int card_number;	/* card number, or -1 if no card */
 	unsigned int filter;	/* filter flags */
 	DECLARE_BITMAP(event_filter, 256);
 	snd_use_lock_t use_lock;
Signature · 1 line
2.2.0.rc0.207.ga3a616c
author
#2 lore raw
Quoted 13 lines · Takashi Iwai

At Thu, 4 Jun 2015 21:04:50 -0400,

Quoted 7 lines · Adam Goode

Expose the card number of seq clients. This allows interested userspace programs to discover the hardware device that backs a particular seq client. Before this change, the only way to get information about the hardware for a client was by using brittle heuristics.

The patch looks almost good. (One coding style fix about one-line if would be better, though.)

Quoted 9 lines

However, if we want to have more changes, I'd prefer the protocol version bump after all changes are merged.
Are you going to submit any further changes?

thanks,

Takashi

Hi Takashi,

I fixed up the patch in v2. It fixes the style issue and delays updating protocol for now.

I think there might be another useful field to expose (the hardware midi device number), but I'm not sure yet. It is complicated since OPL3 does expose a client but does not use rawmidi. Otherwise, the rawmidi device number would be the obvious choice. I'm pretty sure I just need the card number to solve my problems in Chrome, but I will have to think about it.

The only other interesting change to make right now would be a tstamp field (something like PCM), but it might be too complex for a quick fix. I do like the PCM timestamp mode selection, and would like to see such a thing in seq.

Thanks,

Adam

Quoted 134 lines

Review

Quoted 3 lines
(quoted diff) +0 -0

b/include/uapi/sound/asequencer.h

Quoted 13 lines

index 5a5fa49..c2a659be 100644

include/uapi/sound/asequencer.h +1 -1
@@ -25,7 +25,7 @@
 #include <sound/asound.h>
 
 /** version of the sequencer */
-#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 1)
+#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 2)
 
 /**
  * definition of sequencer event types

include/uapi/sound/asequencer.h struct snd_seq_client_info { · line 360

Quoted 5 lines
include/uapi/sound/asequencer.h +1 -1
@@ -357,7 +357,8 @@ struct snd_seq_client_info {
      unsigned char event_filter[32]; /* event filter bitmap */
      int num_ports;                  /* RO: number of ports */
      int event_lost;                 /* number of lost events */
-     char reserved[64];              /* for future use */
+     int card_number;                /* RO: card number, or -1 if no

card. Added in protocol version 1.0.2 */

Review

Quoted 5 lines
include/uapi/sound/asequencer.h +1 -0
+     char reserved[60];              /* for future use */
 };
 
 
(quoted diff) +0 -0

b/sound/core/seq/seq_clientmgr.c

sound/core/seq/seq_clientmgr.c int __init client_init_data(void) · line 219

Quoted 8 lines

index edbdab8..fcae784 100644

sound/core/seq/seq_clientmgr.c +0 -1
@@ -216,7 +216,7 @@ int __init client_init_data(void)
 }
 
 
-static struct snd_seq_client *seq_create_client1(int client_index, int

poolsize)

sound/core/seq/seq_clientmgr.c int __init client_init_data(void) · line 219

Quoted 1 line
sound/core/seq/seq_clientmgr.c +1 -0
+static struct snd_seq_client *seq_create_client1(int client_index, int

poolsize, int card_number)

sound/core/seq/seq_clientmgr.c static struct snd_seq_client *seq_create_client1(int

Quoted 4 lines
sound/core/seq/seq_clientmgr.c +0 -0
 {
      unsigned long flags;
      int c;
@@ -232,6 +232,7 @@ static struct snd_seq_client *seq_create_client1(int

client_index, int poolsize)

sound/core/seq/seq_clientmgr.c static int snd_seq_open(struct inode *inode, struct

Quoted 8 lines
sound/core/seq/seq_clientmgr.c +1 -0
              return NULL;
      }
      client->type = NO_CLIENT;
+     client->card_number = card_number;
      snd_use_lock_init(&client->use_lock);
      rwlock_init(&client->ports_lock);
      mutex_init(&client->ports_mutex);
@@ -327,7 +328,7 @@ static int snd_seq_open(struct inode *inode, struct

file *file)

sound/core/seq/seq_clientmgr.c static void get_client_info(struct snd_seq_client

Quoted 9 lines
sound/core/seq/seq_clientmgr.c +1 -1
      if (mutex_lock_interruptible(&register_mutex))
              return -ERESTARTSYS;
-     client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS);
+     client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS, -1);
      if (client == NULL) {
              mutex_unlock(&register_mutex);
              return -ENOMEM; /* failure code */
@@ -1194,6 +1195,7 @@ static void get_client_info(struct snd_seq_client

*cptr,

sound/core/seq/seq_clientmgr.c int snd_seq_create_kernel_client(struct snd_card

Quoted 8 lines
sound/core/seq/seq_clientmgr.c +1 -0
      info->event_lost = cptr->event_lost;
      memcpy(info->event_filter, cptr->event_filter, 32);
      info->num_ports = cptr->num_ports;
+     info->card_number = cptr->card_number;
      memset(info->reserved, 0, sizeof(info->reserved));
 }
 
@@ -2239,6 +2241,7 @@ int snd_seq_create_kernel_client(struct snd_card

*card, int client_index,

sound/core/seq/seq_clientmgr.c int snd_seq_create_kernel_client(struct snd_card

Quoted 8 lines
sound/core/seq/seq_clientmgr.c +1 -0
 {
      struct snd_seq_client *client;
      va_list args;
+     int card_number = -1;
 
      if (snd_BUG_ON(in_interrupt()))
              return -EBUSY;
@@ -2252,6 +2255,7 @@ int snd_seq_create_kernel_client(struct snd_card

*card, int client_index,

sound/core/seq/seq_clientmgr.c int snd_seq_create_kernel_client(struct snd_card

Quoted 8 lines
sound/core/seq/seq_clientmgr.c +1 -0
              return -ERESTARTSYS;
 
      if (card) {
+             card_number = card->number;
              client_index += SNDRV_SEQ_GLOBAL_CLIENTS
                      + card->number * SNDRV_SEQ_CLIENTS_PER_CARD;
              if (client_index >= SNDRV_SEQ_DYNAMIC_CLIENTS_BEGIN)
@@ -2259,7 +2263,7 @@ int snd_seq_create_kernel_client(struct snd_card

*card, int client_index,

sound/core/seq/seq_clientmgr.c void snd_seq_info_clients_read(struct

Quoted 9 lines
sound/core/seq/seq_clientmgr.c +1 -1
      }
 
      /* empty write queue as default */
-     client = seq_create_client1(client_index, 0);
+     client = seq_create_client1(client_index, 0, card_number);
      if (client == NULL) {
              mutex_unlock(&register_mutex);
              return -EBUSY;  /* failure code */
@@ -2533,9 +2537,13 @@ void snd_seq_info_clients_read(struct

snd_info_entry *entry,

sound/core/seq/seq_clientmgr.c void snd_seq_info_clients_read(struct snd_info_entry *entry,

Quoted 7 lines
sound/core/seq/seq_clientmgr.c +1 -1
                      continue;
              }
 
-             snd_iprintf(buffer, "Client %3d : \"%s\" [%s]\n",
+             snd_iprintf(buffer, "Client %3d : \"%s\" [%s]",
                          c, client->name,
                          client->type == USER_CLIENT ? "User" :

"Kernel");

sound/core/seq/seq_clientmgr.c void snd_seq_info_clients_read(struct · line 2544

Quoted 2 lines
sound/core/seq/seq_clientmgr.c +2 -0
+             if (client->card_number != -1) {
+                     snd_iprintf(buffer, ", card %d",

client->card_number);

Review

Quoted 6 lines
sound/core/seq/seq_clientmgr.c +2 -0
+             }
+             snd_iprintf(buffer, "\n");
              snd_seq_info_dump_ports(buffer, client);
              if (snd_seq_write_pool_allocated(client)) {
                      snd_iprintf(buffer, "  Output pool :\n");
(quoted diff) +0 -0

b/sound/core/seq/seq_clientmgr.h

Quoted 14 lines

index 20f0a72..627be9d 100644

sound/core/seq/seq_clientmgr.h +1 -1
@@ -50,6 +50,7 @@ struct snd_seq_client {
              accept_output: 1;
      char name[64];          /* client name */
      int number;             /* client number */
+     int card_number;        /* card number, or -1 if no card */
      unsigned int filter;    /* filter flags */
      DECLARE_BITMAP(event_filter, 256);
      snd_use_lock_t use_lock;
--

2.2.0.rc0.207.ga3a616c

#3 lore raw

At Thu, 11 Jun 2015 23:43:53 -0400,

Quoted 28 lines · Adam Goode
Quoted 13 lines · Takashi Iwai

At Thu, 4 Jun 2015 21:04:50 -0400,

Quoted 7 lines · Adam Goode

Expose the card number of seq clients. This allows interested userspace programs to discover the hardware device that backs a particular seq client. Before this change, the only way to get information about the hardware for a client was by using brittle heuristics.

The patch looks almost good. (One coding style fix about one-line if would be better, though.)

Quoted 9 lines

However, if we want to have more changes, I'd prefer the protocol version bump after all changes are merged.
Are you going to submit any further changes?

thanks,

Takashi

Hi Takashi,

Quoted 8 lines

I fixed up the patch in v2. It fixes the style issue and delays updating protocol for now.

I think there might be another useful field to expose (the hardware midi device number), but I'm not sure yet. It is complicated since OPL3 does expose a client but does not use rawmidi. Otherwise, the rawmidi device number would be the obvious choice. I'm pretty sure I just need the card number to solve my problems in Chrome, but I will have to think about it.

IMO, we need to give the interface type (rawmidi, hwdep), too. Then the client can open the device and query more detailed information.

Quoted 4 lines

The only other interesting change to make right now would be a tstamp field (something like PCM), but it might be too complex for a quick fix. I do like the PCM timestamp mode selection, and would like to see such a thing in seq.

Yeah, this one would be more intrusive changes.

thanks,

Takashi

author
#4 lore raw
Quoted 34 lines · Takashi Iwai

At Thu, 11 Jun 2015 23:43:53 -0400,

Quoted 7 lines · Adam Goode
Quoted 4 lines · Takashi Iwai

At Thu, 4 Jun 2015 21:04:50 -0400,

Quoted 2 lines · Adam Goode

Expose the card number of seq clients. This allows interested

userspace

Quoted 24 lines
Quoted 9 lines
Quoted 5 lines

programs to discover the hardware device that backs a particular seq client. Before this change, the only way to get information about the hardware for a client was by using brittle heuristics.

The patch looks almost good. (One coding style fix about one-line if would be better, though.)

Quoted 9 lines

However, if we want to have more changes, I'd prefer the protocol version bump after all changes are merged.
Are you going to submit any further changes?

thanks,

Takashi

Hi Takashi,

I fixed up the patch in v2. It fixes the style issue and delays updating protocol for now.

Quoted 10 lines
Quoted 5 lines

I think there might be another useful field to expose (the hardware midi device number), but I'm not sure yet. It is complicated since OPL3 does expose a client but does not use rawmidi. Otherwise, the rawmidi device number would be the obvious choice. I'm pretty sure I just need the card number to solve my problems in Chrome, but I will have to think about it.

IMO, we need to give the interface type (rawmidi, hwdep), too. Then the client can open the device and query more detailed information.

Ah, that is a good idea. Let me prepare another patch with this extra information.

Quoted 9 lines
Quoted 1 line

The only other interesting change to make right now would be a tstamp

field

Quoted 3 lines

(something like PCM), but it might be too complex for a quick fix. I do like the PCM timestamp mode selection, and would like to see such a thing in seq.

Yeah, this one would be more intrusive changes.

Ok, I will defer this for now.

Quoted 5 lines

thanks,

Takashi

Thanks,

Adam