Skip to contentSkip to conversation

drm/i915: dp: increase probe retries

PATCH In review Takashi Iwai 2 participants 3 messages Aug 6, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: dp: increase probe retries

We've seen a problem that the DP port on a docking station is often not detected properly or misconfigured (no proper native modes) with a Haswell-based laptop. The trace showed that the driver gave up or got only insufficient EDID, maybe due to some unstable aux communication.

As a band-aid fix, increase the number of retries from 5 to 10. This seems enough for our cases.

---
 drivers/gpu/drm/i915/intel_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
index 26e162b..8491830 100644
@@ -548,7 +548,7 @@ intel_dp_i2c_aux_ch(struct i2c_adapter *adapter, int mode,
 		break;
 	}
 
-	for (retry = 0; retry < 5; retry++) {
+	for (retry = 0; retry < 10; retry++) {
 		ret = intel_dp_aux_ch(intel_dp,
 				      msg, msg_bytes,
 				      reply, reply_bytes);
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 7 lines · Takashi Iwai

We've seen a problem that the DP port on a docking station is often not detected properly or misconfigured (no proper native modes) with a Haswell-based laptop. The trace showed that the driver gave up or got only insufficient EDID, maybe due to some unstable aux communication.

As a band-aid fix, increase the number of retries from 5 to 10. This seems enough for our cases.

Did you test with

commit bc86625a4ff7574d4d4dba79723457711eb784e0

Author: Chris Wilson <[email protected]>
Date:   Sun Jul 21 16:00:03 2013 +0100

drm/i915: Retry DP aux_ch communications with a different clock after failures

That sounds like a relevant workaround.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw

At Tue, 6 Aug 2013 13:51:32 +0100,

Quoted 12 lines · Chris Wilson
Quoted 7 lines · Takashi Iwai

We've seen a problem that the DP port on a docking station is often not detected properly or misconfigured (no proper native modes) with a Haswell-based laptop. The trace showed that the driver gave up or got only insufficient EDID, maybe due to some unstable aux communication.

As a band-aid fix, increase the number of retries from 5 to 10. This seems enough for our cases.

Did you test with

Quoted 7 lines

commit bc86625a4ff7574d4d4dba79723457711eb784e0

Author: Chris Wilson <[email protected]>
Date:   Sun Jul 21 16:00:03 2013 +0100

drm/i915: Retry DP aux_ch communications with a different clock after failures

That sounds like a relevant workaround.

This seems also stabilizing the DP detection.
Will check more and give back if I still encounter a problem.

Thanks!

Takashi