HDA: Disable AMD SB600 64bit address support only
PATCH 1/1 HDA: Disable AMD SB600 64bit address support only
HDA driver disabled HD audio 64bit address support for all AMD SB600/SB700/SB800 platforms with commit 09240cf429505891d6123ce14a29f58f2a60121e due to one SB600 issue reported by community, but we do not see the similar issue on SB700/SB800 platforms. This patch is to refine the workaround for SB600 only.
sound/pci/hda/hda_intel.c +13 -3
@@ -2322,9 +2322,19 @@ gcap =azx_readw (chip,GCAP );snd_printdd (SFX "chipset global capabilities = 0x%x\n" , gcap); -/* ATI chips seems buggy about 64bit DMA addresses */ -if (chip->driver_type ==AZX_DRIVER_ATI ) - gcap &= ~ICH6_GCAP_64OK ; +/* disable SB600 64bit support for safety */ +if ((chip->driver_type ==AZX_DRIVER_ATI ) || + (chip->driver_type ==AZX_DRIVER_ATIHDMI )) { +struct pci_dev *p_smbus; + p_smbus =pci_get_device (PCI_VENDOR_ID_ATI , +PCI_DEVICE_ID_ATI_SBX00_SMBUS , +NULL ); +if (p_smbus) { +if (p_smbus->revision <0x30 ) + gcap &= ~ICH6_GCAP_64OK ; +pci_dev_put (p_smbus); + } + }/* allow 64bit DMA address if supported by H/W */ if ((gcap &ICH6_GCAP_64OK ) && !pci_set_dma_mask (pci,DMA_BIT_MASK (64 )))
At Wed, 8 Jul 2009 13:55:31 +0800,
Quoted 7 lines · Andiry Brienza
HDA driver disabled HD audio 64bit address support for all AMD SB600/SB700/SB800 platforms with commit
09240cf429505891d6123ce14a29f58f2a60121edue to one SB600 issue reported by community, but we do not see the similar issue on SB700/SB800 platforms. This patch is to refine the workaround for SB600 only.Signed-off-by Andiry Xu <[email protected]>
Applied now. Thanks.
Takashi
Quoted 28 lines
diff -ruN
a/sound/pci/hda/hda_intel.cb/sound/pci/hda/hda_intel.csound/pci/hda/hda_intel.c +13
-3@@ -2322,9 +2322,19 @@ gcap =azx_readw (chip,GCAP );snd_printdd (SFX "chipset global capabilities = 0x%x\n" , gcap); -/* ATI chips seems buggy about 64bit DMA addresses */ -if (chip->driver_type ==AZX_DRIVER_ATI ) - gcap &= ~ICH6_GCAP_64OK ; +/* disable SB600 64bit support for safety */ +if ((chip->driver_type ==AZX_DRIVER_ATI ) || + (chip->driver_type ==AZX_DRIVER_ATIHDMI )) { +struct pci_dev *p_smbus; + p_smbus =pci_get_device (PCI_VENDOR_ID_ATI , +PCI_DEVICE_ID_ATI_SBX00_SMBUS , +NULL ); +if (p_smbus) { +if (p_smbus->revision <0x30 ) + gcap &= ~ICH6_GCAP_64OK ; +pci_dev_put (p_smbus); + } + }/* allow 64bit DMA address if supported by H/W */ if ((gcap &ICH6_GCAP_64OK ) && !pci_set_dma_mask (pci,DMA_BIT_MASK (64 )))