Skip to contentSkip to conversation

let SND_SUPPORT_OLD_API depend on SND_PCM

PATCH In review Adrian Bunk 2 participants 4 messages Jan 10, 2006 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 let SND_SUPPORT_OLD_API depend on SND_PCM

SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.

sound/core/Kconfig renamed from sound/core/Kconfig.old +1 -1
@@ -124,7 +124,7 @@
 
 config SND_SUPPORT_OLD_API
 	bool "Support old ALSA API"
-	depends on SND
+	depends on SND_PCM
 	default y
 	help
 	  Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3
#1 lore raw

At Tue, 10 Jan 2006 17:44:49 +0100,

Quoted 9 lines · Adrian Bunk

SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.

sound/core/Kconfig line 130

Quoted 8 lines
sound/core/Kconfig renamed from sound/core/Kconfig.old +1 -1
@@ -124,7 +124,7 @@
 
 config SND_SUPPORT_OLD_API
 	bool "Support old ALSA API"
-	depends on SND
+	depends on SND_PCM
 	default y
 	help
 	  Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3

Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will be N until any drivers are selected.

Takashi

#2 lore raw
Quoted 12 lines · Takashi Iwai

At Tue, 10 Jan 2006 17:44:49 +0100,

Quoted 10 lines · Adrian Bunk

SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.

sound/core/Kconfig renamed from sound/core/Kconfig.old +0 -0
@@ -124,7 +124,7 @@
 
Quoted 10 lines

sound/core/Kconfig line 130

Quoted 7 lines
sound/core/Kconfig renamed from sound/core/Kconfig.old +1 -1
 config SND_SUPPORT_OLD_API
 	bool "Support old ALSA API"
-	depends on SND
+	depends on SND_PCM
 	default y
 	help
 	  Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3

Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will be N until any drivers are selected.

It does work and "make oldconfig" handles it perfectly, but I understand your point that it might be accidentially set to N if a user later selects a driver in "make {menu,x}oldconfig", and that this case is most likely better handled without my patch.

Quoted 1 line

Takashi

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw

At Tue, 10 Jan 2006 18:08:36 +0100,

Quoted 25 lines · Adrian Bunk
Quoted 12 lines · Takashi Iwai

At Tue, 10 Jan 2006 17:44:49 +0100,

Quoted 10 lines · Adrian Bunk

SND_SUPPORT_OLD_API only has an effect if SND_PCM is set.

sound/core/Kconfig renamed from sound/core/Kconfig.old +0 -0
@@ -124,7 +124,7 @@
 
Quoted 10 lines

sound/core/Kconfig line 130

Quoted 7 lines
sound/core/Kconfig renamed from sound/core/Kconfig.old +1 -1
 config SND_SUPPORT_OLD_API
 	bool "Support old ALSA API"
-	depends on SND
+	depends on SND_PCM
 	default y
 	help
 	  Say Y here to support the obsolete ALSA PCM API (ver.0.9.0 rc3

Does it work? CONFIG_SND_PCM is selected by the drivers. So, it will be N until any drivers are selected.

Quoted 4 lines

It does work and "make oldconfig" handles it perfectly, but I understand your point that it might be accidentially set to N if a user later selects a driver in "make {menu,x}oldconfig", and that this case is most likely better handled without my patch.

Yes, exactly. IMO, it's safer to avoid this dependency check.

Takashi