Skip to contentSkip to conversation

Add quirk to provide proper naming of the Terratec Aureon 5.1 MkII USB card

PATCH In review Andrea Borgia 2 participants 9 messages May 31, 2009 – Jun 3, 2009 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add quirk to provide proper naming of the Terratec Aureon 5.1 MkII USB card

sound/usb/usbquirks.h +8 -0
index 5d955aa..d84d6f3 100644
@@ -1951,6 +1951,14 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 	}
 },
 {
+	USB_DEVICE_VENDOR_SPEC(0x0ccd, 0x0028),
+	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+		.vendor_name = "TerraTec",
+		.product_name = "Aureon 5.1 MkII",
+		.ifnum = QUIRK_NO_INTERFACE
+	}
+},
+{
 	USB_DEVICE(0x0ccd, 0x0035),
 	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
 		.vendor_name = "Miditech",
Signature · 1 line
1.6.0.4

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Sun, 31 May 2009 23:06:07 +0200,

Quoted 6 lines · Andrea Borgia

[1 <text/plain; ISO-8859-15 (7bit)>]

[2 0001-Add-quirk-to-provide-proper-naming-of-the-Terratec-A.patch <text/x-diff (7bit)>]

Applied now. Thanks!

(BTW, it'd be helpful if you write a proper subject line and a changelog
in the patch itself at the next time so that I can apply it directly with git-am.)

Takashi

#2 lore raw

Takashi Iwai ha scritto:

Quoted 2 lines
Quoted 1 line

Applied now. Thanks!

I fear I might have made a mistake somewhere: after patching, rebuilding and reloading the module the device is still showing up with the generic "Audio" name in /proc/asound/cards

Quoted 1 line

From the looks of it, would you agree my latest patch works like my

earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?

Andrea.

#3 lore raw

At Tue, 02 Jun 2009 20:39:13 +0200,

Quoted 6 lines · Andrea Borgia

Takashi Iwai ha scritto:

Quoted 2 lines
Quoted 1 line

Applied now. Thanks!

Quoted 7 lines

I fear I might have made a mistake somewhere: after patching, rebuilding and reloading the module the device is still showing up with the generic "Audio" name in /proc/asound/cards

From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?

Hm, doesn't it work properly even after your correction patch?

Takashi

#4 lore raw

Takashi Iwai ha scritto:

Quoted 4 lines
Quoted 3 lines

From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?

Hm, doesn't it work properly even after your correction patch?

It does, sort of... but at least I found out that the patched module wasn't being rebuilt and that was causing the glitch.

Now I get a funny name: "MkII". The full name is ok, but the shorter name in "cards" is not.

What do you suggest in such cases? Remove all spaces, change them to underscores or what else?

A.

#5 lore raw

At Wed, 03 Jun 2009 15:40:10 +0200,

Quoted 8 lines · Andrea Borgia

Takashi Iwai ha scritto:

Quoted 4 lines
Quoted 3 lines

From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?

Hm, doesn't it work properly even after your correction patch?

Quoted 8 lines

It does, sort of... but at least I found out that the patched module wasn't being rebuilt and that was causing the glitch.

Now I get a funny name: "MkII". The full name is ok, but the shorter name in "cards" is not.

What do you suggest in such cases? Remove all spaces, change them to underscores or what else?

Show the whole name strings. I don't know whether it's funny or not unless I see them :)

Takashi

#6 lore raw

Takashi Iwai ha scritto:

Quoted 2 lines

Show the whole name strings. I don't know whether it's funny or not unless I see them :)

-x-x-x-
0 [SIS966 ]: HDA-Intel - HDA SIS966
HDA SIS966 at 0xd4200000 irq 18
1 [MkII ]: USB-Audio - Aureon 5.1 MkII
TerraTec Aureon 5.1 MkII at usb-0000:00:03.0-2, full speed -x-x-x-

You see, MkII could be a lot of things, like Colossus or anything ;-)

A.

#7 lore raw

At Wed, 03 Jun 2009 17:59:34 +0200,

Quoted 6 lines · Andrea Borgia

Takashi Iwai ha scritto:

Quoted 2 lines

Show the whole name strings. I don't know whether it's funny or not unless I see them :)

Quoted 8 lines

-x-x-x-
0 [SIS966 ]: HDA-Intel - HDA SIS966
HDA SIS966 at 0xd4200000 irq 18
1 [MkII ]: USB-Audio - Aureon 5.1 MkII
TerraTec Aureon 5.1 MkII at usb-0000:00:03.0-2, full speed -x-x-x-

You see, MkII could be a lot of things, like Colossus or anything ;-)

Well, it's just an id string. The only requirement is to be unique on the running system.

If this name is unacceptable (e.g. it's the name of my ex, it's a patent infringement, or whatever reason), concatenate Aureon 5.1 and MkII to a single word, then you'll get a different one.

Or, you could implement more codes to give a better id string with the API function recently added...

thanks,

Takashi

#8 lore raw

Takashi Iwai ha scritto:

Quoted 2 lines

Well, it's just an id string. The only requirement is to be unique on the running system.

Although highly unlikely in this specific case, how about multiple identical cards on the same host? Does it still hold true?

Quoted 5 lines

If this name is unacceptable (e.g. it's the name of my ex, it's a patent infringement, or whatever reason), concatenate Aureon 5.1 and MkII to a single word, then you'll get a different one. Or, you could implement more codes to give a better id string with the API function recently added...

Where should I look for this super snazzy function? I'm curious, I already know how to add a quirk, let's learn something new :-)

Andrea.