Fixes recording gain control
PATCH 1/1 Fixes recording gain control
Sorry for resending it again and again. This is since submitting a patch first time. Please never mind.
Consider the below thing.
Have tested two usb audio mic devices.
At the time of initialization, SNDRV_MIXER_OSS_PRESENT_PVOLUME bit is not set for MIC (slot 7).
So, the same should not be checked when an application tries to do gain control
for audio recording devices. Just checkslot->present for SNDRV_MIXER_OSS_PRESENT_CVOLUME independently. Verified with a simple application which opens /dev/dsp for recording and /dev/mixer for volume control.
---sound/core/oss/mixer_oss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
core/oss/mixer_oss.c 2009-03-10 18:37:07.000000000 +0530 renamed from core/oss/mixer_oss.org.c 2009-03-10 18:37:49.000000000 +0530 +0 -0
@@ -692,6 +692,8 @@ static int snd_mixer_oss_put_volume1(str snd_mixer_oss_put_volume1_vol(fmixer, pslot,
slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
snd_mixer_oss_put_volume1_vol(fmixer, pslot,
slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
+ } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
+ snd_mixer_oss_put_volume1_vol(fmixer, pslot,
slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
} else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
snd_mixer_oss_put_volume1_vol(fmixer, pslot,
slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);
} else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GLOBAL) {Signature · 15 lines
_____________________________________________________________________ Disclaimer: This e-mail message and all attachments transmitted with it are intended solely for the use of the addressee and may contain legally privileged and confidential information. If the reader of this message is not the intended recipient, or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution, copying, or other use of this message or its attachments is strictly prohibited. If you have received this message in error, please notify the sender immediately by replying to this message and please delete it from your computer. Any views expressed in this message are those of the individual sender unless otherwise stated.Company has taken enough precautions to prevent the spread of viruses. However the company accepts no liability for any damage caused by any virus transmitted by this email. __________________________________________________________________________
At Tue, 10 Mar 2009 18:40:49 +0530,
Quoted 4 lines · Viral Mehta
Sorry for resending it again and again. This is since submitting a patch first time. Please never mind.
Consider the below thing.
Thanks. Applied with a slight modification about coding style now.
BTW, the patch embedded in your post was still broken due to your MUA. Please fix it (or use attachment if difficult) at the next time.
Also, it'd be helpful if you run once checkpatch.pl before submission.
Takashi