2.6.10-mm1

PATCH New [email protected] 4 participants 5 messages Jan 3, 2005 – Jan 4, 2005

Subsystems (2)

Memory technology devices (MTD) NAND flash

lore

Share & tools

lore

[email protected]

author

2005-01-03 23:09 UTC #0 lore raw

I was looking to compare RT latency between this kernel and the latest from Ingo and I had the following warnings / errors building 2.6.10-mm1:

[no apparent compile / link errors]
*** Warning: "snd_ac97_restore_iec958" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
*** Warning: "snd_ac97_restore_status" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
*** Warning: "del_mtd_partitions" [drivers/mtd/maps/scx200_docflash.ko] undefined!
*** Warning: "add_mtd_partitions" [drivers/mtd/maps/scx200_docflash.ko] undefined!
...
if [ -r System.map ]; then /sbin/depmod -ae -F System.map -b /var/tmp/kernel-2.6.10mm1-root -r 2.6.10-mm1; fi
WARNING: /var/tmp/kernel-2.6.10 mm1-root/lib/modules/2.6.10-mm1/kernel/sound/pci/ac97/snd-ac97-codec.ko needs unknown sy
mbol snd_ac97_restore_status
WARNING: /var/tmp/kernel-2.6.10 mm1-root/lib/modules/2.6.10-mm1/kernel/sound/pci/ac97/snd-ac97-codec.ko needs unknown sy
mbol snd_ac97_restore_iec958
WARNING: /var/tmp/kernel-2.6.10 mm1-root/lib/modules/2.6.10-mm1/kernel/drivers/mtd/maps/scx200_docflash.ko needs unknown
symbol del_mtd_partitions
WARNING: /var/tmp/kernel-2.6.10 mm1-root/lib/modules/2.6.10-mm1/kernel/drivers/mtd/maps/scx200_docflash.ko needs unknown
symbol add_mtd_partitions
...

The following messages after rebooting...

...

Jan  3 16:42:00 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_status
Jan  3 16:42:00 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_iec958
Jan  3 16:42:00 dws77 modprobe: WARNING: Error inserting snd_ac97_codec
(/lib/modules/2.6.10-mm1/kernel/sound/pci/ac97/
snd-ac97-codec.ko): Unknown symbol in module, or unknown parameter (see
dmesg)
Jan  3 16:42:01 dws77 modprobe: FATAL: Error inserting snd_ens1371
(/lib/modules/2.6.10-mm1/kernel/sound/pci/snd-ens137
1.ko): Unknown symbol in module, or unknown parameter (see dmesg)
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_mixer
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_bus
Jan  3 16:42:01 dws77 modprobe: WARNING: Error inserting snd_ac97_codec
(/lib/modules/2.6.10-mm1/kernel/sound/pci/ac97/
snd-ac97-codec.ko): Unknown symbol in module, or unknown parameter (see
dmesg)
Jan  3 16:42:01 dws77 modprobe: FATAL: Error inserting snd_ens1371
(/lib/modules/2.6.10-mm1/kernel/sound/pci/snd-ens137
1.ko): Unknown symbol in module, or unknown parameter (see dmesg)
Jan  3 16:42:01 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_status
Jan  3 16:42:01 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_iec958
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_mixer
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_bus
Jan  3 16:42:01 dws77 modprobe: WARNING: Error inserting snd_ac97_codec
(/lib/modules/2.6.10-mm1/kernel/sound/pci/ac97/
snd-ac97-codec.ko): Unknown symbol in module, or unknown parameter (see
dmesg)
Jan  3 16:42:01 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_status
Jan  3 16:42:01 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_iec958
Jan  3 16:42:01 dws77 modprobe: FATAL: Error inserting snd_ens1371
(/lib/modules/2.6.10-mm1/kernel/sound/pci/snd-ens137
1.ko): Unknown symbol in module, or unknown parameter (see dmesg)
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_mixer
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_bus
Jan  3 16:42:01 dws77 modprobe: WARNING: Error inserting snd_ac97_codec
(/lib/modules/2.6.10-mm1/kernel/sound/pci/ac97/
snd-ac97-codec.ko): Unknown symbol in module, or unknown parameter (see
dmesg)
Jan  3 16:42:01 dws77 modprobe: FATAL: Error inserting snd_ens1371
(/lib/modules/2.6.10-mm1/kernel/sound/pci/snd-ens137
1.ko): Unknown symbol in module, or unknown parameter (see dmesg)
Jan  3 16:42:01 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_status
Jan  3 16:42:01 dws77 kernel: snd_ac97_codec: Unknown symbol
snd_ac97_restore_iec958
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_mixer
Jan  3 16:42:01 dws77 kernel: snd_ens1371: Unknown symbol snd_ac97_bus

...

and in dmesg, the following repeated a few times:
snd_ac97_codec: Unknown symbol snd_ac97_restore_status
snd_ac97_codec: Unknown symbol snd_ac97_restore_iec958
snd_ens1371: Unknown symbol snd_ac97_mixer
snd_ens1371: Unknown symbol snd_ac97_bus

At this point, the system fails to work with my sound card. The .config is basically the same as used previously with 2.6.10-rc3-mm1-V0.7.33-04 (Ingo's realtime patches) without problems. [though I expected & saw plenty of unused symbols when I did make mrproper / xconfig for 2.6.10-mm1]

To fix this, should I just add the EXPORT_SYMBOL lines for these symbols
snd_ac97_restore_status snd_ac97_restore_iec958
or is something more needed?

Thanks.
--Mark Johnson <mailto:[email protected]>

Andrew Morton

2005-01-03 23:16 UTC #1 lore raw

Quoted 4 lines · [email protected] wrote:

To fix this, should I just add the EXPORT_SYMBOL lines for these symbols
snd_ac97_restore_status snd_ac97_restore_iec958
or is something more needed?

Probably. If that fixes it, please send the patch.

Adrian Bunk

2005-01-04 00:11 UTC #2 lore raw

2.6.10-mm1: ALSA ac97 compile error with CONFIG_PM=n

In reply to [email protected]

Quoted 12 lines · On Mon, Jan 03, 2005 at 05:07:08PM -0600, [email protected] wrote:

I was looking to compare RT latency between this kernel and the latest from Ingo and I had the following warnings / errors building 2.6.10-mm1:
[no apparent compile / link errors]
*** Warning: "snd_ac97_restore_iec958" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
*** Warning: "snd_ac97_restore_status" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
...
To fix this, should I just add the EXPORT_SYMBOL lines for these symbols
snd_ac97_restore_status snd_ac97_restore_iec958
or is something more needed?

That's not the problem, since function and definition are in the same module.

You didn't send your .config, but looking at the code it seems CONFIG_PM=n was the culprit.

As a workaround, it should work after enabling the following option:
Power management options (ACPI, APM)
Power Management support

This is only a workaround, I've Cc'ed the ALSA maintainers for a real fix.

Quoted 2 lines

Thanks.
--Mark Johnson <mailto:[email protected]>

cu
Adrian

Signature · 11 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Takashi Iwai

2005-01-04 19:16 UTC #3 lore raw

Re: 2.6.10-mm1: ALSA ac97 compile error with CONFIG_PM=n

At Tue, 4 Jan 2005 01:11:30 +0100,

Quoted 15 lines · Adrian Bunk

Quoted 12 lines · On Mon, Jan 03, 2005 at 05:07:08PM -0600, [email protected] wrote:
I was looking to compare RT latency between this kernel and the latest from Ingo and I had the following warnings / errors building 2.6.10-mm1:
[no apparent compile / link errors]
*** Warning: "snd_ac97_restore_iec958" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
*** Warning: "snd_ac97_restore_status" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
...
To fix this, should I just add the EXPORT_SYMBOL lines for these symbols
snd_ac97_restore_status snd_ac97_restore_iec958
or is something more needed?

Quoted 5 lines

That's not the problem, since function and definition are in the same module.
You didn't send your .config, but looking at the code it seems CONFIG_PM=n was the culprit.

Yes, it's because of lack of #ifdef CONFIG_PM in ac97_patch.c. It was already fixed in the linux-sound bk tree.

Takashi

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Adrian Bunk

2005-01-04 00:17 UTC #4 lore raw

PATCH 1/1 add missing dependencies on MTD_PARTITIONS (fwd)

In reply to [email protected]

Quoted 10 lines · On Mon, Jan 03, 2005 at 05:07:08PM -0600, [email protected] wrote:

I was looking to compare RT latency between this kernel and the latest from Ingo and I had the following warnings / errors building 2.6.10-mm1:
[no apparent compile / link errors]
...
*** Warning: "del_mtd_partitions" [drivers/mtd/maps/scx200_docflash.ko] undefined!
*** Warning: "add_mtd_partitions" [drivers/mtd/maps/scx200_docflash.ko] undefined!
...

Known bug, fix below:

<-- snip -->

Date: Mon, 27 Dec 2004 23:50:15 +0100
From: Adrian Bunk <[email protected]>
To: "Michael S. Tsirkin" <[email protected]>
Cc: [email protected], [email protected]
Subject: [2.6 patch] add missing dependencies on MTD_PARTITIONS

Quoted 1 line · Michael S. Tsirkin

Hello!

Hi Michael!

Quoted 10 lines

Sorry, I had a wrong subject.
It seems that you can disable MTD partitioning support but enable , e.g. NAND.
And, if you are upgrading from and older kernel without the paritioning option, and do oldconfig and are not careful, thats what you end up with.
But, lots of code is calling del_mtd_partitions now, so you get unresolved del_mtd_partitions.

Quoted 2 lines

Its easy to work around this by enabling partitioning, but should not the dependency be added in the relevant KConfig?

First of all thanks for your report.
You didn't send the exact error mesage.
I'm able to reproduce the following in 2.6.10-rc3-mm1:

<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o(.init.text+0x6464b): In function `init_scx200_docflash':
: undefined reference to add_mtd_partitions' drivers/built-in.o(.init.text+0x66ab8): In function ns_init_module':
: undefined reference to add_mtd_partitions' drivers/built-in.o(.exit.text+0x8bf4): In function cleanup_scx200_docflash':
: undefined reference to `del_mtd_partitions'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

The patch below fixes them.

Please tell whether this fixes the problems you observed.

Quoted 3 lines

Cc me directly, I'm not on the list.
Thanks,
MST

cu
Adrian

diffstat output:

 drivers/mtd/maps/Kconfig |    2 +-
 drivers/mtd/nand/Kconfig |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Signed-off-by Adrian Bunk <[email protected]>

drivers/mtd/maps/Kconfig renamed from drivers/mtd/maps/Kconfig.old +1 -1

@@ -159,7 +159,7 @@
 
 config MTD_SCx200_DOCFLASH
 	tristate "Flash device mapped with DOCCS on NatSemi SCx200"
-	depends on X86 && MTD_CFI
+	depends on X86 && MTD_CFI && MTD_PARTITIONS
 	help
 	  Enable support for a flash chip mapped using the DOCCS signal on a
 	  National Semiconductor SCx200 processor.

drivers/mtd/nand/Kconfig renamed from drivers/mtd/nand/Kconfig.old +1 -1

@@ -198,7 +198,7 @@
  
  config MTD_NAND_NANDSIM
  	bool "Support for NAND Flash Simulator"
- 	depends on MTD_NAND
+ 	depends on MTD_NAND && MTD_PARTITIONS
 
 	help
 	  The simulator may simulate verious NAND flash chips for the