Skip to contentSkip to conversation

linux-next: sound tree build warning

PATCH In review Stephen Rothwell 3 participants 3 messages Jul 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Takashi,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id' sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type' sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void

Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
- Fix capture source selection in patch_via.c").

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

PATCH 1/1 sound: pci/hda/patch_via.c fix compilation warning

Quoted 4 lines · Stephen Rothwell

Hi Takashi,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

Quoted 9 lines

sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id' sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type' sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void

Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
- Fix capture source selection in patch_via.c").

[PATCH] sound: pci/hda/patch_via.c fix compilation warning

sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id' sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type' sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void

---
 sound/pci/hda/patch_via.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
sound/pci/hda/patch_via.c +1 -3
index 38db459..d05b718 100644
@@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
 	struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
 	struct via_spec *spec = codec->spec;
 	unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
-	unsigned int vendor_id = codec->vendor_id;
 
 	if (!spec->mux_nids[adc_idx])
 		return -EINVAL;
@@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
 	return 0;
 }
 
-static int get_mux_nids(struct hda_codec *codec)
+static void get_mux_nids(struct hda_codec *codec)
 {
 	struct via_spec *spec = codec->spec;
 	hda_nid_t nid, conn[8];
-	unsigned int type;
 	int i, n;
 
 	for (i = 0; i < spec->num_adc_nids; i++) {
Signature · 1 line
1.6.0.6
#2 lore raw

Re: [PATCH] sound: pci/hda/patch_via.c fix compilation warning

At Wed, 08 Jul 2009 11:27:50 +0530,

Quoted 18 lines · Jaswinder Singh Rajput
Quoted 4 lines · Stephen Rothwell

Hi Takashi,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

Quoted 9 lines

sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id' sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type' sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void

Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
- Fix capture source selection in patch_via.c").

[PATCH] sound: pci/hda/patch_via.c fix compilation warning

Quoted 8 lines

sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id' sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type' sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void

It was already fixed a few minutes ago :) Thanks anyway.

Takashi

Quoted 34 lines
---
 sound/pci/hda/patch_via.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
sound/pci/hda/patch_via.c +1 -3
index 38db459..d05b718 100644
@@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
 	struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
 	struct via_spec *spec = codec->spec;
 	unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
-	unsigned int vendor_id = codec->vendor_id;
 
 	if (!spec->mux_nids[adc_idx])
 		return -EINVAL;
@@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
 	return 0;
 }
 
-static int get_mux_nids(struct hda_codec *codec)
+static void get_mux_nids(struct hda_codec *codec)
 {
 	struct via_spec *spec = codec->spec;
 	hda_nid_t nid, conn[8];
-	unsigned int type;
 	int i, n;
 
 	for (i = 0; i < spec->num_adc_nids; i++) {
Signature · 1 line
1.6.0.6