snd-ak4114: Fix two array overflows
PATCH 1/1 snd-ak4114: Fix two array overflows
Fix the handling of the TXCSB registers cache. There was one array overflow in reg_write() and one in snd_ak4114_reg_write(). Thanks to David Binderman for reporting the latter.
The second overflow probably doesn't matter much, given that the function snd_ak4114_reg_write() appears to be never called. I wonder why it exists and why it is exported.
---
I do not have this device, can anyone please test this change?
sound/i2c/other/ak4114.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/i2c/other/ak4114.c +4 -3
@@ -42,8 +42,8 @@ static void reg_write(struct ak4114 *ak4 ak4114->write (ak4114->private_data, reg, val);if (reg <=AK4114_REG_INT1_MASK ) ak4114->regmap[reg] = val; -else if (reg >=AK4114_REG_RXCSB0 && reg <=AK4114_REG_TXCSB4 ) - ak4114->txcsb[reg-AK4114_REG_RXCSB0 ] = val; +else if (reg >=AK4114_REG_TXCSB0 && reg <=AK4114_REG_TXCSB4 ) + ak4114->txcsb[reg-AK4114_REG_TXCSB0 ] = val; }static inline unsigned char reg_read (struct ak4114 *ak4114,unsigned char reg)
@@ -134,7 +134,8 @@ void snd_ak4114_reg_write(struct ak4114if (reg <=AK4114_REG_INT1_MASK )reg_write (chip, reg, (chip->regmap[reg] & ~mask) | val);else if (reg >=AK4114_REG_TXCSB0 && reg <=AK4114_REG_TXCSB4 ) -reg_write (chip, reg, (chip->txcsb[reg] & ~mask) | val); +reg_write (chip, reg, + (chip->txcsb[reg-AK4114_REG_TXCSB0 ] & ~mask) | val); }void snd_ak4114_reinit (struct ak4114 *chip)
Signature · 7 lines
Jean Delvare ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
At Sat, 3 Feb 2007 18:53:31 +0100,
Quoted 10 lines · Jean Delvare
Fix the handling of the TXCSB registers cache. There was one array overflow in
reg_write()and one insnd_ak4114_reg_write(). Thanks to David Binderman for reporting the latter.The second overflow probably doesn't matter much, given that the function
snd_ak4114_reg_write()appears to be never called. I wonder why it exists and why it is exported.Signed-off-by Jean Delvare <[email protected]>
Thanks, I applied it to ALSA HG tree now.
Quoted 2 lines
---
I do not have this device, can anyone please test this change?
If this really affects the real device, we should put it to stable tree ASAP...
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642