Skip to contentSkip to conversation

ASoC: Intel: add SNDRV_PCM_INFO_DRAIN_TRIGGER flag

PATCH In review [email protected] 2 participants 4 messages Feb 17, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: add SNDRV_PCM_INFO_DRAIN_TRIGGER flag

From: Libin Yang <[email protected]>

Add SNDRV_PCM_INFO_DRAIN_TRIGGER in snd_pcm_hardware.info to call sst_hsw_stream_set_silence_start() when PCM draining.

---
 sound/soc/intel/sst-haswell-pcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/intel/sst-haswell-pcm.c +2 -1
index d6fa9d5..7e21e8f 100644
@@ -91,7 +91,8 @@ static const struct snd_pcm_hardware hsw_pcm_hardware = {
 				  SNDRV_PCM_INFO_INTERLEAVED |
 				  SNDRV_PCM_INFO_PAUSE |
 				  SNDRV_PCM_INFO_RESUME |
-				  SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
+				  SNDRV_PCM_INFO_NO_PERIOD_WAKEUP |
+				  SNDRV_PCM_INFO_DRAIN_TRIGGER,
 	.formats		= SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
 				  SNDRV_PCM_FMTBIT_S32_LE,
 	.period_bytes_min	= PAGE_SIZE,
Signature · 1 line
1.9.1
#1 lore raw

Hi Takashi & Mark,

This patch is for Takashi's tree.

Regards,
Libin

Quoted 41 lines

-----Original Message-----
From: Yang, Libin
Sent: Tuesday, February 17, 2015 12:28 PM
To: [email protected]; [email protected];
[email protected]
Cc: Girdwood, Liam R; Yang, Libin; Jie, Yang
Subject: [PATCH] ASoC: Intel: add
SNDRV_PCM_INFO_DRAIN_TRIGGER flag

From: Libin Yang <[email protected]>

Add SNDRV_PCM_INFO_DRAIN_TRIGGER in snd_pcm_hardware.info to
call sst_hsw_stream_set_silence_start() when PCM draining.

---
 sound/soc/intel/sst-haswell-pcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/intel/sst- renamed from sound/soc/intel/sst-haswell-pcm.c +0 -0

haswell-pcm.c
index d6fa9d5..7e21e8f 100644

sound/soc/intel/sst-haswell-pcm.c +1 -1
@@ -91,7 +91,8 @@ static const struct snd_pcm_hardware
 hsw_pcm_hardware = {
 				  SNDRV_PCM_INFO_INTERLEAVED |
 				  SNDRV_PCM_INFO_PAUSE |
 				  SNDRV_PCM_INFO_RESUME |
-
 SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
+

SNDRV_PCM_INFO_NO_PERIOD_WAKEUP |

sound/soc/intel/sst-haswell-pcm.c +1 -0
+				  SNDRV_PCM_INFO_DRAIN_TRIGGER,
 	.formats		= SNDRV_PCM_FMTBIT_S16_LE |

SNDRV_PCM_FMTBIT_S24_LE |

sound/soc/intel/sst-haswell-pcm.c +0 -1
 				  SNDRV_PCM_FMTBIT_S32_LE,
 	.period_bytes_min	= PAGE_SIZE,
--

1.9.1

#2 lore raw

At Tue, 17 Feb 2015 04:53:45 +0000,

Quoted 4 lines · Libin

Hi Takashi & Mark,

This patch is for Takashi's tree.

OK, I took it to for-linus (or for-next, equivalently) branch now.

thanks,

Takashi

Quoted 47 lines

Regards,
Libin

Quoted 41 lines

-----Original Message-----
From: Yang, Libin
Sent: Tuesday, February 17, 2015 12:28 PM
To: [email protected]; [email protected];
[email protected]
Cc: Girdwood, Liam R; Yang, Libin; Jie, Yang
Subject: [PATCH] ASoC: Intel: add
SNDRV_PCM_INFO_DRAIN_TRIGGER flag

From: Libin Yang <[email protected]>

Add SNDRV_PCM_INFO_DRAIN_TRIGGER in snd_pcm_hardware.info to
call sst_hsw_stream_set_silence_start() when PCM draining.

---
 sound/soc/intel/sst-haswell-pcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/intel/sst- renamed from sound/soc/intel/sst-haswell-pcm.c +0 -0

haswell-pcm.c
index d6fa9d5..7e21e8f 100644

sound/soc/intel/sst-haswell-pcm.c +1 -1
@@ -91,7 +91,8 @@ static const struct snd_pcm_hardware
 hsw_pcm_hardware = {
 				  SNDRV_PCM_INFO_INTERLEAVED |
 				  SNDRV_PCM_INFO_PAUSE |
 				  SNDRV_PCM_INFO_RESUME |
-
 SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
+

SNDRV_PCM_INFO_NO_PERIOD_WAKEUP |

sound/soc/intel/sst-haswell-pcm.c +1 -0
+				  SNDRV_PCM_INFO_DRAIN_TRIGGER,
 	.formats		= SNDRV_PCM_FMTBIT_S16_LE |

SNDRV_PCM_FMTBIT_S24_LE |

sound/soc/intel/sst-haswell-pcm.c +0 -1
 				  SNDRV_PCM_FMTBIT_S32_LE,
 	.period_bytes_min	= PAGE_SIZE,
--

1.9.1

#3 lore raw

Hi Takashi,

Quoted 9 lines

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Tuesday, February 17, 2015 2:51 PM
To: Yang, Libin
Cc: [email protected]; [email protected]; Girdwood, Liam R; Jie, Yang
Subject: Re: [PATCH] ASoC: Intel: add SNDRV_PCM_INFO_DRAIN_TRIGGER flag

Quoted 8 lines

At Tue, 17 Feb 2015 04:53:45 +0000,

Quoted 4 lines · Libin

Hi Takashi & Mark,

This patch is for Takashi's tree.

OK, I took it to for-linus (or for-next, equivalently) branch now.

Got it. Thanks.

Quoted 55 lines

thanks,

Takashi

Quoted 17 lines

Regards,
Libin

Quoted 12 lines

-----Original Message-----
From: Yang, Libin
Sent: Tuesday, February 17, 2015 12:28 PM
To: [email protected]; [email protected];
[email protected]
Cc: Girdwood, Liam R; Yang, Libin; Jie, Yang
Subject: [PATCH] ASoC: Intel: add
SNDRV_PCM_INFO_DRAIN_TRIGGER flag

From: Libin Yang <[email protected]>

Add SNDRV_PCM_INFO_DRAIN_TRIGGER in

snd_pcm_hardware.info

Quoted 9 lines

Review

Quoted 9 lines

to
call sst_hsw_stream_set_silence_start() when PCM draining.

---
 sound/soc/intel/sst-haswell-pcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/sound/soc/intel/sst-

Quoted 21 lines
Quoted 20 lines

haswell-pcm.c
index d6fa9d5..7e21e8f 100644

sound/soc/intel/sst-haswell-pcm.c +1 -1
@@ -91,7 +91,8 @@ static const struct snd_pcm_hardware
 hsw_pcm_hardware = {
 				  SNDRV_PCM_INFO_INTERLEAVED |
 				  SNDRV_PCM_INFO_PAUSE |
 				  SNDRV_PCM_INFO_RESUME |
-
 SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
+

SNDRV_PCM_INFO_NO_PERIOD_WAKEUP |

sound/soc/intel/sst-haswell-pcm.c +1 -0
+				  SNDRV_PCM_INFO_DRAIN_TRIGGER,
 	.formats		= SNDRV_PCM_FMTBIT_S16_LE |

SNDRV_PCM_FMTBIT_S24_LE |

sound/soc/intel/sst-haswell-pcm.c +0 -1
 				  SNDRV_PCM_FMTBIT_S32_LE,
 	.period_bytes_min	= PAGE_SIZE,
--

1.9.1