Skip to contentSkip to conversation

ALSA: hda/realtek - Correction of fixup codes for PB V7900 laptop

PATCH Ronan 2 participants 3 messages Jun 2, 2014

lore
Share & tools
lore

Ronan

author
#0 lore raw
Quoted 41 lines

Message du 02/06/14 08:46
De : "Takashi Iwai"
A : [email protected]
Copie à : [email protected]
Objet : Re: [PATCH 1/1] ALSA: hda/realtek - Correction of fixup codes for PB V7900 laptop

At Sun, 1 Jun 2014 18:38:53 +0200,

Quoted 13 lines · [email protected] wrote:

From: Ronan Marquet

Correcion of wrong fixup entries add in commit ca8f0424 to replace static model quirk for PB V7900 laptop (will model).

Signed-off-by Ronan Marquet
sound/pci/hda/patch_realtek.c +0 -0
index 49e884f..0e3a7f6 100644

sound/pci/hda/patch_realtek.c static const struct hda_fixup alc260_fixups[] = { · line 1651

Quoted 7 lines
sound/pci/hda/patch_realtek.c +2 -2
@@ -1647,12 +1647,10 @@ static const struct hda_fixup alc260_fixups[] = {
 [ALC260_FIXUP_COEF] = {
 .type = HDA_FIXUP_VERBS,
 .v.verbs = (const struct hda_verb[]) {
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x07 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x3040 },
+ { 0x1a, AC_VERB_SET_COEF_INDEX, 0x07 },
+ { 0x1a, AC_VERB_SET_PROC_COEF, 0x3040 },

That part looks correct, however:

sound/pci/hda/patch_realtek.c static const struct hda_fixup alc260_fixups[] = { · line 1655

Quoted 4 lines
sound/pci/hda/patch_realtek.c +0 -2
 { }
 },
- .chained = true,
- .chain_id = ALC260_FIXUP_HP_PIN_0F,
Quoted 16 lines

Is this removal mandatory? In other words, is keeping this harmful?
The original quirk had this, so it may be safer to keep it for other
machines.
Yes, if i keep this two lines, i have a crackling sound and the internal output is blinking into Gnome's sound setting (Jack detection problem ?).Whitout this lines, all is working find on my laptop but, perhpas, it could be fixe differently ? thanks, Ronan

thanks,

Takashi

Quoted 6 lines
sound/pci/hda/patch_realtek.c +0 -0
 },
 [ALC260_FIXUP_GPIO1] = {
 .type = HDA_FIXUP_VERBS,
Signature · 1 line
2.0.0.rc2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Mon, 2 Jun 2014 13:59:25 +0200 (CEST),

Quoted 42 lines · Ronan
Quoted 42 lines

Message du 02/06/14 08:46
De : "Takashi Iwai"
A : [email protected]
Copie à : [email protected]
Objet : Re: [PATCH 1/1] ALSA: hda/realtek - Correction of fixup codes for PB V7900 laptop

At Sun, 1 Jun 2014 18:38:53 +0200,

Quoted 13 lines · [email protected] wrote:

From: Ronan Marquet

Correcion of wrong fixup entries add in commit ca8f0424 to replace static model quirk for PB V7900 laptop (will model).

Signed-off-by Ronan Marquet
sound/pci/hda/patch_realtek.c +0 -0
index 49e884f..0e3a7f6 100644

sound/pci/hda/patch_realtek.c static const struct hda_fixup alc260_fixups[] = { · line 1651

Quoted 7 lines
sound/pci/hda/patch_realtek.c +2 -2
@@ -1647,12 +1647,10 @@ static const struct hda_fixup alc260_fixups[] = {
 [ALC260_FIXUP_COEF] = {
 .type = HDA_FIXUP_VERBS,
 .v.verbs = (const struct hda_verb[]) {
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x07 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x3040 },
+ { 0x1a, AC_VERB_SET_COEF_INDEX, 0x07 },
+ { 0x1a, AC_VERB_SET_PROC_COEF, 0x3040 },

That part looks correct, however:

Quoted 4 lines
sound/pci/hda/patch_realtek.c +0 -2
 { }
 },
- .chained = true,
- .chain_id = ALC260_FIXUP_HP_PIN_0F,
Quoted 4 lines
Quoted 4 lines

Is this removal mandatory? In other words, is keeping this harmful?
The original quirk had this, so it may be safer to keep it for other
machines.
Yes, if i keep this two lines, i have a crackling sound and the internal output is blinking into Gnome's sound setting (Jack detection problem ?).Whitout this lines, all is working find on my laptop but, perhpas, it could be fixe differently ? thanks, Ronan

Interesting. Could you attach alsa-info.sh outputs both with and without this chain? If the removal of this chain is needed, we should split the patch, one for correcting the wrong widget NID and another for the removal of the chain.

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw

At Mon, 02 Jun 2014 14:01:10 +0200,

Quoted 50 lines · Takashi Iwai

At Mon, 2 Jun 2014 13:59:25 +0200 (CEST),

Quoted 42 lines · Ronan
Quoted 42 lines

Message du 02/06/14 08:46
De : "Takashi Iwai"
A : [email protected]
Copie à : [email protected]
Objet : Re: [PATCH 1/1] ALSA: hda/realtek - Correction of fixup codes for PB V7900 laptop

At Sun, 1 Jun 2014 18:38:53 +0200,

Quoted 13 lines · [email protected] wrote:

From: Ronan Marquet

Correcion of wrong fixup entries add in commit ca8f0424 to replace static model quirk for PB V7900 laptop (will model).

Signed-off-by Ronan Marquet
sound/pci/hda/patch_realtek.c +0 -0
index 49e884f..0e3a7f6 100644

sound/pci/hda/patch_realtek.c static const struct hda_fixup alc260_fixups[] = { · line 1651

Quoted 7 lines
sound/pci/hda/patch_realtek.c +2 -2
@@ -1647,12 +1647,10 @@ static const struct hda_fixup alc260_fixups[] = {
 [ALC260_FIXUP_COEF] = {
 .type = HDA_FIXUP_VERBS,
 .v.verbs = (const struct hda_verb[]) {
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x07 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x3040 },
+ { 0x1a, AC_VERB_SET_COEF_INDEX, 0x07 },
+ { 0x1a, AC_VERB_SET_PROC_COEF, 0x3040 },

That part looks correct, however:

Quoted 4 lines
sound/pci/hda/patch_realtek.c +0 -2
 { }
 },
- .chained = true,
- .chain_id = ALC260_FIXUP_HP_PIN_0F,
Quoted 4 lines
Quoted 4 lines

Is this removal mandatory? In other words, is keeping this harmful?
The original quirk had this, so it may be safer to keep it for other
machines.
Yes, if i keep this two lines, i have a crackling sound and the internal output is blinking into Gnome's sound setting (Jack detection problem ?).Whitout this lines, all is working find on my laptop but, perhpas, it could be fixe differently ? thanks, Ronan

Quoted 4 lines

Interesting. Could you attach alsa-info.sh outputs both with and without this chain? If the removal of this chain is needed, we should split the patch, one for correcting the wrong widget NID and another for the removal of the chain.

Never mind, I checked the alsa-info.sh output of PB V7900 and also HP B1900, and the chain for NID 0x0f looks invalid for these machines that have really only a single output. This may confuse PulseAudio.

I'll take your patch as is now.

thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel