Skip to contentSkip to conversation

ALSA: atmel: remove dependency on <mach/gpio.h>

PATCH New Linus Walleij 3 participants 3 messages Nov 5, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/4 ALSA: atmel: remove dependency on <mach/gpio.h>

This include is completely unused since the AT91 sound driver actually uses gpiolib properly.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>

---
ALSA SoC folks: please apply this as a fix if you wish, else I'd like an ACK so I can merge it in front of the dependent patches in the next (v3.14) merge cycle.

---
 sound/atmel/ac97c.c | 1 -
 1 file changed, 1 deletion(-)
sound/atmel/ac97c.c +0 -1
index ae63d22c0f88..c5f0ddd729b3 100644
@@ -34,7 +34,6 @@
 #include <linux/dw_dmac.h>
 
 #include <mach/cpu.h>
-#include <mach/gpio.h>
 
 #ifdef CONFIG_ARCH_AT91
 #include <mach/hardware.h>
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 2/4 ALSA: atmel: remove dependency on <mach/gpio.h>

On 05/11/2013 10:29, Linus Walleij :

Quoted 2 lines

This include is completely unused since the AT91 sound driver actually uses gpiolib properly.

Absolutely:

Thanks Linus.

Quoted 26 lines
Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>

---
ALSA SoC folks: please apply this as a fix if you wish, else I'd like an ACK so I can merge it in front of the dependent patches in the next (v3.14) merge cycle.

---
  sound/atmel/ac97c.c | 1 -
  1 file changed, 1 deletion(-)
sound/atmel/ac97c.c +0 -1
index ae63d22c0f88..c5f0ddd729b3 100644
@@ -34,7 +34,6 @@
  #include <linux/dw_dmac.h>
 
  #include <mach/cpu.h>
-#include <mach/gpio.h>
 
  #ifdef CONFIG_ARCH_AT91
  #include <mach/hardware.h>
Signature · 1 line
Nicolas Ferre
#2 lore raw

PATCH 2/4 ALSA: atmel: remove dependency on <mach/gpio.h>

In reply to Linus Walleij

At Tue, 5 Nov 2013 10:29:49 +0100,

Quoted 9 lines · Linus Walleij

This include is completely unused since the AT91 sound driver actually uses gpiolib properly.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>
Quoted 4 lines

---
ALSA SoC folks: please apply this as a fix if you wish, else I'd like an ACK so I can merge it in front of the dependent patches in the next (v3.14) merge cycle.

Thanks, I applied the patch now.

Takashi

Quoted 19 lines
---
 sound/atmel/ac97c.c | 1 -
 1 file changed, 1 deletion(-)
sound/atmel/ac97c.c +0 -1
index ae63d22c0f88..c5f0ddd729b3 100644
@@ -34,7 +34,6 @@
 #include <linux/dw_dmac.h>
 
 #include <mach/cpu.h>
-#include <mach/gpio.h>
 
 #ifdef CONFIG_ARCH_AT91
 #include <mach/hardware.h>
Signature · 1 line
1.8.3.1