Skip to contentSkip to conversation

HDA-Intel - Add support for RV610/RV630 HDMI audio

PATCH Applied Herton Ronaldo Krzesinski 3 participants 4 messages Nov 2, 2007 – Nov 16, 2007 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HDA-Intel - Add support for RV610/RV630 HDMI audio

The Audio interface on HD2400/HD2600 cards isn't currently detected by snd-hda-intel. I added missing pci device ids for RV610 and RV630, but I only had a HD2400 pro card to test, where now the audio interface is detected (and no need to change patch_atihdmi.c, as the codec vendor id remains 0x1002aa01 for which we already have an entry there). I also couldn't test if sound pass-trough is ok (and I don't know how to), but at least now the device is detected.

sound/pci/hda/hda_intel.c renamed from sound/pci/hda/hda_intel.c.orig +4 -0
@@ -104,6 +104,8 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6},
 			 "{ATI, RS690},"
 			 "{ATI, RS780},"
 			 "{ATI, R600},"
+			 "{ATI, RV630},"
+			 "{ATI, RV610},"
 			 "{VIA, VT8251},"
 			 "{VIA, VT8237A},"
 			 "{SiS, SIS966},"
@@ -1945,6 +1947,8 @@ static struct pci_device_id azx_ids[] = 
 	{ 0x1002, 0x7919, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RS690 HDMI */
 	{ 0x1002, 0x960c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RS780 HDMI */
 	{ 0x1002, 0xaa00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI R600 HDMI */
+	{ 0x1002, 0xaa08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV630 HDMI */
+	{ 0x1002, 0xaa10, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV610 HDMI */
 	{ 0x1106, 0x3288, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_VIA }, /* VIA VT8251/VT8237A */
 	{ 0x1039, 0x7502, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_SIS }, /* SIS966 */
 	{ 0x10b9, 0x5461, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ULI }, /* ULI M5461 */

--
[]'s
Herton

Applied
#1 lore raw

At Fri, 2 Nov 2007 02:41:42 -0200,

Quoted 10 lines · Herton Ronaldo Krzesinski

The Audio interface on HD2400/HD2600 cards isn't currently detected by snd-hda-intel. I added missing pci device ids for RV610 and RV630, but I only had a HD2400 pro card to test, where now the audio interface is detected (and no need to change patch_atihdmi.c, as the codec vendor id remains 0x1002aa01 for which we already have an entry there). I also couldn't test if sound pass-trough is ok (and I don't know how to), but at least now the device is detected.

Thanks, applied to ALSA tree now.

Takashi

#2 lore raw

PATCH 1/1 HDA-Intel - Add support for RV6xx HDMI audio

Hi,

This patch is to add R6xx HDMI audio support. Meanwhile, the device ID in the previous patch is changed.
I have checked the patch from Herton Ronaldo Krzesinski, it's right as our spec said. :)

Thanks!

pci/hda/hda_intel.c +4 -0
diff -r af733bf8e50c pci/hda/hda_intel.c
@@ -106,6 +106,10 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6},
 			 "{ATI, R600},"
 			 "{ATI, RV630},"
 			 "{ATI, RV610},"
+			 "{ATI, RV670},"
+			 "{ATI, RV635},"
+			 "{ATI, RV620},"
+			 "{ATI, RV770},"
 			 "{VIA, VT8251},"
 			 "{VIA, VT8237A},"
 			 "{SiS, SIS966},"
@@ -1942,10 +1946,14 @@ static struct pci_device_id azx_ids[] = 
 	{ 0x1002, 0x4383, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATI

}, /* ATI SB600 */
{ 0x1002, 0x793b, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RS600 HDMI */
{ 0x1002, 0x7919, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RS690 HDMI */
- { 0x1002, 0x960c, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RS780 HDMI */
+ { 0x1002, 0x960f, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RS780 HDMI */
{ 0x1002, 0xaa00, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI R600 HDMI */
{ 0x1002, 0xaa08, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RV630 HDMI */
{ 0x1002, 0xaa10, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RV610 HDMI */
+ { 0x1002, 0xaa18, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RV670 HDMI */
+ { 0x1002, 0xaa20, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RV635 HDMI */
+ { 0x1002, 0xaa28, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RV620 HDMI */
+ { 0x1002, 0xaa30, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
AZX_DRIVER_ATIHDMI }, /* ATI RV770 HDMI */
{ 0x1106, 0x3288, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_VIA
}, /* VIA VT8251/VT8237A */
{ 0x1039, 0x7502, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_SIS
}, /* SIS966 */
{ 0x10b9, 0x5461, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ULI
}, /* ULI M5461 */

pci/hda/patch_atihdmi.c +0 -0
diff -r af733bf8e50c pci/hda/patch_atihdmi.c
@@ -158,6 +158,6 @@ struct hda_codec_preset snd_hda_preset_a
 	{ .id = 0x1002793c, .name = "ATI RS600 HDMI", .patch =

patch_atihdmi },
{ .id = 0x10027919, .name = "ATI RS600 HDMI", .patch =
patch_atihdmi },
{ .id = 0x1002791a, .name = "ATI RS690/780 HDMI", .patch =
patch_atihdmi },
- { .id = 0x1002aa01, .name = "ATI R600 HDMI", .patch =
patch_atihdmi },
+ { .id = 0x1002aa01, .name = "ATI R6xx HDMI", .patch =
patch_atihdmi },
{} /* terminator */
};

Applied
#3 lore raw

Re: [PATCH] HDA-Intel - Add support for RV6xx HDMI audio

At Fri, 16 Nov 2007 17:49:33 +0800,

Quoted 8 lines · Wolke

Hi,

This patch is to add R6xx HDMI audio support. Meanwhile, the device ID in the previous patch is changed.
I have checked the patch from Herton Ronaldo Krzesinski, it's right as our spec said. :)

Quoted 4 lines

Thanks!

Thanks, applied to ALSA tree now.

Takashi