Skip to contentSkip to conversation

ASoC: dwc: remove 'out of memory' message

PATCH In review Mihai Burduselu 4 participants 4 messages Feb 25, 2017 – Mar 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dwc: remove 'out of memory' message

Reported by checkpatch.pl

---
 sound/soc/dwc/designware_i2s.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/dwc/designware_i2s.c +1 -3
index 9c46e4112026..6479768cc6a1 100644
@@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
 	const char *clk_id;
 
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		dev_warn(&pdev->dev, "kzalloc fail\n");
+	if (!dev)
 		return -ENOMEM;
-	}
 
 	dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
 	if (!dw_i2s_dai)
Signature · 1 line
2.11.0
#1 lore raw

Hi,

Quoted 11 lines · Mihai Burduselu

Reported by checkpatch.pl

---
 sound/soc/dwc/designware_i2s.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/dwc/designware_i2s.c +0 -0
index 9c46e4112026..6479768cc6a1 100644

sound/soc/dwc/designware_i2s.c static int dw_i2s_probe(struct platform_device *pdev) · line 614

Quoted 6 lines
sound/soc/dwc/designware_i2s.c +1 -2
@@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
 	const char *clk_id;
 
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		dev_warn(&pdev->dev, "kzalloc fail\n");
+	if (!dev)

The line for 'dev_warn()' should be kept.

sound/soc/dwc/designware_i2s.c static int dw_i2s_probe(struct platform_device *pdev) · line 618

Quoted 5 lines
sound/soc/dwc/designware_i2s.c +0 -1
 		return -ENOMEM;
-	}
 
 	dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
 	if (!dw_i2s_dai)

Regards

Takashi Sakamoto

#2 lore raw
Quoted 17 lines · Takashi Sakamoto

Hi,

Quoted 13 lines · Mihai Burduselu

Reported by checkpatch.pl

---
 sound/soc/dwc/designware_i2s.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/dwc/designware_i2s.c +0 -0
index 9c46e4112026..6479768cc6a1 100644
@@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
 	const char *clk_id;
 
Quoted 6 lines

sound/soc/dwc/designware_i2s.c static int dw_i2s_probe(struct platform_device *pdev) · line 614

Quoted 4 lines
sound/soc/dwc/designware_i2s.c +1 -2
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		dev_warn(&pdev->dev, "kzalloc fail\n");
+	if (!dev)

The line for 'dev_warn()' should be kept.

In general, people regard it superfluous since kmalloc() itself already gives a kernel warning at an allocation error. So removing the message is OK in that sense.

However, the problem of this (and lots of other) patch is that it doesn't give proper information. Instead, in a single line, it merely declares checkpatch.pl as a bible. Very helpful, eh?

So, please reconsider the changelog when you submit this kind of patches.

thanks,

Takashi

maintainer
#3 lore raw
Quoted 6 lines · Takashi Iwai

However, the problem of this (and lots of other) patch is that it doesn't give proper information. Instead, in a single line, it merely declares checkpatch.pl as a bible. Very helpful, eh?

So, please reconsider the changelog when you submit this kind of patches.

Yeah, it's a *huge* set of patches with poor changelogs and very minor benefits which is more work to digest than it seems useful to.