Skip to contentSkip to conversation

Improve parameter constraints in alsa-pulse

PATCH In review Pierre Ossman 2 participants 3 messages Mar 5, 2007 – Mar 8, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Improve parameter constraints in alsa-pulse

Remove parameter constraints where we actually have none. Also, restrict total buffer size to 4 MB as current versions of the PulseAudio server will refuse streams larger than that.

pulse/pcm_pulse.c +1 -16
diff -r ea810fbf4cd0 pulse/pcm_pulse.c
@@ -643,23 +643,8 @@ static int pulse_hw_constraint(snd_pcm_p
     if (err < 0)
         return err;
 
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_RATE,
-        8000, 48000);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIOD_BYTES,
-        1, 4294967295U);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIODS,
-        2, 4294967295U);
-    if (err < 0)
-        return err;
-
     err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_BUFFER_BYTES,
-        1, 4294967295U);
+        1, 4 * 1024 * 1024);
     if (err < 0)
         return err;
 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

At Mon, 05 Mar 2007 14:33:18 +0100,

Quoted 6 lines · Pierre Ossman

Remove parameter constraints where we actually have none. Also, restrict total buffer size to 4 MB as current versions of the PulseAudio server will refuse streams larger than that.

Thanks. The patch is on my local tree and I'll push it as soon as the HG server is recovered.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#2 lore raw

At Wed, 07 Mar 2007 22:22:32 +0100,

Quoted 4 lines · I wrote:

At Mon, 05 Mar 2007 14:33:18 +0100,

Quoted 1 line · Pierre Ossman
Quoted 8 lines
Quoted 5 lines

Remove parameter constraints where we actually have none. Also, restrict total buffer size to 4 MB as current versions of the PulseAudio server will refuse streams larger than that.

Thanks. The patch is on my local tree and I'll push it as soon as the HG server is recovered.

Now it's on ALSA HG tree.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV