Skip to contentSkip to conversation

future of sounds/oss

DISCUSSION Christoph Hellwig 7 participants 19 messages May 11, 2017 – May 16, 2017 Sound

lore
Share & tools
lore
#0 lore raw

Ho Jaroslav, hi Takashi,

do you know who still uses the sound/oss drivers and why? I've recently been looking into getting rid of set_fs for using copy_{from,to}_user and friends on kernel pointers, and the sound code is a big abuser, both ALSA and the legacy OSS code.

But looking at the OSS code it's pretty grotty, and also appears to be pretty much unmaintained except for global cleanups. Is there any chance we could look into getting rid of it over the next few merge windows or are there people that rely on it?

#1 lore raw
Quoted 7 lines · Christoph Hellwig

Ho Jaroslav, hi Takashi,

do you know who still uses the sound/oss drivers and why? I've recently been looking into getting rid of set_fs for using copy_{from,to}_user and friends on kernel pointers, and the sound code is a big abuser, both ALSA and the legacy OSS code.

Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest.

But the set_fs() usage in OSS code is hard to get rid of, due to the in-kernel ioctl calls, and I really don't want to touch such dusty codes, either. So I wanted to post the very same question, but you were faster :)

Quoted 4 lines

But looking at the OSS code it's pretty grotty, and also appears to be pretty much unmaintained except for global cleanups. Is there any chance we could look into getting rid of it over the next few merge windows or are there people that rely on it?

I don't think there are any active users. The only slight concern is that there are a few ancient devices that are supported only by some OSS drivers. But these are over decades, and very unlikely alive.

That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig.

The latter can be done even for 4.12, if Linus doesn't mind.

thanks,

Takashi

#2 lore raw
Quoted 3 lines · Takashi Iwai

Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest.

Great!

Quoted 4 lines

That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig.

The latter can be done even for 4.12, if Linus doesn't mind.

I'd be absolutely in favor of trying that and seeing if anyone screams.

#3 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Takashi Iwai

Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest.

Great!

Quoted 7 lines
Quoted 4 lines

That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig.

The latter can be done even for 4.12, if Linus doesn't mind.

I'd be absolutely in favor of trying that and seeing if anyone screams.

Since no one cried against it so far, I'll try to smuggle the following patch into 4.12.

Takashi

-- 8< --
From: Takashi Iwai <[email protected]>
Subject: [PATCH] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.

---
 sound/Kconfig | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)
sound/Kconfig +14 -12
index ee2e69a9ecd1..41eda578d08e 100644
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
 	  If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"
 
 if !M68K && !UML
 
@@ -112,17 +113,18 @@ source "sound/x86/Kconfig"
 
 endif # SND
 
-menuconfig SOUND_PRIME
-	tristate "Open Sound System (DEPRECATED)"
-	select SOUND_OSS_CORE
-	help
-	  Say 'Y' or 'M' to enable Open Sound System drivers.
-
-if SOUND_PRIME
-
-source "sound/oss/Kconfig"
-
-endif # SOUND_PRIME
+### TO-BE-REMOVED
+# menuconfig SOUND_PRIME
+# 	tristate "Open Sound System (DEPRECATED)"
+# 	select SOUND_OSS_CORE
+# 	help
+# 	  Say 'Y' or 'M' to enable Open Sound System drivers.
+#
+# if SOUND_PRIME
+#
+# source "sound/oss/Kconfig"
+#
+# endif # SOUND_PRIME
 
 endif # !M68K
 
Signature · 1 line
2.12.2
#4 lore raw
Quoted 3 lines · Takashi Iwai

Since no one cried against it so far, I'll try to smuggle the following patch into 4.12.

Can we instead just disable it with a one-liner that just makes SOUND_PRIME have a

depends on n

in it, so that you can't select it.

Commenting out stuff in the Kconfig fine is not how we normally do these things..

Linus

#5 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 3 lines · Takashi Iwai

Since no one cried against it so far, I'll try to smuggle the following patch into 4.12.

Can we instead just disable it with a one-liner that just makes SOUND_PRIME have a

Quoted 6 lines

depends on n

in it, so that you can't select it.

Commenting out stuff in the Kconfig fine is not how we normally do these things..

Yeah, I was thinking of
depends on BROKEN

but depends on n should be OK also.

Signature · 1 line
~Randy
#6 lore raw
In reply to Linus Torvalds
Quoted 9 lines · Linus Torvalds
Quoted 3 lines · Takashi Iwai

Since no one cried against it so far, I'll try to smuggle the following patch into 4.12.

Can we instead just disable it with a one-liner that just makes SOUND_PRIME have a

Quoted 6 lines

depends on n

in it, so that you can't select it.

Commenting out stuff in the Kconfig fine is not how we normally do these things..

I rather wanted to show clearly that we're disabling it by that, but I don't mind either way. Will respin soon.

thanks,

Takashi

#7 lore raw
In reply to Takashi Iwai

Hi Iwai-san,

Quoted 21 lines · Takashi Iwai

From: Takashi Iwai <[email protected]>
Subject: [PATCH] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.

---
 sound/Kconfig | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)
sound/Kconfig +0 -0
index ee2e69a9ecd1..41eda578d08e 100644

sound/Kconfig config SOUND_OSS_CORE_PRECLAIM · line 58

Quoted 6 lines
sound/Kconfig +2 -1
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
          If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#8 lore raw
Quoted 26 lines · Geert Uytterhoeven

Hi Iwai-san,

Quoted 22 lines · Takashi Iwai

From: Takashi Iwai <[email protected]>
Subject: [PATCH] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.

---
 sound/Kconfig | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)
sound/Kconfig +0 -0
index ee2e69a9ecd1..41eda578d08e 100644
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
Quoted 7 lines

sound/Kconfig config SOUND_OSS_CORE_PRECLAIM · line 58

Quoted 5 lines
sound/Kconfig +2 -1
          If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

These belong to the latter, "dead old and inactive" ones :)

Are these driver still used with the latest kernel? If users are willing to help, we can provide the port to ALSA drivers, too.

thanks,

Takashi

#9 lore raw

Hi Iwai-san,

Quoted 33 lines · Takashi Iwai
Quoted 23 lines · Geert Uytterhoeven
Quoted 22 lines · Takashi Iwai

From: Takashi Iwai <[email protected]>
Subject: [PATCH] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.

---
 sound/Kconfig | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)
sound/Kconfig +0 -0
index ee2e69a9ecd1..41eda578d08e 100644
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
Quoted 7 lines

sound/Kconfig config SOUND_OSS_CORE_PRECLAIM · line 58

Quoted 5 lines
sound/Kconfig +2 -1
          If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

Quoted 3 lines

These belong to the latter, "dead old and inactive" ones :)

Are these driver still used with the latest kernel? If users are

I believe so.

Quoted 1 line

willing to help, we can provide the port to ALSA drivers, too.

That would be great, thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#10 lore raw
Quoted 39 lines · Geert Uytterhoeven

Hi Iwai-san,

Quoted 35 lines · Takashi Iwai
Quoted 23 lines · Geert Uytterhoeven
Quoted 22 lines · Takashi Iwai

From: Takashi Iwai <[email protected]>
Subject: [PATCH] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.

---
 sound/Kconfig | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)
sound/Kconfig +0 -0
index ee2e69a9ecd1..41eda578d08e 100644
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
Quoted 7 lines

sound/Kconfig config SOUND_OSS_CORE_PRECLAIM · line 58

Quoted 5 lines
sound/Kconfig +2 -1
          If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

These belong to the latter, "dead old and inactive" ones :)

Quoted 7 lines
Quoted 1 line

Are these driver still used with the latest kernel? If users are

I believe so.

Quoted 1 line

willing to help, we can provide the port to ALSA drivers, too.

That would be great, thanks!

OK, we can go forward, then.

But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it?

And, dmasound is a completely different implementation from the other OSS, thus it doesn't suffer from set_fs() hack. That is, we may still keep dmasound, while removing other OSS stuff.

Meanwhile we'll try to support ALSA on m64k and eventually target to drop dmasound stuff.

Does it sound more feasible?

thanks,

Takashi

#11 lore raw

Hi Iwai-san,

Quoted 27 lines · Takashi Iwai
Quoted 25 lines · Geert Uytterhoeven
Quoted 16 lines · Takashi Iwai
Quoted 6 lines · Geert Uytterhoeven
Quoted 5 lines · Takashi Iwai

index ee2e69a9ecd1..41eda578d08e 100644

sound/Kconfig +0 -0
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
Quoted 7 lines

sound/Kconfig config SOUND_OSS_CORE_PRECLAIM · line 58

Quoted 5 lines
sound/Kconfig +2 -1
          If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

Quoted 3 lines

These belong to the latter, "dead old and inactive" ones :)

Are these driver still used with the latest kernel? If users are

I believe so.

Quoted 1 line

willing to help, we can provide the port to ALSA drivers, too.

Quoted 7 lines
Quoted 1 line

That would be great, thanks!

OK, we can go forward, then.

But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it?

Because ALSA doesn't have any drivers that can be used on m68k platforms?

Quoted 3 lines

And, dmasound is a completely different implementation from the other OSS, thus it doesn't suffer from set_fs() hack. That is, we may still keep dmasound, while removing other OSS stuff.

That's indeed good to know.

Quoted 4 lines

Meanwhile we'll try to support ALSA on m64k and eventually target to drop dmasound stuff.

Does it sound more feasible?

Yes, definitely in the short run ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Tested-by Randy Dunlap
#12 lore raw
Quoted 33 lines · Geert Uytterhoeven

Hi Iwai-san,

Quoted 29 lines · Takashi Iwai
Quoted 26 lines · Geert Uytterhoeven
Quoted 16 lines · Takashi Iwai
Quoted 6 lines · Geert Uytterhoeven
Quoted 5 lines · Takashi Iwai

index ee2e69a9ecd1..41eda578d08e 100644

sound/Kconfig +0 -0
@@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
 
Quoted 7 lines

sound/Kconfig config SOUND_OSS_CORE_PRECLAIM · line 58

Quoted 5 lines
sound/Kconfig +2 -1
          If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+### TO-BE-REMOVED
+# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

Quoted 3 lines

These belong to the latter, "dead old and inactive" ones :)

Are these driver still used with the latest kernel? If users are

I believe so.

Quoted 1 line

willing to help, we can provide the port to ALSA drivers, too.

That would be great, thanks!

Quoted 7 lines
Quoted 5 lines

OK, we can go forward, then.

But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it?

Because ALSA doesn't have any drivers that can be used on m68k platforms?

But we have virtual and generic drivers (such as UART support), so there seems no reason to stop it. Maybe the lack of proper MMU support was the reason? Let's try to cross-build...

Quoted 4 lines
Quoted 3 lines

And, dmasound is a completely different implementation from the other OSS, thus it doesn't suffer from set_fs() hack. That is, we may still keep dmasound, while removing other OSS stuff.

Quoted 8 lines

That's indeed good to know.

Quoted 4 lines

Meanwhile we'll try to support ALSA on m64k and eventually target to drop dmasound stuff.

Does it sound more feasible?

Yes, definitely in the short run ;-)

OK, below is the revised patch. Now it's a really one-liner.

thanks,

Takashi

-- 8< --
From: Takashi Iwai <[email protected]>
Subject: [PATCH v3] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later.

Note that sound/oss/dmasound is still kept, since it's a completely different implementation of OSS, and it doesn't suffer from set_fs() hack. Moreover, the build of ALSA is disabled on M68K by some reason, thus disabling it shall result in a regression. This one will be disabled / removed once when we add the support in ALSA side.

---

v1->v2: Smaller changes, as Linus and Randy suggested.
The first dmasound Kconfig inclusion is still commented out since it's shorter/simpler in the end.
v2->v3: Keep dmasound, as it's independent from other OSS
implementations.

 sound/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/Kconfig +1 -0
index ee2e69a9ecd1..6a215a8c0490 100644
@@ -115,6 +115,7 @@ endif # SND
 menuconfig SOUND_PRIME
 	tristate "Open Sound System (DEPRECATED)"
 	select SOUND_OSS_CORE
+	depends on BROKEN
 	help
 	  Say 'Y' or 'M' to enable Open Sound System drivers.
 
Signature · 1 line
2.12.2
#13 lore raw

Hi Iwai-san,

Quoted 8 lines · Takashi Iwai
Quoted 5 lines
Quoted 3 lines

But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it?

Because ALSA doesn't have any drivers that can be used on m68k platforms?

But we have virtual and generic drivers (such as UART support), so there seems no reason to stop it. Maybe the lack of proper MMU

It seems to date back to the move of sound from arch/*/Kconfig to sound/Kconfig. I guess at that time there was just no use for ALSO on m68k.

Quoted 1 line

support was the reason? Let's try to cross-build...

Building seems to work fine...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#14 lore raw
Quoted 13 lines · Geert Uytterhoeven

Hi Iwai-san,

Quoted 8 lines · Takashi Iwai
Quoted 5 lines
Quoted 3 lines

But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it?

Because ALSA doesn't have any drivers that can be used on m68k platforms?

But we have virtual and generic drivers (such as UART support), so there seems no reason to stop it. Maybe the lack of proper MMU

Quoted 7 lines

It seems to date back to the move of sound from arch/*/Kconfig to sound/Kconfig. I guess at that time there was just no use for ALSO on m68k.

Quoted 1 line

support was the reason? Let's try to cross-build...

Building seems to work fine...

Worked fine with my cross-build test, too.
OK, let's enable the build on 4.13. The patch is attached below.

thanks,

Takashi

-- 8< --
From: Takashi Iwai <[email protected]>
Subject: [PATCH] ALSA: Enable build with m68k

By some reason in the ancient history, we disabled the build of ALSA drivers for m68k. Since we'd like to move sound/oss/dmasound stuff into ALSA for the complete drop of the legacy OSS stuff, let's try to start building with m68k.

---
 sound/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/Kconfig +2 -2
index ee2e69a9ecd1..6437e398b08e 100644
@@ -56,7 +56,7 @@ config SOUND_OSS_CORE_PRECLAIM
 
 source "sound/oss/dmasound/Kconfig"
 
-if !M68K && !UML
+if !UML
 
 menuconfig SND
 	tristate "Advanced Linux Sound Architecture"
@@ -124,7 +124,7 @@ source "sound/oss/Kconfig"
 
 endif # SOUND_PRIME
 
-endif # !M68K
+endif # !UML
 
 endif # SOUND
 
Signature · 1 line
2.12.2
#15 lore raw
In reply to Takashi Iwai
Quoted 3 lines · Takashi Iwai

But, looking at the tree again, I noticed that ALSA isn't built yet at all for m68k. I don't remember why it's disabled. Jaroslav, do you know the reason behind it?

Might also just be because the m68k port had been dead in Debian for a while due the lack of TLS support in glibc on m68k. However, the port is active again and in pretty good shape now.

I'm currently working on fixing debian-installer on m68k, so that people can install the port without having to resort to things like debootstrap.

Quoted 3 lines

And, dmasound is a completely different implementation from the other OSS, thus it doesn't suffer from set_fs() hack. That is, we may still keep dmasound, while removing other OSS stuff.

Thanks! Highly appreciated.

Quoted 2 lines

Meanwhile we'll try to support ALSA on m64k and eventually target to drop dmasound stuff.

Ooooh, that would be awesome. If you need any testers on m68k, please let us know. I have plenty of m68k hardware for testing.

Quoted 1 line

Does it sound more feasible?

No idea whether it's feasible. But it sounds awesome :).

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
#16 lore raw
In reply to Takashi Iwai

Hi,

Quoted 5 lines · Takashi Iwai
Quoted 3 lines · Christoph Hellwig

Ho Jaroslav, hi Takashi,

Quoted 8 lines
Quoted 4 lines

do you know who still uses the sound/oss drivers and why? I've recently been looking into getting rid of set_fs for using copy_{from,to}_user and friends on kernel pointers, and the sound code is a big abuser, both ALSA and the legacy OSS code.

Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest.

Eventually, I'm also working for it[1]. I'm willing to review your changes, so please add me into CC list when you post patches.

Instead, In this development cycle, I'll post my patches for tracepoints for PCM parameter handling and misc refactoring[2]. (I've already done most of the work.)

Quoted 10 lines

But the set_fs() usage in OSS code is hard to get rid of, due to the in-kernel ioctl calls, and I really don't want to touch such dusty codes, either. So I wanted to post the very same question, but you were faster :)

Quoted 4 lines

But looking at the OSS code it's pretty grotty, and also appears to be pretty much unmaintained except for global cleanups. Is there any chance we could look into getting rid of it over the next few merge windows or are there people that rely on it?

Quoted 8 lines

I don't think there are any active users. The only slight concern is that there are a few ancient devices that are supported only by some OSS drivers. But these are over decades, and very unlikely alive.

That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig.

The latter can be done even for 4.12, if Linus doesn't mind.

I think we don't need to care of drivers implemented with Open Sound System. In my understanding, stuffs in 'sound/core/oss/*' give Open Sound System compatibility layer for Open Sound System applications. In short, it gives a way for the applications to use drivers in ALSA by Open Sound System interfaces. Even if this layer is missing, the applications are still available with Open Sound System Proxy Daemon[3] with FUSE/CURE assistances. I believe we can get rid of them without any actual disadvantages.

[1] https://github.com/takaswie/sound/tree/topic/segment-in-pcm
[2] https://github.com/takaswie/sound/tree/topic/trace+refactor
[3] https://github.com/libfuse/osspd

Regards

Takashi Sakamoto

#17 lore raw
Quoted 19 lines · Takashi Sakamoto
Quoted 10 lines

But the set_fs() usage in OSS code is hard to get rid of, due to the in-kernel ioctl calls, and I really don't want to touch such dusty codes, either. So I wanted to post the very same question, but you were faster :)

Quoted 4 lines

But looking at the OSS code it's pretty grotty, and also appears to be pretty much unmaintained except for global cleanups. Is there any chance we could look into getting rid of it over the next few merge windows or are there people that rely on it?

Quoted 8 lines

I don't think there are any active users. The only slight concern is that there are a few ancient devices that are supported only by some OSS drivers. But these are over decades, and very unlikely alive.

That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig.

The latter can be done even for 4.12, if Linus doesn't mind.

Quoted 8 lines

I think we don't need to care of drivers implemented with Open Sound System. In my understanding, stuffs in 'sound/core/oss/*' give Open Sound System compatibility layer for Open Sound System applications. In short, it gives a way for the applications to use drivers in ALSA by Open Sound System interfaces. Even if this layer is missing, the applications are still available with Open Sound System Proxy Daemon[3] with FUSE/CURE assistances. I believe we can get rid of them without any actual disadvantages.

Oops. I misunderstand to have discussion about stuffs in 'sound/core/oss/*', because the compatibility layer also includes abuses of set_fs() and I'm interested in it today...

For stuffs in 'sound/oss', we should certainly have care of points which Iwai-san mentioned. If we get rid of it, we can also apply diet to 'soundcore' module which gives 'sound' class but include some helper functions just for Open Sound System drivers.

Regards

Takashi Sakamoto

#18 lore raw
Quoted 4 lines · Takashi Sakamoto

Oops. I misunderstand to have discussion about stuffs in 'sound/core/oss/*', because the compatibility layer also includes abuses of set_fs() and I'm interested in it today...

Yes, the stuff in sound/core/oss required an intensive surgery to get rid of set_fs(). But this resulted in a good cleanup of the duplicated copy/silence callbacks in the end.

Quoted 4 lines

For stuffs in 'sound/oss', we should certainly have care of points which Iwai-san mentioned. If we get rid of it, we can also apply diet to 'soundcore' module which gives 'sound' class but include some helper functions just for Open Sound System drivers.

Right, that's low-hanging fruits we can take once after confirming the removal of OSS drivers. The soundcore module can be removed and integrated into the ALSA OSS emulation stuff, for example.

thanks,

Takashi