Skip to contentSkip to conversation

ALSA: oxygen: initialize spdif_playback_enable to 0

PATCH In review [email protected] 2 participants 2 messages Dec 21, 2018 – Jan 7, 2019

Subsystems (2)
Sound C-media CMI8788 driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 ALSA: oxygen: initialize spdif_playback_enable to 0

From: Tom Yan <[email protected]>

There's no reason for us to do that while we initialize dac_mute to
1. Also oxygen_init() has been clearing the OXYGEN_SPDIF_OUT_ENABLE bit anyway.

Signed-off-by Tom Yan <[email protected]>
sound/pci/oxygen/oxygen_lib.c +1 -1
index b4ef5804212d..6a743c878415 100644
@@ -373,7 +373,7 @@ static void oxygen_init(struct oxygen *chip)
 	for (i = 0; i < 8; ++i)
 		chip->dac_volume[i] = chip->model.dac_volume_min;
 	chip->dac_mute = 1;
-	chip->spdif_playback_enable = 1;
+	chip->spdif_playback_enable = 0;
 	chip->spdif_bits = OXYGEN_SPDIF_C | OXYGEN_SPDIF_ORIGINAL |
 		(IEC958_AES1_CON_PCM_CODER << OXYGEN_SPDIF_CATEGORY_SHIFT);
 	chip->spdif_pcm_bits = chip->spdif_bits;
Signature · 1 line
2.20.1