Skip to contentSkip to conversation

alsa-kernel: Official ALSA project GIT repository for Linux 2.6 branch, master now at v2.6.27-rc3-74-g027ee62

alsa-cvslog Takashi Iwai 2 participants 2 messages Aug 15, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

At Fri, 15 Aug 2008 12:39:19 +0200 (CEST),

Review static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream) · line 368

Quoted 10 lines · [email protected] wrote:
(quoted diff) +1 -3
@@ -362,10 +363,8 @@ static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream)
 	}
 	if (substream->pcm->device & 2)
 		runtime->hw.info &= ~(SNDRV_PCM_INFO_MMAP|SNDRV_PCM_INFO_MMAP_VALID);
-	if ((err = add_playback_constraints(runtime)) < 0) {
-		kfree(dpcm);
+	if ((err = add_playback_constraints(runtime)) < 0)
 		return err;
-	}

Run checkpatch.pl please...

Takashi

#2 lore raw
Quoted 14 lines · Takashi Iwai

At Fri, 15 Aug 2008 12:39:19 +0200 (CEST),

Review static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream) · line 368

Quoted 10 lines · [email protected] wrote:
(quoted diff) +1 -3
@@ -362,10 +363,8 @@ static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream)
 	}
 	if (substream->pcm->device & 2)
 		runtime->hw.info &= ~(SNDRV_PCM_INFO_MMAP|SNDRV_PCM_INFO_MMAP_VALID);
-	if ((err = add_playback_constraints(runtime)) < 0) {
-		kfree(dpcm);
+	if ((err = add_playback_constraints(runtime)) < 0)
 		return err;
-	}

Run checkpatch.pl please...

The patch conformed to coding style in dummy.c. I commited new patch on top of this patch to remove (almost all) assignments in if conditions..

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.