sound: pcxhr.h replace signed one-bit bitfields
PATCH 1/1 sound: pcxhr.h replace signed one-bit bitfields
The usage and comments make it clear values of 1/0 were intended rather than -1/0
Noticed by sparse:sound/pci/pcxhr/pcxhr.h:100:20: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:101:22: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:102:24: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:103:21: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:104:25: error: dubious one-bit signed bitfield sound/pci/pcxhr/pcxhr.h:105:20: error: dubious one-bit signed bitfield
--- sound/pci/pcxhr/pcxhr.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
sound/pci/pcxhr/pcxhr.h +6 -6
@@ -97,12 +97,12 @@ struct pcxhr_mgr {int capture_chips;int fw_file_set;int firmware_num; - int is_hr_stereo:1; - int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */ - int board_has_analog:1; /* if 0 the board is digital only */ - int board_has_mic:1; /* if 1 the board has microphone input */ - int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */ - int mono_capture:1; /* if 1 the board does mono capture */ + unsigned int is_hr_stereo:1; + unsigned int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */ + unsigned int board_has_analog:1; /* if 0 the board is digital only */ + unsigned int board_has_mic:1; /* if 1 the board has microphone input */ + unsigned int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */ + unsigned int mono_capture:1; /* if 1 the board does mono capture */struct snd_dma_buffer hostport;
Signature · 1 line
1.6.2.rc1.175.g96b8a
At Thu, 19 Feb 2009 11:58:37 -0800,
Quoted 12 lines · Harvey Harrison
The usage and comments make it clear values of 1/0 were intended rather than -1/0
Noticed by sparse:
sound/pci/pcxhr/pcxhr.h:100:20: error: dubious one-bit signed bitfieldsound/pci/pcxhr/pcxhr.h:101:22: error: dubious one-bit signed bitfieldsound/pci/pcxhr/pcxhr.h:102:24: error: dubious one-bit signed bitfieldsound/pci/pcxhr/pcxhr.h:103:21: error: dubious one-bit signed bitfieldsound/pci/pcxhr/pcxhr.h:104:25: error: dubious one-bit signed bitfieldsound/pci/pcxhr/pcxhr.h:105:20: error: dubious one-bit signed bitfield
Quoted 1 line
Signed-off-by Harvey Harrison <[email protected]>
Applied now. Thanks!
Takashi
Quoted 32 lines
--- sound/pci/pcxhr/pcxhr.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)sound/pci/pcxhr/pcxhr.h +6
-6@@ -97,12 +97,12 @@ struct pcxhr_mgr {int capture_chips;int fw_file_set;int firmware_num; - int is_hr_stereo:1; - int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */ - int board_has_analog:1; /* if 0 the board is digital only */ - int board_has_mic:1; /* if 1 the board has microphone input */ - int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */ - int mono_capture:1; /* if 1 the board does mono capture */ + unsigned int is_hr_stereo:1; + unsigned int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */ + unsigned int board_has_analog:1; /* if 0 the board is digital only */ + unsigned int board_has_mic:1; /* if 1 the board has microphone input */ + unsigned int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */ + unsigned int mono_capture:1; /* if 1 the board does mono capture */struct snd_dma_buffer hostport;Signature · 1 line
1.6.2.rc1.175.g96b8a