Skip to contentSkip to conversation

ALSA: echoaudio: re-enable IRQs on failure path

PATCH Applied Dan Carpenter 2 participants 2 messages Jul 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: echoaudio: re-enable IRQs on failure path

This should be spin_unlock_irq() instead of spin_lock().

Fixes 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()")
---
 sound/pci/echoaudio/echoaudio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/echoaudio/echoaudio.c +1 -1
index e81f42811f45..6aeb99aa2414 100644
@@ -721,7 +721,7 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
 	spin_lock_irq(&chip->lock);
 
 	if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
-		spin_unlock(&chip->lock);
+		spin_unlock_irq(&chip->lock);
 		return -EINVAL;
 	}
 
Signature · 1 line
2.27.0
Applied
#1 lore raw
Quoted 5 lines · Dan Carpenter

This should be spin_unlock_irq() instead of spin_lock().

Fixes 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()")

Thanks, applied now.

Takashi