Skip to contentSkip to conversation

Broken DPMS with DisplayPort on CHV (also BYT?)

PATCH Takashi Iwai 4 participants 10 messages Jan 25, 2017 – Jan 31, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

we've got a bug report about the blank monitor on Cherry Trail machines. And, Intel team (Cc'ed) spotted out that this seems triggered by DPMS transition. A patch like below actually fixes the problem.

Of course it doesn't look like a right "fix". Do you guys have any hint for further debugging?

Some more (not alt-) facts:

- The machine we've tested is a Cherry Trail based box with two DisplayPorts. Intel team mentioned that there are other machines suffering from the same problem.

- With some monitors, the screen remains blank during boot and on X. This can be cured after "xset dpms force off" and resume, or reconfiguring via xrandr.

- The issue seems specific to DP connections. When two (identical) monitors are connected, only one monitor goes blank.

- The issue happens only with some monitor models (Dell E-series). Other Dell monitors (e.g. U-series) or other vendors seem working as far as we've tested.

- Intel team mentioned that a similar issue was seen on a Baytrail machine.

- The register value seems passed correctly. The read back after the register write showed the expected value.
Also, spinning more times in DPMS_ON loop didn't help, too.

- The issue is reproduced with the recent kernels (at least 4.9.x)

Any comments / suggestions appreciated.

thanks,

Takashi

drivers/gpu/drm/i915/intel_dp.c +4 -0
@@ -2205,8 +2205,12 @@ void intel_dp_sink_dpms(struct intel_dp
 		return;
 
 	if (mode != DRM_MODE_DPMS_ON) {
+#if 0
 		ret = drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER,
 					 DP_SET_POWER_D3);
+#else
+		ret = 1;
+#endif
 	} else {
 		/*
 		 * When turning on, we need to retry for 1ms to give the sink

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw
Quoted 9 lines · Takashi Iwai

Hi,

we've got a bug report about the blank monitor on Cherry Trail machines. And, Intel team (Cc'ed) spotted out that this seems triggered by DPMS transition. A patch like below actually fixes the problem.

Of course it doesn't look like a right "fix". Do you guys have any hint for further debugging?

Is it some kind of new fangled MST capable monitor? I've noticed that those tend to be super easy to mess up.

Quoted 6 lines

Some more (not alt-) facts:

- The machine we've tested is a Cherry Trail based box with two DisplayPorts. Intel team mentioned that there are other machines suffering from the same problem.

Is it really somehow tied to the machine? I would imagine it should behave exactly the same way no matter what machine you have.

Quoted 7 lines

- With some monitors, the screen remains blank during boot and on X. This can be cured after "xset dpms force off" and resume, or reconfiguring via xrandr.

- The issue seems specific to DP connections. When two (identical) monitors are connected, only one monitor goes blank.

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

Quoted 40 lines

- The issue happens only with some monitor models (Dell E-series). Other Dell monitors (e.g. U-series) or other vendors seem working as far as we've tested.

- Intel team mentioned that a similar issue was seen on a Baytrail machine.

- The register value seems passed correctly. The read back after the register write showed the expected value.
Also, spinning more times in DPMS_ON loop didn't help, too.

- The issue is reproduced with the recent kernels (at least 4.9.x)

Any comments / suggestions appreciated.

thanks,

Takashi

drivers/gpu/drm/i915/intel_dp.c +4 -0
@@ -2205,8 +2205,12 @@ void intel_dp_sink_dpms(struct intel_dp
 		return;
 
 	if (mode != DRM_MODE_DPMS_ON) {
+#if 0
 		ret = drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER,
 					 DP_SET_POWER_D3);
+#else
+		ret = 1;
+#endif
 	} else {
 		/*
 		 * When turning on, we need to retry for 1ms to give the sink

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 9 lines · Ville Syrjälä
Quoted 7 lines · Takashi Iwai

Hi,

we've got a bug report about the blank monitor on Cherry Trail machines. And, Intel team (Cc'ed) spotted out that this seems triggered by DPMS transition. A patch like below actually fixes the problem.

Quoted 5 lines
Quoted 2 lines

Of course it doesn't look like a right "fix". Do you guys have any hint for further debugging?

Is it some kind of new fangled MST capable monitor? I've noticed that those tend to be super easy to mess up.

The monitors are in Dell team. Sridhara, could you give details about the problematic monitors?

Quoted 8 lines
Quoted 5 lines

Some more (not alt-) facts:

- The machine we've tested is a Cherry Trail based box with two DisplayPorts. Intel team mentioned that there are other machines suffering from the same problem.

Is it really somehow tied to the machine? I would imagine it should behave exactly the same way no matter what machine you have.

A good question. Again the question is delegated to Sridhara :)

Quoted 9 lines
Quoted 6 lines

- With some monitors, the screen remains blank during boot and on X. This can be cured after "xset dpms force off" and resume, or reconfiguring via xrandr.

- The issue seems specific to DP connections. When two (identical) monitors are connected, only one monitor goes blank.

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Thanks!

Takashi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Please find My replay.

Thanks

Sridhar

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Thursday, January 26, 2017 7:50 PM
To: Ville Syrjälä <[email protected]>
Cc: intel-gfx <[email protected]>; Michal Marek <[email protected]>; Chen, Angus <[email protected]>; Jeffrey Cheung <[email protected]>; Hsu, Ray <[email protected]>; Venkatanara, Sridhara <[email protected]>
Subject: Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

On Thu, 26 Jan 2017 14:58:55 +0100,

Quoted 20 lines · Ville Syrjälä
Quoted 15 lines · Takashi Iwai

Hi,

we've got a bug report about the blank monitor on Cherry Trail

machines. And, Intel team (Cc'ed) spotted out that this seems

triggered by DPMS transition. A patch like below actually fixes the

problem.

Of course it doesn't look like a right "fix". Do you guys have any

Quoted 7 lines
Quoted 1 line

hint for further debugging?

Is it some kind of new fangled MST capable monitor? I've noticed that

those tend to be super easy to mess up.

The monitors are in Dell team. Sridhara, could you give details about the problematic monitors?

[Sridhar] Monitor types E2316H, E2216H

http://www.dell.com/ed/business/p/dell-e2316h-monitor/pd

Quoted 8 lines
Quoted 7 lines

Some more (not alt-) facts:

- The machine we've tested is a Cherry Trail based box with two

DisplayPorts. Intel team mentioned that there are other machines

Quoted 7 lines
Quoted 1 line

suffering from the same problem.

Is it really somehow tied to the machine? I would imagine it should

behave exactly the same way no matter what machine you have.

A good question. Again the question is delegated to Sridhara :)

[Sridhar] It is tied to the Cherry Trail based box. Not observed with Bay Trail machines.

Quoted 10 lines
Quoted 9 lines

- With some monitors, the screen remains blank during boot and on X.

This can be cured after "xset dpms force off" and resume, or

reconfiguring via xrandr.

- The issue seems specific to DP connections. When two (identical)

Quoted 7 lines
Quoted 1 line

monitors are connected, only one monitor goes blank.

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from

a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Thanks!

Takashi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Takashi Iwai
Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Ville Syrjälä

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Sridhara reported that my backport didn't help, unfortunately.

But it was a backport, so I might have missed something.
To be sure, I'll try to build a kernel from drm-intel-nightly, and let them test again.

thanks,

Takashi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Hi Takashi

How is the test kernel ? Just wonder when Sridhara team can test again.

Regards

Jeffrey

Quoted 1 line
Quoted 1 line
Quoted 1 line

Takashi Iwai <[email protected]> 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 15:19:44 +0100,

Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Ville Syrjälä

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Sridhara reported that my backport didn't help, unfortunately.

But it was a backport, so I might have missed something.
To be sure, I'll try to build a kernel from drm-intel-nightly, and let them test again.

thanks,

Takashi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 4 lines · Jeffrey Cheung

Hi Takashi

How is the test kernel ? Just wonder when Sridhara team can test again.

I already informed it in bugzilla and waiting for the test result...
http://bugzilla.suse.com/show_bug.cgi?id=1019061#c35

It's found in
http://download.opensuse.org/repositories/home:/tiwai:/bnc1019061-3/standard/

Takashi

Quoted 18 lines

Regards

Jeffrey

Quoted 1 line
Quoted 1 line
Quoted 1 line

Takashi Iwai <[email protected]> 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 15:19:44 +0100,

Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Ville Syrjälä

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Sridhara reported that my backport didn't help, unfortunately.

Quoted 9 lines

But it was a backport, so I might have missed something.
To be sure, I'll try to build a kernel from drm-intel-nightly, and let them test again.

thanks,

Takashi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Hi Takashi

Thanks a lot.

---

Hi Sridhara

Can you please try the test kernel ?

Regards

Jeffrey

Quoted 1 line
Quoted 1 line
Quoted 1 line

Takashi Iwai <[email protected]> 2017/1/31 下午 13:49 >>>On Tue, 31 Jan 2017 03:34:23 +0100,

Quoted 4 lines · Jeffrey Cheung

Hi Takashi

How is the test kernel ? Just wonder when Sridhara team can test again.

I already informed it in bugzilla and waiting for the test result...
http://bugzilla.suse.com/show_bug.cgi?id=1019061#c35

It's found in
http://download.opensuse.org/repositories/home:/tiwai:/bnc1019061-3/standard/

Takashi

Quoted 18 lines

Regards

Jeffrey

Quoted 1 line
Quoted 1 line
Quoted 1 line

Takashi Iwai <[email protected]> 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 15:19:44 +0100,

Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Ville Syrjälä

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Sridhara reported that my backport didn't help, unfortunately.

Quoted 9 lines

But it was a backport, so I might have missed something.
To be sure, I'll try to build a kernel from drm-intel-nightly, and let them test again.

thanks,

Takashi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

Hi,

Installed RPM,

Issue still present with Single Dell E- Series monitor (Display doesn't appear ) Issue not observed with Dual Dell E-Series monitor.
Sleep issue not observed.

Thanks
Sridhar

-----Original Message-----
From: Jeffrey Cheung [mailto:[email protected]]
Sent: Tuesday, January 31, 2017 11:39 AM
To: [email protected]
Cc: Venkatanara, Sridhara <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

Hi Takashi

Thanks a lot.

---

Hi Sridhara

Can you please try the test kernel ?

Regards

Jeffrey

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Takashi Iwai <[email protected]> 2017/1/31 下午 13:49 >>>On Tue, 31 Jan 2017 03:34:23 +0100,

Quoted 4 lines · Jeffrey Cheung

Hi Takashi

How is the test kernel ? Just wonder when Sridhara team can test again.

I already informed it in bugzilla and waiting for the test result...
http://bugzilla.suse.com/show_bug.cgi?id=1019061#c35

It's found in
http://download.opensuse.org/repositories/home:/tiwai:/bnc1019061-3/standard/

Takashi

Quoted 19 lines

Regards

Jeffrey

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Takashi Iwai <[email protected]> 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 15:19:44 +0100,

Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Ville Syrjälä

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Sridhara reported that my backport didn't help, unfortunately.

Quoted 9 lines

But it was a backport, so I might have missed something.
To be sure, I'll try to build a kernel from drm-intel-nightly, and let them test again.

thanks,

Takashi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

lRE: Broken DPMS with DisplayPort on CHV (also BYT?)

Ok, look like we have improvement of using the drm-intel-nightly tree kernel.

Hi takashi and ville, any clue of the single dell e type monitor ?

Regards

Jeffrey

Quoted 1 line
Quoted 1 line
Quoted 1 line

<[email protected]> 2017/1/31 下午 15:36 >>>Hi,

Installed RPM,

Issue still present with Single Dell E- Series monitor (Display doesn't appear ) Issue not observed with Dual Dell E-Series monitor.
Sleep issue not observed.

Thanks
Sridhar

-----Original Message-----
From: Jeffrey Cheung [mailto:[email protected]]
Sent: Tuesday, January 31, 2017 11:39 AM
To: [email protected]
Cc: Venkatanara, Sridhara <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

Hi Takashi

Thanks a lot.

---

Hi Sridhara

Can you please try the test kernel ?

Regards

Jeffrey

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Takashi Iwai <[email protected]> 2017/1/31 下午 13:49 >>>On Tue, 31 Jan 2017 03:34:23 +0100,

Quoted 4 lines · Jeffrey Cheung

Hi Takashi

How is the test kernel ? Just wonder when Sridhara team can test again.

I already informed it in bugzilla and waiting for the test result...
http://bugzilla.suse.com/show_bug.cgi?id=1019061#c35

It's found in
http://download.opensuse.org/repositories/home:/tiwai:/bnc1019061-3/standard/

Takashi

Quoted 19 lines

Regards

Jeffrey

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Takashi Iwai <[email protected]> 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 15:19:44 +0100,

Quoted 8 lines · Takashi Iwai
Quoted 3 lines · Ville Syrjälä

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing from a normal DP port on VLV/CHV") ?

No, it's not tested. I'll prepare a test kernel with it.

Sridhara reported that my backport didn't help, unfortunately.

Quoted 9 lines

But it was a backport, so I might have missed something.
To be sure, I'll try to build a kernel from drm-intel-nightly, and let them test again.

thanks,

Takashi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx