Skip to contentSkip to conversation

include/linux/pci.h:2317:13: error: 'pci_pr3_present' defined but not used

PATCH kbuild test robot 2 participants 2 messages Oct 21, 2019 PCI

lore
Share & tools
lore

kbuild test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
head:   bacd861452d2be86a4df341b12e32db7dac8021e
commit: 52525b7a3cf82adec5c6cf0ecbd23ff228badc94 [37/38] PCI: Add a helper to check Power Resource Requirements _PR3 existence
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout 52525b7a3cf82adec5c6cf0ecbd23ff228badc94
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

In file included from arch/sparc/kernel/iommu.c:20:0:

>> include/linux/pci.h:2317:13: error: 'pci_pr3_present' defined but not used [-Werror=unused-function]
    static bool pci_pr3_present(struct pci_dev *pdev) { return false; }
                ^~~~~~~~~~~~~~~

cc1: all warnings being treated as errors

vim +/pci_pr3_present +2317 include/linux/pci.h

2310
2311 void
2312 pci_msi_register_fwnode_provider(struct fwnode_handle *(*fn)(struct device *));
2313 bool pci_pr3_present(struct pci_dev *pdev);
2314 #else
2315 static inline struct irq_domain *
2316 pci_host_bridge_acpi_msi_domain(struct pci_bus *bus) { return NULL; }

> 2317	static bool pci_pr3_present(struct pci_dev *pdev) { return false; }

2318 #endif
2319

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#1 lore raw
Quoted 13 lines · kbuild test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
head:   bacd861452d2be86a4df341b12e32db7dac8021e
commit: 52525b7a3cf82adec5c6cf0ecbd23ff228badc94 [37/38] PCI: Add a helper to check Power Resource Requirements _PR3 existence
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout 52525b7a3cf82adec5c6cf0ecbd23ff228badc94
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64

Quoted 2 lines

If you fix the issue, kindly add following tag

Grr, this was due to missing inline. Fixed in below.

Takashi

-- 8< --
From: Takashi Iwai <[email protected]>
Subject: [PATCH] PCI: Fix missing inline for pci_pr3_present()

The inline prefix was missing in the dummy function pci_pr3_present() definition. Fix it.

Fixes 52525b7a3cf8 ("PCI: Add a helper to check Power Resource Requirements _PR3 existence")
---
 include/linux/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/pci.h +1 -1
index 1d15c5d49cdd..be529d311122 100644
@@ -2314,7 +2314,7 @@ bool pci_pr3_present(struct pci_dev *pdev);
 #else
 static inline struct irq_domain *
 pci_host_bridge_acpi_msi_domain(struct pci_bus *bus) { return NULL; }
-static bool pci_pr3_present(struct pci_dev *pdev) { return false; }
+static inline bool pci_pr3_present(struct pci_dev *pdev) { return false; }
 #endif
 
 #ifdef CONFIG_EEH
Signature · 1 line
2.16.4