perf/core: Require kernel access for page-size samples
PATCH 1/1 perf/core: Require kernel access for page-size samples
PERF_SAMPLE_CODE_PAGE_SIZE and PERF_SAMPLE_DATA_PAGE_SIZE translate a sampled virtual address using the current task's page tables, including kernel mappings. exclude_kernel only filters the execution mode of the sample; it does not establish that the address being translated belongs to userspace.
For example, an unprivileged tracer can put a kernel address in a tracee's saved IP at a syscall-entry stop. A following syscall perf tracepoint still sees user-mode registers and reports the page size at that address. The distinction between unmapped and mapped addresses can disclose the randomized kernel image base even at perf_event_paranoid=2.
Require perf_allow_kernel() for both page-size sample types, as is already done for PERF_SAMPLE_PHYS_ADDR. This applies the existing perf and LSM authorization policy before the event is created, independently of the source or representation of the sampled address. Authorized page-size sampling and events that do not request these translation fields are unchanged.
--- kernel/events/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
kernel/events/core.c +7 -2
@@ -13967,8 +13967,13 @@ SYSCALL_DEFINE5(perf_event_open,return -EINVAL ; } -/* Only privileged users can get physical addresses */ -if ((attr.sample_type &PERF_SAMPLE_PHYS_ADDR )) { +/* +* Address translation can disclose kernel mappings even when the +* sampled registers are from user mode. +*/ +if (attr.sample_type & (PERF_SAMPLE_PHYS_ADDR | +PERF_SAMPLE_DATA_PAGE_SIZE | +PERF_SAMPLE_CODE_PAGE_SIZE )) { err =perf_allow_kernel ();if (err)return err;
base-commit: fd179f8a05be3ccae366b9b96e176b51fbe54aab
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 20 lines
PERF_SAMPLE_CODE_PAGE_SIZEandPERF_SAMPLE_DATA_PAGE_SIZEtranslate a sampled virtual address using the current task's page tables, including kernel mappings.exclude_kernelonly filters the execution mode of the sample; it does not establish that the address being translated belongs to userspace.For example, an unprivileged tracer can put a kernel address in a tracee's saved IP at a syscall-entry stop. A following syscall perf tracepoint still sees user-mode registers and reports the page size at that address. The distinction between unmapped and mapped addresses can disclose the randomized kernel image base even at perf_event_paranoid=2.
Require
perf_allow_kernel()for both page-size sample types, as is already done forPERF_SAMPLE_PHYS_ADDR. This applies the existing perf and LSM authorization policy before the event is created, independently of the source or representation of the sampled address. Authorized page-size sampling and events that do not request these translation fields are unchanged.
Quoted 4 lines
Fixes 8d97e71811aa ("perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE")Fixes 995f088efebe ("perf/core: Add support for PERF_SAMPLE_CODE_PAGE_SIZE")Assisted-by Codex:gpt-6-astraSigned-off-by Kyle Zeng <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1