Skip to contentSkip to conversation

Remove Headphone MIC support

PATCH Kailang 3 participants 3 messages Nov 12 Sound

lore
Share & tools
lore

Kailang

author
#0 lore raw

Hi Takashi,

Dell QC DT unit don't support Headphone MIC. This patch was changed model to NO Headphone MIC model. This modify also fixed headphone popping noise issue. Many Thanks.

BR,
Kailang

From 8e18d4f8ae308c6556e8cd11de0b9b79f6cfb194 Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Thu, 12 Nov 2026 15:32:16 +0800
Subject: [PATCH] ALSA: hda/realtek - remove headphone MIC support for Dell Pro QC1255

This unit don't support headphone MIC.
The popping sound will disappear when you remove it.

Fixes 97272a5704bf ("ALSA: hda/realtek - Fixed Headphone noise issue for Dell QCM1255")
sound/hda/codecs/realtek/alc269.c +6 -13
index a756e0076021..56c8e9e82b7e 100644
@@ -4542,7 +4542,6 @@ enum {
 	ALC256_FIXUP_HONOR_DRA_XX_HEADSET_MODE,
 	ALC245_FIXUP_HP_ENVY_X360_15_FH0XXX,
 	ALC287_FIXUP_ACER_MICMUTE_LED,
-	ALC236_FIXUP_DELL_HP_POP_NOISE,
 	ALC274_FIXUP_HP_89E9_GPIO,
 	ALC274_FIXUP_HP_VERBS,
 	ALC287_FIXUP_AW88399_I2C_2,
@@ -7408,12 +7407,6 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC2XX_FIXUP_HEADSET_MIC,
 	},
-	[ALC236_FIXUP_DELL_HP_POP_NOISE] = {
-		.type = HDA_FIXUP_FUNC,
-		.v.func = alc285_fixup_invalidate_dacs,
-		.chained = true,
-		.chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE
-	},
 	[ALC274_FIXUP_HP_89E9_GPIO] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc274_fixup_hp_89e9_amp,
@@ -7652,12 +7645,12 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x0cc3, "Dell Oasis 14 Low Weight MTL-U", ALC289_FIXUP_DELL_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1028, 0x0cc4, "Dell Oasis 16 MTL-H/U", ALC289_FIXUP_DELL_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1028, 0x0cc5, "Dell Oasis 14", ALC289_FIXUP_RTK_AMP_DUAL_SPK),
-	SND_PCI_QUIRK(0x1028, 0x0d56, "Dell Pro Tower QCT1255", ALC236_FIXUP_DELL_HP_POP_NOISE),
-	SND_PCI_QUIRK(0x1028, 0x0d58, "Dell Pro Micro QCM1255", ALC236_FIXUP_DELL_HP_POP_NOISE),
-	SND_PCI_QUIRK(0x1028, 0x0d5a, "Dell Pro Slim QCS1255", ALC236_FIXUP_DELL_HP_POP_NOISE),
-	SND_PCI_QUIRK(0x1028, 0x0e6b, "Dell Pro Tower QCT1255", ALC236_FIXUP_DELL_HP_POP_NOISE),
-	SND_PCI_QUIRK(0x1028, 0x0e6c, "Dell Pro Slim QCS1255", ALC236_FIXUP_DELL_HP_POP_NOISE),
-	SND_PCI_QUIRK(0x1028, 0x0e6d, "Dell Pro Micro QCM1255", ALC236_FIXUP_DELL_HP_POP_NOISE),
+	SND_PCI_QUIRK(0x1028, 0x0d56, "Dell Pro Tower QCT1255", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1028, 0x0d58, "Dell Pro Micro QCM1255", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1028, 0x0d5a, "Dell Pro Slim QCS1255", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1028, 0x0e6b, "Dell Pro Tower QCT1255", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1028, 0x0e6c, "Dell Pro Slim QCS1255", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1028, 0x0e6d, "Dell Pro Micro QCM1255", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] ALSA: hda/realtek: missing subject prefix and email text in commit log --

Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] ALSA: hda/realtek: missing subject prefix and email text in commit log
--

commit 5825158cd0bc2543d8e2f6371d06ebd4d7af6e08
Author: Kailang <[email protected]>

Quoted 9 lines

Remove Headphone MIC support

Hi Takashi,

Dell QC DT unit don't support Headphone MIC. This patch was changed model to NO Headphone MIC model. This modify also fixed headphone popping noise issue. Many Thanks.

Quoted 8 lines

BR,
Kailang

This unit don't support headphone MIC.
The popping sound will disappear when you remove it.

Fixes 97272a5704bf ("ALSA: hda/realtek - Fixed Headphone noise issue for Dell QCM1255")

[Severity: Low]
This isn't a bug, but could the commit metadata and message be cleaned up?

The subject line is missing the "ALSA: hda/realtek:" subsystem prefix and does not identify the affected Dell Pro QC1255 machines. The changelog also retains email greeting and sign-off text ("Hi Takashi, ... Many Thanks. BR, Kailang") that belongs below the "---" separator, followed by a duplicate paragraph repeating the explanation. Finally, the Author header uses a single name ("Kailang <[email protected]>") rather than the full name in the Signed-off-by trailer ("Kailang Yang <[email protected]>").

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw
In reply to Kailang
Quoted 6 lines · Kailang

Hi Takashi,

Dell QC DT unit don't support Headphone MIC. This patch was changed model to NO Headphone MIC model. This modify also fixed headphone popping noise issue.

Applied now. Thanks.

Takashi