arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA
Subsystems (6)
v5 cover arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA
Hi Krzysztof, hi Srini, hi all,
v5 of the series, collecting the tags received on v4 and adding the
Cc: stable that Srini requested:
Changes since v4:
- dt-bindings patch 1/3: collected Krzysztof's Acked-by.
- soundwire patch 3/3: added Cc: [email protected] (as requested for stable backporting given the Fixes: tags) and collected Srini's Reviewed-by. No code changes in this patch.
- patch 2/3 is unchanged.
- The series is rebased onto v7.4-rc2. Patch 3/3 is functionally identical to v4 (verified hunk-for-hunk); only its diff context shifted, from the treewide devm_kmalloc_obj conversion that landed in v7.4-rc2 for drivers/soundwire/qcom.c.
Series:
[1/3] dt-bindings: arm: qcom: document Asus Vivobook 16 X1607QA [2/3] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA [3/3] soundwire: qcom: check clk_prepare_enable() return values
Best regards,
Daniel Carter
PATCH v5 1/3 dt-bindings: arm: qcom: document Asus Vivobook 16 X1607QA
Document the compatible for the Asus Vivobook 16 X1607QA laptop, based on the Qualcomm X1P42100 (Purwa) SoC.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1306,6 +1306,7 @@ properties: - items: - enum: + - asus,vivobook-16-x1607qa - asus,vivobook-s15-x1p4 - hp,omnibook-x14-fe1 - lenovo,thinkbook-16
Signature · 1 line
2.55.0
PATCH v5 2/3 arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA
The Asus Vivobook 16 X1607QA is a 16-inch laptop based on the Qualcomm X1P-42-100 (Purwa) SoC, an 8-core derivative of the X1E80100 (hamoa) platform. Its board design is close to the Vivobook S 15 (X1P42100), so the device tree builds on the shared x1-asus-vivobook-s15.dtsi.
Supported so far:
- the 2x WSA8845 speaker and WCD9385 headset codec audio stack over SoundWire, including the VA macro DMIC input
- the ADSP and CDSP remote processors with the ASUS firmware paths
- the Adreno GPU with the zapped shader firmware
The pmc8380_6 PMIC (and its thermal and die-temp nodes) belongs to the third CPU cluster, which is unpopulated on this 8-core part; its nodes are deleted as on the Vivobook S 15.
--- arch/arm64/boot/dts/qcom/Makefile | 2 + .../x1p42100-asus-vivobook-16-x1607qa.dts | 232 ++++++++++++++++++ 2 files changed, 234 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts
arch/arm64/boot/dts/qcom/Makefile +2 -0
@@ -507,6 +507,8 @@ x1e80100-microsoft-romulus15-el2-dtbs := x1e80100-microsoft-romulus15.dtb x1-el2 dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus15.dtb x1e80100-microsoft-romulus15-el2.dtb x1e80100-qcp-el2-dtbs := x1e80100-qcp.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e80100-qcp.dtb x1e80100-qcp-el2.dtb +x1p42100-asus-vivobook-16-x1607qa-el2-dtbs := x1p42100-asus-vivobook-16-x1607qa.dtb x1-el2.dtbo +dtb-$(CONFIG_ARCH_QCOM) += x1p42100-asus-vivobook-16-x1607qa.dtb x1p42100-asus-vivobook-16-x1607qa-el2.dtb x1p42100-asus-vivobook-s15-el2-dtbs := x1p42100-asus-vivobook-s15.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1p42100-asus-vivobook-s15.dtb x1p42100-asus-vivobook-s15-el2.dtb x1p42100-asus-zenbook-a14-el2-dtbs := x1p42100-asus-zenbook-a14.dtb x1-el2.dtbo
arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts new file +232 -0
232 lines not on this page · raw message
Signature · 1 line
2.55.0
PATCH v5 3/3 soundwire: qcom: check clk_prepare_enable() return values
clk_prepare_enable() can fail; unchecked, the driver proceeds to touch registers with the interface clock off, which aborts on arm64. Check the return value in the interrupt handler (returning IRQ_NONE, as the interrupt status is not read or cleared on that path), in probe, and in the runtime resume path (returning the error without unmasking the level-high wake IRQ, which would storm while the slave keeps driving the line).
--- drivers/soundwire/qcom.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
drivers/soundwire/qcom.c +11 -3
@@ -778,7 +778,9 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)u32 i;int devnum;int ret =IRQ_HANDLED ; -clk_prepare_enable (ctrl->hclk); + +if (clk_prepare_enable (ctrl->hclk)) +return IRQ_NONE ; ctrl->reg_read (ctrl, ctrl->reg_layout[SWRM_REG_INTERRUPT_STATUS ], &intr_sts);
@@ -1675,7 +1677,11 @@ static int qcom_swrm_probe(struct platform_device *pdev) goto err_init; } -clk_prepare_enable (ctrl->hclk); + ret =clk_prepare_enable (ctrl->hclk); +if (ret) { +dev_err (dev,"unable to enable iface clock\n" ); + goto err_init; + } ctrl->dev = dev;dev_set_drvdata (&pdev->dev, ctrl);
@@ -1800,7 +1806,9 @@ static int __maybe_unused swrm_runtime_resume(struct device *dev)disable_irq_nosync (ctrl->wake_irq); } -clk_prepare_enable (ctrl->hclk); + ret =clk_prepare_enable (ctrl->hclk); +if (ret) +return ret;if (ctrl->clock_stop_not_supported) {reinit_completion (&ctrl->enumeration);
Signature · 1 line
2.55.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] arm64: dts: qcom: x1607qa inherits 15.6-inch s15 eDP panel node --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Medium] arm64: dts: qcom: x1607qa inherits 15.6-inch s15 eDP panel node
--
commit c3f535b7ac6cd47469ae3b65340861de92f7a5bb
Author: Daniel Carter <[email protected]>
arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA
This commit adds the device tree for the 16-inch Asus Vivobook 16 X1607QA laptop based on the Qualcomm X1P-42-100 SoC, building on x1-asus-vivobook-s15.dtsi.
Quoted 6 lines
arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts new file +0
-0
arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts line 9
Quoted 9 lines
arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-16-x1607qa.dts new file +9
-0@@ -0,0 +1,232 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2026, Daniel Carter <[email protected]> + */ + +/dts-v1/; + +#include "purwa.dtsi" +#include "x1-asus-vivobook-s15.dtsi"
[Severity: Medium]
Should the eDP panel node under mdss_dp3 be overridden for the 16-inch Vivobook 16 X1607QA?
x1-asus-vivobook-s15.dtsi defines the panel for the 15.6-inch Vivobook S 15:
arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi:mdss_dp3 {
...
aux-bus {
panel {
compatible = "samsung,atna56ac03", "samsung,atna33xc20";
enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
power-supply = <&vreg_edp_3p3>;
...
}Without overriding this node, the 16-inch X1607QA inherits the 15.6-inch (2880x1620, 16:9) Samsung ATNA56AC03 AMOLED panel description and binds the atna33xc20 driver, which enforces Samsung AMOLED power-cycling delays and DP AUX backlight control rather than matching the 16-inch panel on this laptop.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2