add i2c adapter id for the cx88 driver.

PATCH In review Gerd Knorr 2 participants 3 messages Jan 25, 2005 1 message not in the archive Media (V4L/DVB)

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Gerd Knorr

author

2005-01-25 10:25 UTC #1 lore raw

PATCH 1/1 add i2c adapter id for the cx88 driver.

Hi,

$subject says all. Please apply,

Gerd

include/linux/i2c-id.h +1 -0

Index: linux-2.6.11-rc2/include/linux/i2c-id.h
===================================================================
@@ -239,6 +239,7 @@
 #define I2C_HW_B_IXP4XX 0x17	/* GPIO on IXP4XX systems		*/
 #define I2C_HW_B_S3VIA	0x18	/* S3Via ProSavage adapter		*/
 #define I2C_HW_B_ZR36067 0x19	/* Zoran-36057/36067 based boards	*/
+#define I2C_HW_B_CX2388x 0x1a	/* connexant 2388x based tv cards	*/
 
 /* --- PCF 8584 based algorithms					*/
 #define I2C_HW_P_LP	0x00	/* Parallel port interface		*/

drivers/media/video/cx88/cx88-i2c.c +1 -1

Index: linux-2.6.11-rc2/drivers/media/video/cx88/cx88-i2c.c
===================================================================
@@ -135,7 +135,7 @@ static struct i2c_algo_bit_data cx8800_i
 static struct i2c_adapter cx8800_i2c_adap_template = {
 	I2C_DEVNAME("cx2388x"),
 	.owner             = THIS_MODULE,
-	.id                = I2C_HW_B_BT848,
+	.id                = I2C_HW_B_CX2388x,
 	.client_register   = attach_inform,
 	.client_unregister = detach_inform,
 };

Jean Delvare

2005-01-25 10:43 UTC #2 lore raw

Hallo Gerd,

Quoted 1 line

+#define I2C_HW_B_CX2388x 0x1a /* connexant 2388x based tv cards */

0x1a is reserved for TI PCILynx in the i2c project, although I never took the time to forward the update to the kernel trees. Could you please use 0x1b instead?

Other than that I am fine with the patch ;)

Thanks,
--
Jean Delvare

Gerd Knorr

author

2005-01-25 11:09 UTC #3 lore raw

Quoted 3 lines

0x1a is reserved for TI PCILynx in the i2c project, although I never took the time to forward the update to the kernel trees. Could you please use 0x1b instead?

Ok, here is a new version of the patch, using 0x1b.

Gerd

include/linux/i2c-id.h +1 -0

Index: linux-2005-01-23/include/linux/i2c-id.h
===================================================================
@@ -239,6 +239,7 @@
 #define I2C_HW_B_IXP4XX 0x17	/* GPIO on IXP4XX systems		*/
 #define I2C_HW_B_S3VIA	0x18	/* S3Via ProSavage adapter		*/
 #define I2C_HW_B_ZR36067 0x19	/* Zoran-36057/36067 based boards	*/
+#define I2C_HW_B_CX2388x 0x1b	/* connexant 2388x based tv cards	*/
 
 /* --- PCF 8584 based algorithms					*/
 #define I2C_HW_P_LP	0x00	/* Parallel port interface		*/

drivers/media/video/cx88/cx88-i2c.c +1 -1

Index: linux-2005-01-23/drivers/media/video/cx88/cx88-i2c.c
===================================================================
@@ -134,7 +134,7 @@ static struct i2c_algo_bit_data cx8800_i
 static struct i2c_adapter cx8800_i2c_adap_template = {
 	I2C_DEVNAME("cx2388x"),
 	.owner             = THIS_MODULE,
-	.id                = I2C_HW_B_BT848,
+	.id                = I2C_HW_B_CX2388x,
 	.client_register   = attach_inform,
 	.client_unregister = detach_inform,
 };