I2C: Fix breakage in m41t00 i2c rtc driver

PATCH New Mark A. Greer 3 participants 6 messages May 19, 2005

lore

Share & tools

lore

Mark A. Greer

author

2005-05-19 06:25 UTC #0 lore raw

PATCH 1/1 I2C: Fix breakage in m41t00 i2c rtc driver

Remove setting of deleted i2c_client structure member.

The latest include/linux/i2c.h:i2c_client structure no longer has an 'id' member. This patch removes the setting of that no longer existing member.

Please apply.

Signed-off-by Mark A. Greer <[email protected]>

--
-------------- next part --------------

drivers/i2c/chips/m41t00.c +0 -1

diff -Nru a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c
@@ -184,7 +184,6 @@
 
 	memset(client, 0, sizeof(struct i2c_client));
 	strncpy(client->name, M41T00_DRV_NAME, I2C_NAME_SIZE);
-	client->id = m41t00_driver.id;
 	client->flags = I2C_DF_NOTIFY;
 	client->addr = addr;
 	client->adapter = adap;

Mark A. Greer

author

2005-05-19 06:25 UTC #1 lore raw

PATCH 1/1 I2C: Fix breakage in m41t00 i2c rtc driver

Quoted 12 lines · Jean Delvare

Hi Mark,
Quoted 7 lines
Remove setting of deleted i2c_client structure member.
The latest include/linux/i2c.h:i2c_client structure no longer has an 'id' member. This patch removes the setting of that no longer existing member.

Quoted 9 lines

Oops. I tried to catch all new drivers using it because I knew it was soon to be removed, but obviously missed this driver. Sorry :( I also tried to compile all drivers to catch potential leftovers, but it was on a non-PPC system so my test did not include your driver.
Sorry again, and thanks for the update. Greg, please apply and push to Linus soon.

Hey, no problem, Jean. It wasn't a big deal.

Take it easy,

Mark

Jean Delvare

2005-05-19 06:25 UTC #2 lore raw

PATCH 1/1 I2C: Fix breakage in m41t00 i2c rtc driver

In reply to Mark A. Greer

Hi Mark,

Quoted 5 lines

Remove setting of deleted i2c_client structure member.
The latest include/linux/i2c.h:i2c_client structure no longer has an 'id' member. This patch removes the setting of that no longer existing member.

Oops. I tried to catch all new drivers using it because I knew it was soon to be removed, but obviously missed this driver. Sorry :( I also tried to compile all drivers to catch potential leftovers, but it was on a non-PPC system so my test did not include your driver.

Sorry again, and thanks for the update. Greg, please apply and push to Linus soon.

Thanks,
--
Jean Delvare

Greg KH

2005-05-19 06:25 UTC #3 lore raw

PATCH 1/1 I2C: Fix breakage in m41t00 i2c rtc driver

In reply to Mark A. Greer

Quoted 27 lines · Mark A. Greer

Quoted 17 lines · Jean Delvare
Hi Mark,
Quoted 7 lines
Remove setting of deleted i2c_client structure member.
The latest include/linux/i2c.h:i2c_client structure no longer has an 'id' member. This patch removes the setting of that no longer existing member.
Oops. I tried to catch all new drivers using it because I knew it was soon to be removed, but obviously missed this driver. Sorry :( I also tried to compile all drivers to catch potential leftovers, but it was on a non-PPC system so my test did not include your driver.
Quoted 7 lines
Sorry again, and thanks for the update. Greg, please apply and push to Linus soon.
Thanks,
--
Jean Delvare

Quoted 5 lines

Greg,
Can we get this pushed? It won't build as it is now...
Patch: http://archives.andrew.net.au/lm-sensors/msg29870.html

It's in my queue, had a lot of "real work" to do these past few days, should get to this later tonight.

Sorry for the delay...

greg k-h

Greg KH

Applied

2005-05-19 06:25 UTC #4 lore raw

PATCH 1/1 I2C: Fix breakage in m41t00 i2c rtc driver

In reply to Mark A. Greer

Quoted 9 lines · Mark A. Greer

Remove setting of deleted i2c_client structure member.
The latest include/linux/i2c.h:i2c_client structure no longer has an 'id' member. This patch removes the setting of that no longer existing member.
Please apply.
Signed-off-by Mark A. Greer <[email protected]>

Applied, thanks.

greg k-h

Mark A. Greer

author

2005-05-19 06:25 UTC #5 lore raw

PATCH 1/1 I2C: Fix breakage in m41t00 i2c rtc driver

In reply to Mark A. Greer

Quoted 17 lines · Jean Delvare

Hi Mark,
Quoted 7 lines
Remove setting of deleted i2c_client structure member.
The latest include/linux/i2c.h:i2c_client structure no longer has an 'id' member. This patch removes the setting of that no longer existing member.
Oops. I tried to catch all new drivers using it because I knew it was soon to be removed, but obviously missed this driver. Sorry :( I also tried to compile all drivers to catch potential leftovers, but it was on a non-PPC system so my test did not include your driver.

Quoted 7 lines

Sorry again, and thanks for the update. Greg, please apply and push to Linus soon.
Thanks,
--
Jean Delvare

Greg,

Can we get this pushed? It won't build as it is now...

Patch: http://archives.andrew.net.au/lm-sensors/msg29870.html

Thanks,

Mark