hw/misc/ivshmem: clear chardev handlers before freeing peers
PATCH 1/1 hw/misc/ivshmem: clear chardev handlers before freeing peers
From 2a7fa17cd21d0a5c1ddf0f13f5c6b39375052aef Mon Sep 17 00:00:00 2001From: Haotian Jiang <[email protected]>
Date: Mon, 29 Jun 2026 10:50:21 +0800
Subject: [PATCH] hw/misc/ivshmem: clear chardev handlers before freeing peers
ivshmem_exit() frees s->peers and s->msi_vectors but does not clear the chardev handlers registered in ivshmem_common_realize(). Those handlers are only removed later in object_finalize() via release_chr, which runs after ivshmem_exit().
Between exit and finalize, ivshmem_read() can fire on pending chardev data and process_msg_connect() dereferences the freed s->peers. Additionally, s->peers, s->nb_peers, and s->msi_vectors are not zeroed after free, leaving dangling pointers that make the UAF code paths reachable.
Fix by clearing chardev handlers at the beginning of ivshmem_exit(), before any resources they access are freed, and nullifying freed pointers.
---
hw/misc/ivshmem-pci.c | 6 ++++++
1 file changed, 6 insertions(+)
hw/misc/ivshmem-pci.c +0 -0
@@ -938,6 +938,9 @@ static void ivshmem_exit(PCIDevice *dev)
IVShmemState *s = IVSHMEM_COMMON(dev);
int i;
+ qemu_chr_fe_set_handlers(&s->server_chr, NULL, NULL, NULL, NULL,
+ NULL, NULL, true); +
migrate_del_blocker(&s->migration_blocker);
if (memory_region_is_mapped(s->ivshmem_bar2)) {
@@ -966,6 +969,8 @@ static void ivshmem_exit(PCIDevice *dev)
close_peer_eventfds(s, i);
}
g_free(s->peers);
+ s->peers = NULL;
+ s->nb_peers = 0;
}
if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
@@ -973,6 +978,7 @@ static void ivshmem_exit(PCIDevice *dev)
}
g_free(s->msi_vectors);
+ s->msi_vectors = NULL;
}
static int ivshmem_pre_load(void *opaque)
Signature · 1 line
2.34.1
Cc'ing Gustavo
Quoted 57 lines · sundayjiang(èæµ©å¤©)
From
2a7fa17cd21d0a5c1ddf0f13f5c6b39375052aefMon Sep 17 00:00:00 2001From: Haotian Jiang <[email protected]>
Date: Mon, 29 Jun 2026 10:50:21 +0800
Subject: [PATCH] hw/misc/ivshmem: clear chardev handlers before freeing peers
ivshmem_exit()frees s->peers and s->msi_vectors but does not clear the chardev handlers registered inivshmem_common_realize(). Those handlers are only removed later inobject_finalize()viarelease_chr, which runs afterivshmem_exit().Between exit and finalize,
ivshmem_read()can fire on pending chardev data andprocess_msg_connect()dereferences the freed s->peers. Additionally, s->peers, s->nb_peers, and s->msi_vectors are not zeroed after free, leaving dangling pointers that make the UAF code paths reachable.Fix by clearing chardev handlers at the beginning of
ivshmem_exit(), before any resources they access are freed, and nullifying freed pointers.Fixes f64a078d45a ("ivshmem: fix pci_ivshmem_exit()")Reported-by Haotian Jiang <[email protected]>Signed-off-by Haotian Jiang <[email protected]>---
hw/misc/ivshmem-pci.c | 6 ++++++
1 file changed, 6 insertions(+)hw/misc/ivshmem-pci.c +5
-0@@ -938,6 +938,9 @@ static void ivshmem_exit(PCIDevice *dev) IVShmemState *s =IVSHMEM_COMMON (dev); int i; + qemu_chr_fe_set_handlers(&s->server_chr, NULL, NULL, NULL, NULL, + NULL, NULL, true); + migrate_del_blocker(&s->migration_blocker); if (memory_region_is_mapped(s->ivshmem_bar2)) {@@ -966,6 +969,8 @@ static void ivshmem_exit(PCIDevice *dev) close_peer_eventfds (s, i); } g_free(s->peers); + s->peers =NULL ; + s->nb_peers =0 ; } if (ivshmem_has_feature (s,IVSHMEM_MSI )) {
hw/misc/ivshmem-pci.c static void ivshmem_exit(PCIDevice *dev) · line 984
Quoted 7 lines
hw/misc/ivshmem-pci.c +1
-0@@ -973,6 +978,7 @@ static void ivshmem_exit(PCIDevice *dev) } g_free(s->msi_vectors); + s->msi_vectors =NULL ; } static int ivshmem_pre_load (void *opaque)