:Patch "Bluetooth: btusb: Add 0bda:b85b for Fn-Link RTL8852BE" has been added to the 5.10-stable tree

PATCH In review 关文涛 2 participants 7 messages Nov 24, 2023 – Nov 30, 2023 2 messages not in the archive Stable branch

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

关文涛

author

2023-11-24 15:01 UTC #2 lore raw

PATCH v2 1/1 :Patch "Bluetooth: btusb: Add 0bda:b85b for Fn-Link RTL8852BE" has been added to the 5.10-stable tree

Hello Levin:

Apologize for my HTML format past.I discovered that the backport patches also have dependency in 5.10 lts tree:

[1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=75742ffc3630203e95844c72c7144f507e2a557d [2]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=40e2e7f1bf0301d1ed7437b10d9e1c92cb51bf81 [3]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=9c45bb363e26e86ebaf20f6d2009bedf19fc0d39 [4]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=3a292cb18132cb7af3a146613f1c9a47ef6f8463 [5]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=1a2a2e34569cf85cad743ee8095d07c3cba5473b

and update version 2 depend patches link:

[1] RTL8852AE: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d484db60fc0c5f8848939a61004c6fa01fad61a
[2] RTL8852BE: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=18e8055c88142d8f6e23ebdc38c126ec37844e5d
[3] RTL8852CE: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8b1d66b50437b65ef109f32270bd936ca5437a83
[4] FW: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf0d9a705d81a0f581865cefe0880f29589dd06f

----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

I would like to express my gratitude for you efforts,and I want to provide you with the backport tip when kernel <=5.10 :
the RTL8852{A,B,C} BT chip series depend patches in that patch [1](v5.11) and load new firmware need that patch [2](v5.4). Apologize for my pool English.

link:
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d484db60fc0c5f8848939a61004c6fa01fad61a
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf0d9a705d81a0f581865cefe0880f29589dd06f

Greg KH

maintainer

2023-11-24 15:12 UTC #3 lore raw

Quoted 10 lines · 关文涛

Hello Levin:
Apologize for my HTML format past.I discovered that the backport patches also have dependency in 5.10 lts tree:
[1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=75742ffc3630203e95844c72c7144f507e2a557d [2]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=40e2e7f1bf0301d1ed7437b10d9e1c92cb51bf81 [3]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=9c45bb363e26e86ebaf20f6d2009bedf19fc0d39 [4]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=3a292cb18132cb7af3a146613f1c9a47ef6f8463 [5]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.201&id=1a2a2e34569cf85cad743ee8095d07c3cba5473b

Quoted 6 lines

and update version 2 depend patches link:
[1] RTL8852AE: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d484db60fc0c5f8848939a61004c6fa01fad61a
[2] RTL8852BE: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=18e8055c88142d8f6e23ebdc38c126ec37844e5d
[3] RTL8852CE: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8b1d66b50437b65ef109f32270bd936ca5437a83
[4] FW: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf0d9a705d81a0f581865cefe0880f29589dd06f

I'm sorry, but I do not understand what we need to do here.

What git ids need to go to what tree and in what order?

Quoted 3 lines

I would like to express my gratitude for you efforts,and I want to provide you with the backport tip when kernel <=5.10 :
the RTL8852{A,B,C} BT chip series depend patches in that patch [1](v5.11) and load new firmware need that patch [2](v5.4). Apologize for my pool English.

Your english is great, but I really don't understand what is to be done here. Can you just list the ids in the order which you want them applied and to what tree(s)?

thanks,

greg k-h

关文涛

author

2023-11-24 16:57 UTC #4 lore raw

Hello Greg:
I thiink that the most clean thing that backport to v6.1 lts tree,
because it has "Add support for RTL8852B" commit link [1]:

In v5.15 lts tree,it miss patch [1].
In v5.10 lts tree,it miss "Add support for RTL8852A"[2] so "git am"
command not simply work,but without the patch RTL8852B works.
In v5.4 lts tree,it miss more ids,need more efforts to do.If someone
need,need to backport their own pid/vid pairs.
In v4.19 lts tree,it miss patch [3],so firmware download will failed.

For backport patches[4][5][6][7][8],
they miss "Add support for RTL8852C"[9] in v5.15 and v5.10 lts tree. Otherwise,I also found that in v5.10 lts tree path file:
root/drivers/bluetooth/btusb.c
MT7922 id [10] [11] add without its dependency [12] [13] AX210 id [14] add without its dependency [15]
Sorry for maybe I miss some device id.How do other people think the
situation where some BT ids backports are done without dependencies?

Best regards
guan wentao

Greg KH

maintainer

2023-11-30 13:30 UTC #5 lore raw

Quoted 11 lines · 关文涛

Hello Greg:
I thiink that the most clean thing that backport to v6.1 lts tree,
because it has "Add support for RTL8852B" commit link [1]:
In v5.15 lts tree,it miss patch [1].
In v5.10 lts tree,it miss "Add support for RTL8852A"[2] so "git am"
command not simply work,but without the patch RTL8852B works.
In v5.4 lts tree,it miss more ids,need more efforts to do.If someone
need,need to backport their own pid/vid pairs.
In v4.19 lts tree,it miss patch [3],so firmware download will failed.

Quoted 8 lines

For backport patches[4][5][6][7][8],
they miss "Add support for RTL8852C"[9] in v5.15 and v5.10 lts tree. Otherwise,I also found that in v5.10 lts tree path file:
root/drivers/bluetooth/btusb.c
MT7922 id [10] [11] add without its dependency [12] [13] AX210 id [14] add without its dependency [15]
Sorry for maybe I miss some device id.How do other people think the
situation where some BT ids backports are done without dependencies?

Can you provide just a list of git ids, without footnotes or links, as that is a pain to attempt to cut-paste from?

Better yet, can you provide backported patch series of the needed commits like is sent all the time to the stable mailing list (so you can see examples) and we can take them that way? That way you get credit for the backporting and testing as you will have added your signed-off-by to the commits.

thanks,

greg k-h

关文涛

author

2023-11-30 14:19 UTC #6 lore raw

Quoted 2 lines

Can you provide just a list of git ids, without footnotes or links, as that is a pain to attempt to cut-paste from?

Sure,

v5.15 git id list:
18e8055c88142d8f6e23ebdc38c126ec37844e5d
8b1d66b50437b65ef109f32270bd936ca5437a83

v5.10 git id list:
0d484db60fc0c5f8848939a61004c6fa01fad61a
18e8055c88142d8f6e23ebdc38c126ec37844e5d
8b1d66b50437b65ef109f32270bd936ca5437a83

v5.4 git id list:
0d484db60fc0c5f8848939a61004c6fa01fad61a
18e8055c88142d8f6e23ebdc38c126ec37844e5d
8b1d66b50437b65ef109f32270bd936ca5437a83

Best regards

guan wentao

Greg KH

maintainer

2023-11-30 14:26 UTC #7 lore raw

Quoted 13 lines · 关文涛

Quoted 2 lines
Can you provide just a list of git ids, without footnotes or links, as that is a pain to attempt to cut-paste from?
Sure,
v5.15 git id list:
18e8055c88142d8f6e23ebdc38c126ec37844e5d
8b1d66b50437b65ef109f32270bd936ca5437a83
v5.10 git id list:
0d484db60fc0c5f8848939a61004c6fa01fad61a
18e8055c88142d8f6e23ebdc38c126ec37844e5d
8b1d66b50437b65ef109f32270bd936ca5437a83

Quoted 4 lines

v5.4 git id list:
0d484db60fc0c5f8848939a61004c6fa01fad61a
18e8055c88142d8f6e23ebdc38c126ec37844e5d
8b1d66b50437b65ef109f32270bd936ca5437a83

These do not apply cleanly to those kernel trees, can you please provide a working set of backported patches that are fixed up and tested for these branches?

thanks,

greg k-h

关文涛

author

2023-11-30 14:45 UTC #8 lore raw

Quoted 3 lines

These do not apply cleanly to those kernel trees, can you please provide a working set of backported patches that are fixed up and tested for these branches?

Thanks for your kindly reminder.
I will resend patches set to mailing lists after testing.

Best Regards
guan wentao