Skip to contentSkip to conversation

scsi: fix out of bounds error in /drivers/scsi

PATCH Superseded jackysliu 3 participants 10 messages Jun 17, 2025 – Jul 15, 2025 SCSI

lore
Share & tools
lore

jackysliu

author
#0 lore raw

PATCH 1/1 scsi: fix out of bounds error in /drivers/scsi

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c, sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

---
 drivers/scsi/sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sd.c +1 -1
index 3f6e87705b62..eeaa6af294b8 100644
@@ -3384,7 +3384,7 @@ static void sd_read_block_limits_ext(struct scsi_disk *sdkp)
 
 	rcu_read_lock();
 	vpd = rcu_dereference(sdkp->device->vpd_pgb7);
-	if (vpd && vpd->len >= 2)
+	if (vpd && vpd->len >= 6)
 		sdkp->rscs = vpd->data[5] & 1;
 	rcu_read_unlock();
 }
Signature · 1 line
2.43.5
#1 lore raw
Quoted 18 lines · jackysliu

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c, sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

---
  drivers/scsi/sd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sd.c +0 -0
index 3f6e87705b62..eeaa6af294b8 100644

drivers/scsi/sd.c static void sd_read_block_limits_ext(struct scsi_disk *sdkp) · line 3390

Quoted 8 lines
drivers/scsi/sd.c +1 -1
@@ -3384,7 +3384,7 @@ static void sd_read_block_limits_ext(struct scsi_disk *sdkp)
 
  	rcu_read_lock();
  	vpd = rcu_dereference(sdkp->device->vpd_pgb7);
-	if (vpd && vpd->len >= 2)
+	if (vpd && vpd->len >= 6)
  		sdkp->rscs = vpd->data[5] & 1;
  	rcu_read_unlock();
  }
Fixes and Cc: stable tags are missing. Please add these.

How has this been detected? Please mention this in the patch description. When I wrote the above code I was assuming that vpd->len represents the contents of the PAGE LENGTH field (bytes 2 and 3). Apparently vpd->len is the length in bytes of the entire VPD page.

Thanks,

Bart.

author
#2 lore raw
Quoted 26 lines · jackysliu

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c, sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

---
  drivers/scsi/sd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sd.c +1 -1
index 3f6e87705b62..eeaa6af294b8 100644
@@ -3384,7 +3384,7 @@ static void sd_read_block_limits_ext(struct scsi_disk *sdkp)
 
  	rcu_read_lock();
  	vpd = rcu_dereference(sdkp->device->vpd_pgb7);
-	if (vpd && vpd->len >= 2)
+	if (vpd && vpd->len >= 6)
  		sdkp->rscs = vpd->data[5] & 1;
  	rcu_read_unlock();
  }
Quoted 10 lines · Bart Van Assche
Fixes and Cc: stable tags are missing. Please add these.

How has this been detected? Please mention this in the patch description. When I wrote the above code I was assuming that vpd->len represents the contents of the PAGE LENGTH field (bytes 2 and 3). Apparently vpd->len is the length in bytes of the entire VPD page.

Thanks,

Bart.

Sure,I'll explain in the patch later.
Can I know what kind of impact this vulnerability will have? And is it possible to get a cve number?

Thanks,

Jackysliu

#3 lore raw
Quoted 1 line · jackysliu

Can I know what kind of impact this vulnerability will have?

The worst possible impact I see is that the Linux kernel would decide that RSCS is supported although the device doesn't support it. This could cause sd_read_io_hints() to print incorrect information. The
following message could be printed when it should not be printed:
"Unexpected: RSCS has been set and the permanent stream count is %u\n"

Quoted 1 line

And is it possible to get a cve number?

You are asking the wrong person. I don't know how to get a CVE number.

Bart.

author
#4 lore raw
In reply to jackysliu
Quoted 8 lines · Bart Van Assche
Quoted 1 line

Can I know what kind of impact this vulnerability will have?

The worst possible impact I see is that the Linux kernel would decide that RSCS is supported although the device doesn't support it. This could cause sd_read_io_hints() to print incorrect information. The following message could be printed when it should not be printed:
"Unexpected: RSCS has been set and the permanent stream count is %u\n"

Quoted 5 lines
Quoted 1 line

And is it possible to get a cve number?

You are asking the wrong person. I don't know how to get a CVE number.

Bart.

Thank you Bart,for the patient review. I've submitted a new patch which mentioned way of detection and influenced stable tags.
Best regards.

Jackysliu

author
#5 lore raw

PATCH v2 1/1 scsi: fix out of bounds error in /drivers/scsi

In reply to Bart Van Assche

6.15-stable review patch, vulnerability exists since v6.9

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c The vulnerability is found by is found by Wukong-Agent
(formerly Tencent Woodpecker), a code security AI agent, through static code analysis.

sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

A maliciously crafted 4-byte VPD page (0xB7) would cause Out-of-Bounds Memory Read, leading to potential system Instability
and Driver State Corruption.

---
 drivers/scsi/sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sd.c +1 -1
index 3f6e87705b62..eeaa6af294b8 100644
@@ -3384,7 +3384,7 @@ static void sd_read_block_limits_ext(struct scsi_disk *sdkp)
 
 	rcu_read_lock();
 	vpd = rcu_dereference(sdkp->device->vpd_pgb7);
-	if (vpd && vpd->len >= 2)
+	if (vpd && vpd->len >= 6)
 		sdkp->rscs = vpd->data[5] & 1;
 	rcu_read_unlock();
 }
Signature · 1 line
2.43.5
author
#6 lore raw

Re: [PATCH v2] usb: gadget: functioni: Fix a oob problem in rndis

Quoted 2 lines · greg k-h

Yes, and then look to see what buf_len (not buflen) in gen_ndis_set_resp() is used for. I'll wait... :)

Oh,my bad.It seem that buf_len will only be used for some debugging code..

Quoted 2 lines

What tool generated this static analysis? You always have to mention that as per our development rules.

The vulnerability is found by is found by Wukong-Agent, a code security AI agent,
through static code analysis.But It seems that this is a false positive..

And what qemu setup did you use to test this? That would be helpful to know so that I can verify it on my end.

I'll add some web-usb device to test this model.But seems that I went into a wrong way.

Thanks

Siyang Liu

Reviewed-by on v2 1/1
#7 lore raw
In reply to jackysliu
Quoted 14 lines · jackysliu

6.15-stable review patch, vulnerability exists since v6.9

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c The vulnerability is found by is found by Wukong-Agent
(formerly Tencent Woodpecker), a code security AI agent, through static code analysis.

sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

Quoted 3 lines

A maliciously crafted 4-byte VPD page (0xB7) would cause Out-of-Bounds Memory Read, leading to potential system Instability
and Driver State Corruption.

#8 lore raw
Quoted 15 lines · Bart Van Assche
Quoted 14 lines · jackysliu

6.15-stable review patch, vulnerability exists since v6.9

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c The vulnerability is found by is found by Wukong-Agent
(formerly Tencent Woodpecker), a code security AI agent, through static code analysis.

sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

Quoted 5 lines
Quoted 3 lines

A maliciously crafted 4-byte VPD page (0xB7) would cause Out-of-Bounds Memory Read, leading to potential system Instability
and Driver State Corruption.

Just checking - are you sure? Please be careful with this work, that's AI generated stuff which in some cases did not even compile or did not actually follow C code.

Best regards,
Krzysztof

#9 lore raw
Quoted 20 lines · Krzysztof Kozlowski
Quoted 19 lines · Bart Van Assche
Quoted 17 lines · jackysliu

6.15-stable review patch, vulnerability exists since v6.9

Out-of-bounds vulnerability found in ./drivers/scsi/sd.c The vulnerability is found by is found by Wukong-Agent
(formerly Tencent Woodpecker), a code security AI agent, through static code analysis.

sd_read_block_limits_ext Function Due to Unreasonable boundary checks. Out-of-bounds read vulnerability exists in the
Linux kernel's SCSI disk driver (./drivers/scsi/sd.c).
The flaw occurs in the sd_read_block_limits_ext function
when processing Vital Product Data (VPD) page B7 (Block Limits Extension) responses from storage devices

A maliciously crafted 4-byte VPD page (0xB7) would cause Out-of-Bounds Memory Read, leading to potential system Instability
and Driver State Corruption.

Quoted 5 lines
Quoted 1 line

Just checking - are you sure? Please be careful with this work, that's AI generated stuff which in some cases did not even compile or did not actually follow C code.

As one can see here, an in-depth review was performed before I replied with "Reviewed-by":
https://lore.kernel.org/linux-scsi/[email protected]/

Bart.