Skip to contentSkip to conversation

ftrace: remove duplicate newline

PATCH In review Li Zefan 2 participants 3 messages Jun 25, 2009 Tracing

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 ftrace: remove duplicate newline

Before:

  # echo 'sys_open:traceon:' > set_ftrace_filter
  # echo 'sys_close:traceoff:5' > set_ftrace_filter
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited

sys_close:traceoff:count=0

After:

  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited
  sys_close:traceoff:count=0
---
 kernel/trace/trace_functions.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
kernel/trace/trace_functions.c +1 -2
index 90f1347..7402144 100644
@@ -302,8 +302,7 @@ ftrace_trace_onoff_print(struct seq_file *m, unsigned long ip,
 	if (count == -1)
 		seq_printf(m, ":unlimited\n");
 	else
-		seq_printf(m, ":count=%ld", count);
-	seq_putc(m, '\n');
+		seq_printf(m, ":count=%ld\n", count);
 
 	return 0;
 }
Signature · 1 line
1.5.4.rc3
#1 lore raw

[tip:tracing/urgent] ftrace: Remove duplicate newline

Commit-ID:  00e54d087afb3867b0b461aef6c1ff433d0df564
Gitweb:     http://git.kernel.org/tip/00e54d087afb3867b0b461aef6c1ff433d0df564
Author:     Li Zefan <[email protected]>
AuthorDate: Thu, 25 Jun 2009 14:05:27 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 25 Jun 2009 10:28:36 +0200

ftrace: Remove duplicate newline

Before:

  # echo 'sys_open:traceon:' > set_ftrace_filter
  # echo 'sys_close:traceoff:5' > set_ftrace_filter
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited

sys_close:traceoff:count=0

After:

  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited
  sys_close:traceoff:count=0
Cc Steven Rostedt <[email protected]>
Cc Frederic Weisbecker <[email protected]>

LKML-Reference: <[email protected]>

---
 kernel/trace/trace_functions.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
kernel/trace/trace_functions.c +1 -2
index 90f1347..7402144 100644
@@ -302,8 +302,7 @@ ftrace_trace_onoff_print(struct seq_file *m, unsigned long ip,
 	if (count == -1)
 		seq_printf(m, ":unlimited\n");
 	else
-		seq_printf(m, ":count=%ld", count);
-	seq_putc(m, '\n');
+		seq_printf(m, ":count=%ld\n", count);
 
 	return 0;
 }
maintainer Acked-by
#2 lore raw

Re: [tip:tracing/urgent] ftrace: Remove duplicate newline

Quoted 18 lines · tip-bot for Li Zefan
Commit-ID:  00e54d087afb3867b0b461aef6c1ff433d0df564
Gitweb:     http://git.kernel.org/tip/00e54d087afb3867b0b461aef6c1ff433d0df564
Author:     Li Zefan <[email protected]>
AuthorDate: Thu, 25 Jun 2009 14:05:27 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 25 Jun 2009 10:28:36 +0200

ftrace: Remove duplicate newline

Before:

  # echo 'sys_open:traceon:' > set_ftrace_filter
  # echo 'sys_close:traceoff:5' > set_ftrace_filter
  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited

sys_close:traceoff:count=0

Quoted 8 lines

After:

  # cat set_ftrace_filter
  #### all functions enabled ####
  sys_open:traceon:unlimited
  sys_close:traceoff:count=0
Cc Steven Rostedt <[email protected]>

Thanks!

-- Steve

Quoted 24 lines

Cc: Frederic Weisbecker <[email protected]>
LKML-Reference: <[email protected]>

---
 kernel/trace/trace_functions.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
kernel/trace/trace_functions.c +1 -2
index 90f1347..7402144 100644
@@ -302,8 +302,7 @@ ftrace_trace_onoff_print(struct seq_file *m, unsigned long ip,
 	if (count == -1)
 		seq_printf(m, ":unlimited\n");
 	else
-		seq_printf(m, ":count=%ld", count);
-	seq_putc(m, '\n');
+		seq_printf(m, ":count=%ld\n", count);
 
 	return 0;
 }