futex: no need to check return value of debugfs_create functions
PATCH 1/1 futex: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- kernel/futex.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
kernel/futex.c +2 -6
@@ -321,12 +321,8 @@ static int __init fail_futex_debugfs(void)if (IS_ERR (dir))return PTR_ERR (dir); -if (!debugfs_create_bool ("ignore-private" , mode, dir, - &fail_futex.ignore_private)) { -debugfs_remove_recursive (dir); -return -ENOMEM ; - } - +debugfs_create_bool ("ignore-private" , mode, dir, + &fail_futex.ignore_private);return 0 ; }
Signature · 1 line
2.20.1
Quoted 9 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Darren Hart <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
As documented, and futexes can't be modules, so no need to check for the dentry.
Quoted 27 lines
--- kernel/futex.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)kernel/futex.c +2
-6@@ -321,12 +321,8 @@ static int __init fail_futex_debugfs(void)if (IS_ERR (dir))return PTR_ERR (dir); -if (!debugfs_create_bool ("ignore-private" , mode, dir, - &fail_futex.ignore_private)) { -debugfs_remove_recursive (dir); -return -ENOMEM ; - } - +debugfs_create_bool ("ignore-private" , mode, dir, + &fail_futex.ignore_private);return 0 ; }Signature · 1 line
2.20.1
Signature · 2 lines
Darren Hart VMware Open Source Technology Center
tip-bot for Greg Kroah-Hartman
merge bot[tip:locking/core] futex: No need to check return value of debugfs_create functions
In reply to Greg Kroah-Hartmanfutex: No need to check return value of debugfs_create functions
Commit-ID: 0365aeba50841e087b3d6a0eca1bddccc5e650c8 Gitweb: https://git.kernel.org/tip/0365aeba50841e087b3d6a0eca1bddccc5e650c8 Author: Greg Kroah-Hartman <[email protected]> AuthorDate: Tue, 22 Jan 2019 16:21:39 +0100 Committer: Thomas Gleixner <[email protected]> CommitDate: Tue, 29 Jan 2019 20:15:48 +0100
futex: No need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- kernel/futex.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
kernel/futex.c +2 -6
@@ -321,12 +321,8 @@ static int __init fail_futex_debugfs(void)if (IS_ERR (dir))return PTR_ERR (dir); -if (!debugfs_create_bool ("ignore-private" , mode, dir, - &fail_futex.ignore_private)) { -debugfs_remove_recursive (dir); -return -ENOMEM ; - } - +debugfs_create_bool ("ignore-private" , mode, dir, + &fail_futex.ignore_private);return 0 ; }