perf script: Use thread__find_symbol() instead of ad-hoc equivalent
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: cc5f02f2be8d3354986bad5703ee8a983872f140 Gitweb: https://git.kernel.org/tip/cc5f02f2be8d3354986bad5703ee8a983872f140 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Tue, 24 Apr 2018 11:32:30 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 26 Apr 2018 13:47:08 -0300
perf script: Use thread__find_symbol() instead of ad-hoc equivalent
In dc323ce8e72d ("perf script: Enable printing of branch stack") it first tries to find the map for an address, then the symbol in the DSO backing that map, for that address, well, this is what thread__find_symbol() does, so just use it and make the code shorter.
Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-script.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
tools/perf/builtin-script.c +2 -7
@@ -764,13 +764,8 @@ static int perf_sample__fprintf_brstacksym(struct perf_sample *sample, from = br->entries[i].from; to = br->entries[i].to; -thread__find_map (thread, sample->cpumode, from, &alf); -if (alf.map) - alf.sym =map__find_symbol (alf.map, alf.addr); - -thread__find_map (thread, sample->cpumode, to, &alt); -if (alt.map) - alt.sym =map__find_symbol (alt.map, alt.addr); +thread__find_symbol (thread, sample->cpumode, from, &alf); +thread__find_symbol (thread, sample->cpumode, to, &alt); printed +=symbol__fprintf_symname_offs (alf.sym, &alf, fp);if (PRINT_FIELD (DSO )) {