tip-queue 2015-12-10
Subsystems (2)
Borislav Petkov
maintainerPATCH 1/1 tip-queue 2015-12-10
From: Borislav Petkov <[email protected]>
Hi,
just one for tip-urgent today.
It is taking care of the case where CPUs are offlined and an #MC happens. Fix is purposefully kept minimal for stable@. More involved dealing with the whole issue is going to follow.
Thanks.
Ashok Raj (1):
x86/mce: Ensure offline CPUs don't participate in rendezvous process
arch/x86/kernel/cpu/mcheck/mce.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
Signature · 1 line
2.3.5
Borislav Petkov
maintainerPATCH 1/1 x86/mce: Ensure offline CPUs don't participate in rendezvous process
From: Ashok Raj <[email protected]>
Intel's MCA implementation broadcasts MCEs to all CPUs on the node. This poses a problem for offlined CPUs which cannot participate in the rendezvous process:
Kernel panic - not syncing: Timeout: Not all CPUs entered broadcast exception handler Kernel Offset: disabled Rebooting in 100 seconds..
More specifically, Linux does a soft offline of a CPU when writing a 0 to /sys/devices/system/cpu/cpuX/online, which doesn't prevent the #MC exception from being broadcasted to that CPU.
Ensure that offline CPUs don't participate in the MCE rendezvous and clear the RIP valid status bit so that a second MCE won't cause a shutdown.
Without the patch, mce_start() will increment mce_callin and wait for all CPUs. Offlined CPUs should avoid participating in the rendezvous process altogether.
--- arch/x86/kernel/cpu/mcheck/mce.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/kernel/cpu/mcheck/mce.c +11 -0
@@ -999,6 +999,17 @@ void do_machine_check(struct pt_regs *regs, long error_code)int flags =MF_ACTION_REQUIRED ;int lmce =0 ; +/* If this CPU is offline, just bail out. */ +if (cpu_is_offline (smp_processor_id ())) { +u64 mcgstatus; + + mcgstatus =mce_rdmsrl (MSR_IA32_MCG_STATUS ); +if (mcgstatus &MCG_STATUS_RIPV ) { +mce_wrmsrl (MSR_IA32_MCG_STATUS ,0 ); +return ; + } + } +ist_enter (regs);this_cpu_inc (mce_exception_count);
Signature · 1 line
2.3.5
tip-bot for Ashok Raj
merge bot[tip:x86/urgent] x86/mce: Ensure offline CPUs don' t participate in rendezvous process
x86/mce: Ensure offline CPUs don't participate in rendezvous process
Commit-ID: 06f337b7c7eb86254c86e8e717273d1e356d5a1b Gitweb: http://git.kernel.org/tip/06f337b7c7eb86254c86e8e717273d1e356d5a1b Author: Ashok Raj <[email protected]> AuthorDate: Thu, 10 Dec 2015 11:12:26 +0100 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 11 Dec 2015 08:59:48 +0100
x86/mce: Ensure offline CPUs don't participate in rendezvous process
Intel's MCA implementation broadcasts MCEs to all CPUs on the node. This poses a problem for offlined CPUs which cannot participate in the rendezvous process:
Kernel panic - not syncing: Timeout: Not all CPUs entered broadcast exception handler Kernel Offset: disabled Rebooting in 100 seconds..
More specifically, Linux does a soft offline of a CPU when writing a 0 to /sys/devices/system/cpu/cpuX/online, which doesn't prevent the #MC exception from being broadcasted to that CPU.
Ensure that offline CPUs don't participate in the MCE rendezvous and clear the RIP valid status bit so that a second MCE won't cause a shutdown.
Without the patch, mce_start() will increment mce_callin and wait for all CPUs. Offlined CPUs should avoid participating in the rendezvous process altogether.
--- arch/x86/kernel/cpu/mcheck/mce.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/kernel/cpu/mcheck/mce.c +11 -0
@@ -999,6 +999,17 @@ void do_machine_check(struct pt_regs *regs, long error_code)int flags =MF_ACTION_REQUIRED ;int lmce =0 ; +/* If this CPU is offline, just bail out. */ +if (cpu_is_offline (smp_processor_id ())) { +u64 mcgstatus; + + mcgstatus =mce_rdmsrl (MSR_IA32_MCG_STATUS ); +if (mcgstatus &MCG_STATUS_RIPV ) { +mce_wrmsrl (MSR_IA32_MCG_STATUS ,0 ); +return ; + } + } +ist_enter (regs);this_cpu_inc (mce_exception_count);
tip-bot for Ashok Raj
merge bot[tip:x86/urgent] x86/mce: Ensure offline CPUs don' t participate in rendezvous process
In reply to Borislav Petkovx86/mce: Ensure offline CPUs don't participate in rendezvous process
Commit-ID: d90167a941f62860f35eb960e1012aa2d30e7e94 Gitweb: http://git.kernel.org/tip/d90167a941f62860f35eb960e1012aa2d30e7e94 Author: Ashok Raj <[email protected]> AuthorDate: Thu, 10 Dec 2015 11:12:26 +0100 Committer: Thomas Gleixner <[email protected]> CommitDate: Sat, 19 Dec 2015 09:55:31 +0100
x86/mce: Ensure offline CPUs don't participate in rendezvous process
Intel's MCA implementation broadcasts MCEs to all CPUs on the node. This poses a problem for offlined CPUs which cannot participate in the rendezvous process:
Kernel panic - not syncing: Timeout: Not all CPUs entered broadcast exception handler Kernel Offset: disabled Rebooting in 100 seconds..
More specifically, Linux does a soft offline of a CPU when writing a 0 to /sys/devices/system/cpu/cpuX/online, which doesn't prevent the #MC exception from being broadcasted to that CPU.
Ensure that offline CPUs don't participate in the MCE rendezvous and clear the RIP valid status bit so that a second MCE won't cause a shutdown.
Without the patch, mce_start() will increment mce_callin and wait for all CPUs. Offlined CPUs should avoid participating in the rendezvous process altogether.
--- arch/x86/kernel/cpu/mcheck/mce.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/kernel/cpu/mcheck/mce.c +11 -0
@@ -999,6 +999,17 @@ void do_machine_check(struct pt_regs *regs, long error_code)int flags =MF_ACTION_REQUIRED ;int lmce =0 ; +/* If this CPU is offline, just bail out. */ +if (cpu_is_offline (smp_processor_id ())) { +u64 mcgstatus; + + mcgstatus =mce_rdmsrl (MSR_IA32_MCG_STATUS ); +if (mcgstatus &MCG_STATUS_RIPV ) { +mce_wrmsrl (MSR_IA32_MCG_STATUS ,0 ); +return ; + } + } +ist_enter (regs);this_cpu_inc (mce_exception_count);