perf build failure on latest tip.
When compiling perf on latest tip/master
I see the following error
cc1: warnings being treated as errorsutil/newt.c: In function ‘hist_entry__tui_annotate’:util/newt.c:764: warning: ‘ret’ is used uninitialized in this function
make: *** [util/newt.o] Error 1
I think the problem was introduced by commit13f499f076c67675e6e3022973729b5d906a84e9
Below is a patch that fixes the problem.
---
tools/perf/util/newt.c +1 -1
@@ -753,7 +753,7 @@ int hist_entry__tui_annotate(struct hist_entry *self) browser.width +=18 ;/* Percentage */ ui_browser__show (&browser, self->ms.sym->name); -ui_browser__run (&browser, &es); + ret =ui_browser__run (&browser, &es);newtFormDestroy (browser.form);newtPopWindow ();list_for_each_entry_safe (pos, n, &head, node) {
[tip:perf/core] perf: Fix hist_entry__tui_annotate() build failure
Commit-ID: 0879b100f3c187257729f36cba33d96ec2875766 Gitweb: http://git.kernel.org/tip/0879b100f3c187257729f36cba33d96ec2875766 Author: Srikar Dronamraju <[email protected]> AuthorDate: Tue, 29 Jun 2010 23:02:26 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Tue, 29 Jun 2010 22:59:05 +0200
perf: Fix hist_entry__tui_annotate() build failure
When compiling perf on latest tip/master I see the following error:
cc1: warnings being treated as errors util/newt.c: In function 'hist_entry__tui_annotate':
util/newt.c:764: warning: 'ret' is used uninitialized in this function make: *** [util/newt.o] Error 1
I think the problem was introduced by commit13f499f076c67675e6e3022973729b5d906a84e9
Below is a patch that fixes the problem.
LKML-Reference: <[email protected]>
--- tools/perf/util/newt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/util/newt.c +1 -1
@@ -753,7 +753,7 @@ int hist_entry__tui_annotate(struct hist_entry *self) browser.width +=18 ;/* Percentage */ ui_browser__show (&browser, self->ms.sym->name); -ui_browser__run (&browser, &es); + ret =ui_browser__run (&browser, &es);newtFormDestroy (browser.form);newtPopWindow ();list_for_each_entry_safe (pos, n, &head, node) {